]> asedeno.scripts.mit.edu Git - linux.git/blob - drivers/gpu/drm/imx/parallel-display.c
drm/imx: fix opencoded use of drm_panel_*
[linux.git] / drivers / gpu / drm / imx / parallel-display.c
1 // SPDX-License-Identifier: GPL-2.0+
2 /*
3  * i.MX drm driver - parallel display implementation
4  *
5  * Copyright (C) 2012 Sascha Hauer, Pengutronix
6  */
7
8 #include <linux/component.h>
9 #include <linux/module.h>
10 #include <linux/platform_device.h>
11 #include <linux/videodev2.h>
12
13 #include <video/of_display_timing.h>
14
15 #include <drm/drm_atomic_helper.h>
16 #include <drm/drm_fb_helper.h>
17 #include <drm/drm_of.h>
18 #include <drm/drm_panel.h>
19 #include <drm/drm_probe_helper.h>
20
21 #include "imx-drm.h"
22
23 struct imx_parallel_display {
24         struct drm_connector connector;
25         struct drm_encoder encoder;
26         struct device *dev;
27         void *edid;
28         int edid_len;
29         u32 bus_format;
30         u32 bus_flags;
31         struct drm_display_mode mode;
32         struct drm_panel *panel;
33         struct drm_bridge *bridge;
34 };
35
36 static inline struct imx_parallel_display *con_to_imxpd(struct drm_connector *c)
37 {
38         return container_of(c, struct imx_parallel_display, connector);
39 }
40
41 static inline struct imx_parallel_display *enc_to_imxpd(struct drm_encoder *e)
42 {
43         return container_of(e, struct imx_parallel_display, encoder);
44 }
45
46 static int imx_pd_connector_get_modes(struct drm_connector *connector)
47 {
48         struct imx_parallel_display *imxpd = con_to_imxpd(connector);
49         struct device_node *np = imxpd->dev->of_node;
50         int num_modes;
51
52         num_modes = drm_panel_get_modes(imxpd->panel);
53         if (num_modes > 0)
54                 return num_modes;
55
56         if (imxpd->edid) {
57                 drm_connector_update_edid_property(connector, imxpd->edid);
58                 num_modes = drm_add_edid_modes(connector, imxpd->edid);
59         }
60
61         if (np) {
62                 struct drm_display_mode *mode = drm_mode_create(connector->dev);
63                 int ret;
64
65                 if (!mode)
66                         return -EINVAL;
67
68                 ret = of_get_drm_display_mode(np, &imxpd->mode,
69                                               &imxpd->bus_flags,
70                                               OF_USE_NATIVE_MODE);
71                 if (ret)
72                         return ret;
73
74                 drm_mode_copy(mode, &imxpd->mode);
75                 mode->type |= DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED,
76                 drm_mode_probed_add(connector, mode);
77                 num_modes++;
78         }
79
80         return num_modes;
81 }
82
83 static struct drm_encoder *imx_pd_connector_best_encoder(
84                 struct drm_connector *connector)
85 {
86         struct imx_parallel_display *imxpd = con_to_imxpd(connector);
87
88         return &imxpd->encoder;
89 }
90
91 static void imx_pd_encoder_enable(struct drm_encoder *encoder)
92 {
93         struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
94
95         drm_panel_prepare(imxpd->panel);
96         drm_panel_enable(imxpd->panel);
97 }
98
99 static void imx_pd_encoder_disable(struct drm_encoder *encoder)
100 {
101         struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
102
103         drm_panel_disable(imxpd->panel);
104         drm_panel_unprepare(imxpd->panel);
105 }
106
107 static int imx_pd_encoder_atomic_check(struct drm_encoder *encoder,
108                                        struct drm_crtc_state *crtc_state,
109                                        struct drm_connector_state *conn_state)
110 {
111         struct imx_crtc_state *imx_crtc_state = to_imx_crtc_state(crtc_state);
112         struct drm_display_info *di = &conn_state->connector->display_info;
113         struct imx_parallel_display *imxpd = enc_to_imxpd(encoder);
114
115         if (!imxpd->bus_format && di->num_bus_formats) {
116                 imx_crtc_state->bus_flags = di->bus_flags;
117                 imx_crtc_state->bus_format = di->bus_formats[0];
118         } else {
119                 imx_crtc_state->bus_flags = imxpd->bus_flags;
120                 imx_crtc_state->bus_format = imxpd->bus_format;
121         }
122         imx_crtc_state->di_hsync_pin = 2;
123         imx_crtc_state->di_vsync_pin = 3;
124
125         return 0;
126 }
127
128 static const struct drm_connector_funcs imx_pd_connector_funcs = {
129         .fill_modes = drm_helper_probe_single_connector_modes,
130         .destroy = imx_drm_connector_destroy,
131         .reset = drm_atomic_helper_connector_reset,
132         .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
133         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
134 };
135
136 static const struct drm_connector_helper_funcs imx_pd_connector_helper_funcs = {
137         .get_modes = imx_pd_connector_get_modes,
138         .best_encoder = imx_pd_connector_best_encoder,
139 };
140
141 static const struct drm_encoder_funcs imx_pd_encoder_funcs = {
142         .destroy = imx_drm_encoder_destroy,
143 };
144
145 static const struct drm_encoder_helper_funcs imx_pd_encoder_helper_funcs = {
146         .enable = imx_pd_encoder_enable,
147         .disable = imx_pd_encoder_disable,
148         .atomic_check = imx_pd_encoder_atomic_check,
149 };
150
151 static int imx_pd_register(struct drm_device *drm,
152         struct imx_parallel_display *imxpd)
153 {
154         struct drm_encoder *encoder = &imxpd->encoder;
155         int ret;
156
157         ret = imx_drm_encoder_parse_of(drm, encoder, imxpd->dev->of_node);
158         if (ret)
159                 return ret;
160
161         /* set the connector's dpms to OFF so that
162          * drm_helper_connector_dpms() won't return
163          * immediately since the current state is ON
164          * at this point.
165          */
166         imxpd->connector.dpms = DRM_MODE_DPMS_OFF;
167
168         drm_encoder_helper_add(encoder, &imx_pd_encoder_helper_funcs);
169         drm_encoder_init(drm, encoder, &imx_pd_encoder_funcs,
170                          DRM_MODE_ENCODER_NONE, NULL);
171
172         if (!imxpd->bridge) {
173                 drm_connector_helper_add(&imxpd->connector,
174                                 &imx_pd_connector_helper_funcs);
175                 drm_connector_init(drm, &imxpd->connector,
176                                    &imx_pd_connector_funcs,
177                                    DRM_MODE_CONNECTOR_DPI);
178         }
179
180         if (imxpd->panel)
181                 drm_panel_attach(imxpd->panel, &imxpd->connector);
182
183         if (imxpd->bridge) {
184                 ret = drm_bridge_attach(encoder, imxpd->bridge, NULL);
185                 if (ret < 0) {
186                         dev_err(imxpd->dev, "failed to attach bridge: %d\n",
187                                 ret);
188                         return ret;
189                 }
190         } else {
191                 drm_connector_attach_encoder(&imxpd->connector, encoder);
192         }
193
194         return 0;
195 }
196
197 static int imx_pd_bind(struct device *dev, struct device *master, void *data)
198 {
199         struct drm_device *drm = data;
200         struct device_node *np = dev->of_node;
201         const u8 *edidp;
202         struct imx_parallel_display *imxpd;
203         int ret;
204         u32 bus_format = 0;
205         const char *fmt;
206
207         imxpd = devm_kzalloc(dev, sizeof(*imxpd), GFP_KERNEL);
208         if (!imxpd)
209                 return -ENOMEM;
210
211         edidp = of_get_property(np, "edid", &imxpd->edid_len);
212         if (edidp)
213                 imxpd->edid = kmemdup(edidp, imxpd->edid_len, GFP_KERNEL);
214
215         ret = of_property_read_string(np, "interface-pix-fmt", &fmt);
216         if (!ret) {
217                 if (!strcmp(fmt, "rgb24"))
218                         bus_format = MEDIA_BUS_FMT_RGB888_1X24;
219                 else if (!strcmp(fmt, "rgb565"))
220                         bus_format = MEDIA_BUS_FMT_RGB565_1X16;
221                 else if (!strcmp(fmt, "bgr666"))
222                         bus_format = MEDIA_BUS_FMT_RGB666_1X18;
223                 else if (!strcmp(fmt, "lvds666"))
224                         bus_format = MEDIA_BUS_FMT_RGB666_1X24_CPADHI;
225         }
226         imxpd->bus_format = bus_format;
227
228         /* port@1 is the output port */
229         ret = drm_of_find_panel_or_bridge(np, 1, 0, &imxpd->panel, &imxpd->bridge);
230         if (ret && ret != -ENODEV)
231                 return ret;
232
233         imxpd->dev = dev;
234
235         ret = imx_pd_register(drm, imxpd);
236         if (ret)
237                 return ret;
238
239         dev_set_drvdata(dev, imxpd);
240
241         return 0;
242 }
243
244 static void imx_pd_unbind(struct device *dev, struct device *master,
245         void *data)
246 {
247         struct imx_parallel_display *imxpd = dev_get_drvdata(dev);
248
249         if (imxpd->panel)
250                 drm_panel_detach(imxpd->panel);
251
252         kfree(imxpd->edid);
253 }
254
255 static const struct component_ops imx_pd_ops = {
256         .bind   = imx_pd_bind,
257         .unbind = imx_pd_unbind,
258 };
259
260 static int imx_pd_probe(struct platform_device *pdev)
261 {
262         return component_add(&pdev->dev, &imx_pd_ops);
263 }
264
265 static int imx_pd_remove(struct platform_device *pdev)
266 {
267         component_del(&pdev->dev, &imx_pd_ops);
268
269         return 0;
270 }
271
272 static const struct of_device_id imx_pd_dt_ids[] = {
273         { .compatible = "fsl,imx-parallel-display", },
274         { /* sentinel */ }
275 };
276 MODULE_DEVICE_TABLE(of, imx_pd_dt_ids);
277
278 static struct platform_driver imx_pd_driver = {
279         .probe          = imx_pd_probe,
280         .remove         = imx_pd_remove,
281         .driver         = {
282                 .of_match_table = imx_pd_dt_ids,
283                 .name   = "imx-parallel-display",
284         },
285 };
286
287 module_platform_driver(imx_pd_driver);
288
289 MODULE_DESCRIPTION("i.MX parallel display driver");
290 MODULE_AUTHOR("Sascha Hauer, Pengutronix");
291 MODULE_LICENSE("GPL");
292 MODULE_ALIAS("platform:imx-parallel-display");