net/dsa/slave.c

   1 /*
   2  * net/dsa/slave.c - Slave device handling
   3  * Copyright (c) 2008-2009 Marvell Semiconductor
   4  *
   5  * This program is free software; you can redistribute it and/or modify
   6  * it under the terms of the GNU General Public License as published by
   7  * the Free Software Foundation; either version 2 of the License, or
   8  * (at your option) any later version.
   9  */
  10
  11 #include <linux/list.h>
  12 #include <linux/etherdevice.h>
  13 #include <linux/netdevice.h>
  14 #include <linux/phy.h>
  15 #include <linux/phy_fixed.h>
  16 #include <linux/of_net.h>
  17 #include <linux/of_mdio.h>
  18 #include <linux/mdio.h>
  19 #include <linux/list.h>
  20 #include <net/rtnetlink.h>
  21 #include <net/pkt_cls.h>
  22 #include <net/tc_act/tc_mirred.h>
  23 #include <linux/if_bridge.h>
  24 #include <linux/netpoll.h>
  25
  26 #include "dsa_priv.h"
  27
  28 static bool dsa_slave_dev_check(struct net_device *dev);
  29
  30 /* slave mii_bus handling ***************************************************/
  31 static int dsa_slave_phy_read(struct mii_bus *bus, int addr, int reg)
  32 {
  33         struct dsa_switch *ds = bus->priv;
  34
  35         if (ds->phys_mii_mask & (1 << addr))
  36                 return ds->ops->phy_read(ds, addr, reg);
  37
  38         return 0xffff;
  39 }
  40
  41 static int dsa_slave_phy_write(struct mii_bus *bus, int addr, int reg, u16 val)
  42 {
  43         struct dsa_switch *ds = bus->priv;
  44
  45         if (ds->phys_mii_mask & (1 << addr))
  46                 return ds->ops->phy_write(ds, addr, reg, val);
  47
  48         return 0;
  49 }
  50
  51 void dsa_slave_mii_bus_init(struct dsa_switch *ds)
  52 {
  53         ds->slave_mii_bus->priv = (void *)ds;
  54         ds->slave_mii_bus->name = "dsa slave smi";
  55         ds->slave_mii_bus->read = dsa_slave_phy_read;
  56         ds->slave_mii_bus->write = dsa_slave_phy_write;
  57         snprintf(ds->slave_mii_bus->id, MII_BUS_ID_SIZE, "dsa-%d.%d",
  58                  ds->dst->tree, ds->index);
  59         ds->slave_mii_bus->parent = ds->dev;
  60         ds->slave_mii_bus->phy_mask = ~ds->phys_mii_mask;
  61 }
  62
  63
  64 /* slave device handling ****************************************************/
  65 static int dsa_slave_get_iflink(const struct net_device *dev)
  66 {
  67         struct dsa_slave_priv *p = netdev_priv(dev);
  68
  69         return dsa_master_netdev(p)->ifindex;
  70 }
  71
  72 static int dsa_slave_open(struct net_device *dev)
  73 {
  74         struct dsa_slave_priv *p = netdev_priv(dev);
  75         struct dsa_port *dp = p->dp;
  76         struct dsa_switch *ds = dp->ds;
  77         struct net_device *master = dsa_master_netdev(p);
  78         u8 stp_state = dp->bridge_dev ? BR_STATE_BLOCKING : BR_STATE_FORWARDING;
  79         int err;
  80
  81         if (!(master->flags & IFF_UP))
  82                 return -ENETDOWN;
  83
  84         if (!ether_addr_equal(dev->dev_addr, master->dev_addr)) {
  85                 err = dev_uc_add(master, dev->dev_addr);
  86                 if (err < 0)
  87                         goto out;
  88         }
  89
  90         if (dev->flags & IFF_ALLMULTI) {
  91                 err = dev_set_allmulti(master, 1);
  92                 if (err < 0)
  93                         goto del_unicast;
  94         }
  95         if (dev->flags & IFF_PROMISC) {
  96                 err = dev_set_promiscuity(master, 1);
  97                 if (err < 0)
  98                         goto clear_allmulti;
  99         }
 100
 101         if (ds->ops->port_enable) {
 102                 err = ds->ops->port_enable(ds, p->dp->index, p->phy);
 103                 if (err)
 104                         goto clear_promisc;
 105         }
 106
 107         dsa_port_set_state_now(p->dp, stp_state);
 108
 109         if (p->phy)
 110                 phy_start(p->phy);
 111
 112         return 0;
 113
 114 clear_promisc:
 115         if (dev->flags & IFF_PROMISC)
 116                 dev_set_promiscuity(master, -1);
 117 clear_allmulti:
 118         if (dev->flags & IFF_ALLMULTI)
 119                 dev_set_allmulti(master, -1);
 120 del_unicast:
 121         if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
 122                 dev_uc_del(master, dev->dev_addr);
 123 out:
 124         return err;
 125 }
 126
 127 static int dsa_slave_close(struct net_device *dev)
 128 {
 129         struct dsa_slave_priv *p = netdev_priv(dev);
 130         struct net_device *master = dsa_master_netdev(p);
 131         struct dsa_switch *ds = p->dp->ds;
 132
 133         if (p->phy)
 134                 phy_stop(p->phy);
 135
 136         dev_mc_unsync(master, dev);
 137         dev_uc_unsync(master, dev);
 138         if (dev->flags & IFF_ALLMULTI)
 139                 dev_set_allmulti(master, -1);
 140         if (dev->flags & IFF_PROMISC)
 141                 dev_set_promiscuity(master, -1);
 142
 143         if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
 144                 dev_uc_del(master, dev->dev_addr);
 145
 146         if (ds->ops->port_disable)
 147                 ds->ops->port_disable(ds, p->dp->index, p->phy);
 148
 149         dsa_port_set_state_now(p->dp, BR_STATE_DISABLED);
 150
 151         return 0;
 152 }
 153
 154 static void dsa_slave_change_rx_flags(struct net_device *dev, int change)
 155 {
 156         struct dsa_slave_priv *p = netdev_priv(dev);
 157         struct net_device *master = dsa_master_netdev(p);
 158
 159         if (change & IFF_ALLMULTI)
 160                 dev_set_allmulti(master, dev->flags & IFF_ALLMULTI ? 1 : -1);
 161         if (change & IFF_PROMISC)
 162                 dev_set_promiscuity(master, dev->flags & IFF_PROMISC ? 1 : -1);
 163 }
 164
 165 static void dsa_slave_set_rx_mode(struct net_device *dev)
 166 {
 167         struct dsa_slave_priv *p = netdev_priv(dev);
 168         struct net_device *master = dsa_master_netdev(p);
 169
 170         dev_mc_sync(master, dev);
 171         dev_uc_sync(master, dev);
 172 }
 173
 174 static int dsa_slave_set_mac_address(struct net_device *dev, void *a)
 175 {
 176         struct dsa_slave_priv *p = netdev_priv(dev);
 177         struct net_device *master = dsa_master_netdev(p);
 178         struct sockaddr *addr = a;
 179         int err;
 180
 181         if (!is_valid_ether_addr(addr->sa_data))
 182                 return -EADDRNOTAVAIL;
 183
 184         if (!(dev->flags & IFF_UP))
 185                 goto out;
 186
 187         if (!ether_addr_equal(addr->sa_data, master->dev_addr)) {
 188                 err = dev_uc_add(master, addr->sa_data);
 189                 if (err < 0)
 190                         return err;
 191         }
 192
 193         if (!ether_addr_equal(dev->dev_addr, master->dev_addr))
 194                 dev_uc_del(master, dev->dev_addr);
 195
 196 out:
 197         ether_addr_copy(dev->dev_addr, addr->sa_data);
 198
 199         return 0;
 200 }
 201
 202 static int dsa_slave_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
 203 {
 204         struct dsa_slave_priv *p = netdev_priv(dev);
 205
 206         if (p->phy != NULL)
 207                 return phy_mii_ioctl(p->phy, ifr, cmd);
 208
 209         return -EOPNOTSUPP;
 210 }
 211
 212 static int dsa_slave_port_attr_set(struct net_device *dev,
 213                                    const struct switchdev_attr *attr,
 214                                    struct switchdev_trans *trans)
 215 {
 216         struct dsa_slave_priv *p = netdev_priv(dev);
 217         struct dsa_port *dp = p->dp;
 218         int ret;
 219
 220         switch (attr->id) {
 221         case SWITCHDEV_ATTR_ID_PORT_STP_STATE:
 222                 ret = dsa_port_set_state(dp, attr->u.stp_state, trans);
 223                 break;
 224         case SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING:
 225                 ret = dsa_port_vlan_filtering(dp, attr->u.vlan_filtering,
 226                                               trans);
 227                 break;
 228         case SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME:
 229                 ret = dsa_port_ageing_time(dp, attr->u.ageing_time, trans);
 230                 break;
 231         default:
 232                 ret = -EOPNOTSUPP;
 233                 break;
 234         }
 235
 236         return ret;
 237 }
 238
 239 static int dsa_slave_port_obj_add(struct net_device *dev,
 240                                   const struct switchdev_obj *obj,
 241                                   struct switchdev_trans *trans)
 242 {
 243         struct dsa_slave_priv *p = netdev_priv(dev);
 244         struct dsa_port *dp = p->dp;
 245         int err;
 246
 247         /* For the prepare phase, ensure the full set of changes is feasable in
 248          * one go in order to signal a failure properly. If an operation is not
 249          * supported, return -EOPNOTSUPP.
 250          */
 251
 252         switch (obj->id) {
 253         case SWITCHDEV_OBJ_ID_PORT_FDB:
 254                 err = dsa_port_fdb_add(dp, SWITCHDEV_OBJ_PORT_FDB(obj), trans);
 255                 break;
 256         case SWITCHDEV_OBJ_ID_PORT_MDB:
 257                 err = dsa_port_mdb_add(dp, SWITCHDEV_OBJ_PORT_MDB(obj), trans);
 258                 break;
 259         case SWITCHDEV_OBJ_ID_PORT_VLAN:
 260                 err = dsa_port_vlan_add(dp, SWITCHDEV_OBJ_PORT_VLAN(obj),
 261                                         trans);
 262                 break;
 263         default:
 264                 err = -EOPNOTSUPP;
 265                 break;
 266         }
 267
 268         return err;
 269 }
 270
 271 static int dsa_slave_port_obj_del(struct net_device *dev,
 272                                   const struct switchdev_obj *obj)
 273 {
 274         struct dsa_slave_priv *p = netdev_priv(dev);
 275         struct dsa_port *dp = p->dp;
 276         int err;
 277
 278         switch (obj->id) {
 279         case SWITCHDEV_OBJ_ID_PORT_FDB:
 280                 err = dsa_port_fdb_del(dp, SWITCHDEV_OBJ_PORT_FDB(obj));
 281                 break;
 282         case SWITCHDEV_OBJ_ID_PORT_MDB:
 283                 err = dsa_port_mdb_del(dp, SWITCHDEV_OBJ_PORT_MDB(obj));
 284                 break;
 285         case SWITCHDEV_OBJ_ID_PORT_VLAN:
 286                 err = dsa_port_vlan_del(dp, SWITCHDEV_OBJ_PORT_VLAN(obj));
 287                 break;
 288         default:
 289                 err = -EOPNOTSUPP;
 290                 break;
 291         }
 292
 293         return err;
 294 }
 295
 296 static int dsa_slave_port_obj_dump(struct net_device *dev,
 297                                    struct switchdev_obj *obj,
 298                                    switchdev_obj_dump_cb_t *cb)
 299 {
 300         struct dsa_slave_priv *p = netdev_priv(dev);
 301         struct dsa_port *dp = p->dp;
 302         int err;
 303
 304         switch (obj->id) {
 305         case SWITCHDEV_OBJ_ID_PORT_FDB:
 306                 err = dsa_port_fdb_dump(dp, SWITCHDEV_OBJ_PORT_FDB(obj), cb);
 307                 break;
 308         case SWITCHDEV_OBJ_ID_PORT_MDB:
 309                 err = dsa_port_mdb_dump(dp, SWITCHDEV_OBJ_PORT_MDB(obj), cb);
 310                 break;
 311         case SWITCHDEV_OBJ_ID_PORT_VLAN:
 312                 err = dsa_port_vlan_dump(dp, SWITCHDEV_OBJ_PORT_VLAN(obj), cb);
 313                 break;
 314         default:
 315                 err = -EOPNOTSUPP;
 316                 break;
 317         }
 318
 319         return err;
 320 }
 321
 322 static int dsa_slave_port_attr_get(struct net_device *dev,
 323                                    struct switchdev_attr *attr)
 324 {
 325         struct dsa_slave_priv *p = netdev_priv(dev);
 326         struct dsa_switch *ds = p->dp->ds;
 327
 328         switch (attr->id) {
 329         case SWITCHDEV_ATTR_ID_PORT_PARENT_ID:
 330                 attr->u.ppid.id_len = sizeof(ds->index);
 331                 memcpy(&attr->u.ppid.id, &ds->index, attr->u.ppid.id_len);
 332                 break;
 333         default:
 334                 return -EOPNOTSUPP;
 335         }
 336
 337         return 0;
 338 }
 339
 340 static inline netdev_tx_t dsa_netpoll_send_skb(struct dsa_slave_priv *p,
 341                                                struct sk_buff *skb)
 342 {
 343 #ifdef CONFIG_NET_POLL_CONTROLLER
 344         if (p->netpoll)
 345                 netpoll_send_skb(p->netpoll, skb);
 346 #else
 347         BUG();
 348 #endif
 349         return NETDEV_TX_OK;
 350 }
 351
 352 static netdev_tx_t dsa_slave_xmit(struct sk_buff *skb, struct net_device *dev)
 353 {
 354         struct dsa_slave_priv *p = netdev_priv(dev);
 355         struct sk_buff *nskb;
 356
 357         dev->stats.tx_packets++;
 358         dev->stats.tx_bytes += skb->len;
 359
 360         /* Transmit function may have to reallocate the original SKB,
 361          * in which case it must have freed it. Only free it here on error.
 362          */
 363         nskb = p->xmit(skb, dev);
 364         if (!nskb) {
 365                 kfree_skb(skb);
 366                 return NETDEV_TX_OK;
 367         }
 368
 369         /* SKB for netpoll still need to be mangled with the protocol-specific
 370          * tag to be successfully transmitted
 371          */
 372         if (unlikely(netpoll_tx_running(dev)))
 373                 return dsa_netpoll_send_skb(p, nskb);
 374
 375         /* Queue the SKB for transmission on the parent interface, but
 376          * do not modify its EtherType
 377          */
 378         nskb->dev = dsa_master_netdev(p);
 379         dev_queue_xmit(nskb);
 380
 381         return NETDEV_TX_OK;
 382 }
 383
 384 /* ethtool operations *******************************************************/
 385 static int
 386 dsa_slave_get_link_ksettings(struct net_device *dev,
 387                              struct ethtool_link_ksettings *cmd)
 388 {
 389         struct dsa_slave_priv *p = netdev_priv(dev);
 390
 391         if (!p->phy)
 392                 return -EOPNOTSUPP;
 393
 394         phy_ethtool_ksettings_get(p->phy, cmd);
 395
 396         return 0;
 397 }
 398
 399 static int
 400 dsa_slave_set_link_ksettings(struct net_device *dev,
 401                              const struct ethtool_link_ksettings *cmd)
 402 {
 403         struct dsa_slave_priv *p = netdev_priv(dev);
 404
 405         if (p->phy != NULL)
 406                 return phy_ethtool_ksettings_set(p->phy, cmd);
 407
 408         return -EOPNOTSUPP;
 409 }
 410
 411 static void dsa_slave_get_drvinfo(struct net_device *dev,
 412                                   struct ethtool_drvinfo *drvinfo)
 413 {
 414         strlcpy(drvinfo->driver, "dsa", sizeof(drvinfo->driver));
 415         strlcpy(drvinfo->fw_version, "N/A", sizeof(drvinfo->fw_version));
 416         strlcpy(drvinfo->bus_info, "platform", sizeof(drvinfo->bus_info));
 417 }
 418
 419 static int dsa_slave_get_regs_len(struct net_device *dev)
 420 {
 421         struct dsa_slave_priv *p = netdev_priv(dev);
 422         struct dsa_switch *ds = p->dp->ds;
 423
 424         if (ds->ops->get_regs_len)
 425                 return ds->ops->get_regs_len(ds, p->dp->index);
 426
 427         return -EOPNOTSUPP;
 428 }
 429
 430 static void
 431 dsa_slave_get_regs(struct net_device *dev, struct ethtool_regs *regs, void *_p)
 432 {
 433         struct dsa_slave_priv *p = netdev_priv(dev);
 434         struct dsa_switch *ds = p->dp->ds;
 435
 436         if (ds->ops->get_regs)
 437                 ds->ops->get_regs(ds, p->dp->index, regs, _p);
 438 }
 439
 440 static int dsa_slave_nway_reset(struct net_device *dev)
 441 {
 442         struct dsa_slave_priv *p = netdev_priv(dev);
 443
 444         if (p->phy != NULL)
 445                 return genphy_restart_aneg(p->phy);
 446
 447         return -EOPNOTSUPP;
 448 }
 449
 450 static u32 dsa_slave_get_link(struct net_device *dev)
 451 {
 452         struct dsa_slave_priv *p = netdev_priv(dev);
 453
 454         if (p->phy != NULL) {
 455                 genphy_update_link(p->phy);
 456                 return p->phy->link;
 457         }
 458
 459         return -EOPNOTSUPP;
 460 }
 461
 462 static int dsa_slave_get_eeprom_len(struct net_device *dev)
 463 {
 464         struct dsa_slave_priv *p = netdev_priv(dev);
 465         struct dsa_switch *ds = p->dp->ds;
 466
 467         if (ds->cd && ds->cd->eeprom_len)
 468                 return ds->cd->eeprom_len;
 469
 470         if (ds->ops->get_eeprom_len)
 471                 return ds->ops->get_eeprom_len(ds);
 472
 473         return 0;
 474 }
 475
 476 static int dsa_slave_get_eeprom(struct net_device *dev,
 477                                 struct ethtool_eeprom *eeprom, u8 *data)
 478 {
 479         struct dsa_slave_priv *p = netdev_priv(dev);
 480         struct dsa_switch *ds = p->dp->ds;
 481
 482         if (ds->ops->get_eeprom)
 483                 return ds->ops->get_eeprom(ds, eeprom, data);
 484
 485         return -EOPNOTSUPP;
 486 }
 487
 488 static int dsa_slave_set_eeprom(struct net_device *dev,
 489                                 struct ethtool_eeprom *eeprom, u8 *data)
 490 {
 491         struct dsa_slave_priv *p = netdev_priv(dev);
 492         struct dsa_switch *ds = p->dp->ds;
 493
 494         if (ds->ops->set_eeprom)
 495                 return ds->ops->set_eeprom(ds, eeprom, data);
 496
 497         return -EOPNOTSUPP;
 498 }
 499
 500 static void dsa_slave_get_strings(struct net_device *dev,
 501                                   uint32_t stringset, uint8_t *data)
 502 {
 503         struct dsa_slave_priv *p = netdev_priv(dev);
 504         struct dsa_switch *ds = p->dp->ds;
 505
 506         if (stringset == ETH_SS_STATS) {
 507                 int len = ETH_GSTRING_LEN;
 508
 509                 strncpy(data, "tx_packets", len);
 510                 strncpy(data + len, "tx_bytes", len);
 511                 strncpy(data + 2 * len, "rx_packets", len);
 512                 strncpy(data + 3 * len, "rx_bytes", len);
 513                 if (ds->ops->get_strings)
 514                         ds->ops->get_strings(ds, p->dp->index, data + 4 * len);
 515         }
 516 }
 517
 518 static void dsa_cpu_port_get_ethtool_stats(struct net_device *dev,
 519                                            struct ethtool_stats *stats,
 520                                            uint64_t *data)
 521 {
 522         struct dsa_switch_tree *dst = dev->dsa_ptr;
 523         struct dsa_port *cpu_dp = dsa_get_cpu_port(dst);
 524         struct dsa_switch *ds = cpu_dp->ds;
 525         s8 cpu_port = cpu_dp->index;
 526         int count = 0;
 527
 528         if (cpu_dp->ethtool_ops.get_sset_count) {
 529                 count = cpu_dp->ethtool_ops.get_sset_count(dev, ETH_SS_STATS);
 530                 cpu_dp->ethtool_ops.get_ethtool_stats(dev, stats, data);
 531         }
 532
 533         if (ds->ops->get_ethtool_stats)
 534                 ds->ops->get_ethtool_stats(ds, cpu_port, data + count);
 535 }
 536
 537 static int dsa_cpu_port_get_sset_count(struct net_device *dev, int sset)
 538 {
 539         struct dsa_switch_tree *dst = dev->dsa_ptr;
 540         struct dsa_port *cpu_dp = dsa_get_cpu_port(dst);
 541         struct dsa_switch *ds = cpu_dp->ds;
 542         int count = 0;
 543
 544         if (cpu_dp->ethtool_ops.get_sset_count)
 545                 count += cpu_dp->ethtool_ops.get_sset_count(dev, sset);
 546
 547         if (sset == ETH_SS_STATS && ds->ops->get_sset_count)
 548                 count += ds->ops->get_sset_count(ds);
 549
 550         return count;
 551 }
 552
 553 static void dsa_cpu_port_get_strings(struct net_device *dev,
 554                                      uint32_t stringset, uint8_t *data)
 555 {
 556         struct dsa_switch_tree *dst = dev->dsa_ptr;
 557         struct dsa_port *cpu_dp = dsa_get_cpu_port(dst);
 558         struct dsa_switch *ds = cpu_dp->ds;
 559         s8 cpu_port = cpu_dp->index;
 560         int len = ETH_GSTRING_LEN;
 561         int mcount = 0, count;
 562         unsigned int i;
 563         uint8_t pfx[4];
 564         uint8_t *ndata;
 565
 566         snprintf(pfx, sizeof(pfx), "p%.2d", cpu_port);
 567         /* We do not want to be NULL-terminated, since this is a prefix */
 568         pfx[sizeof(pfx) - 1] = '_';
 569
 570         if (cpu_dp->ethtool_ops.get_sset_count) {
 571                 mcount = cpu_dp->ethtool_ops.get_sset_count(dev, ETH_SS_STATS);
 572                 cpu_dp->ethtool_ops.get_strings(dev, stringset, data);
 573         }
 574
 575         if (stringset == ETH_SS_STATS && ds->ops->get_strings) {
 576                 ndata = data + mcount * len;
 577                 /* This function copies ETH_GSTRINGS_LEN bytes, we will mangle
 578                  * the output after to prepend our CPU port prefix we
 579                  * constructed earlier
 580                  */
 581                 ds->ops->get_strings(ds, cpu_port, ndata);
 582                 count = ds->ops->get_sset_count(ds);
 583                 for (i = 0; i < count; i++) {
 584                         memmove(ndata + (i * len + sizeof(pfx)),
 585                                 ndata + i * len, len - sizeof(pfx));
 586                         memcpy(ndata + i * len, pfx, sizeof(pfx));
 587                 }
 588         }
 589 }
 590
 591 static void dsa_slave_get_ethtool_stats(struct net_device *dev,
 592                                         struct ethtool_stats *stats,
 593                                         uint64_t *data)
 594 {
 595         struct dsa_slave_priv *p = netdev_priv(dev);
 596         struct dsa_switch *ds = p->dp->ds;
 597
 598         data[0] = dev->stats.tx_packets;
 599         data[1] = dev->stats.tx_bytes;
 600         data[2] = dev->stats.rx_packets;
 601         data[3] = dev->stats.rx_bytes;
 602         if (ds->ops->get_ethtool_stats)
 603                 ds->ops->get_ethtool_stats(ds, p->dp->index, data + 4);
 604 }
 605
 606 static int dsa_slave_get_sset_count(struct net_device *dev, int sset)
 607 {
 608         struct dsa_slave_priv *p = netdev_priv(dev);
 609         struct dsa_switch *ds = p->dp->ds;
 610
 611         if (sset == ETH_SS_STATS) {
 612                 int count;
 613
 614                 count = 4;
 615                 if (ds->ops->get_sset_count)
 616                         count += ds->ops->get_sset_count(ds);
 617
 618                 return count;
 619         }
 620
 621         return -EOPNOTSUPP;
 622 }
 623
 624 static void dsa_slave_get_wol(struct net_device *dev, struct ethtool_wolinfo *w)
 625 {
 626         struct dsa_slave_priv *p = netdev_priv(dev);
 627         struct dsa_switch *ds = p->dp->ds;
 628
 629         if (ds->ops->get_wol)
 630                 ds->ops->get_wol(ds, p->dp->index, w);
 631 }
 632
 633 static int dsa_slave_set_wol(struct net_device *dev, struct ethtool_wolinfo *w)
 634 {
 635         struct dsa_slave_priv *p = netdev_priv(dev);
 636         struct dsa_switch *ds = p->dp->ds;
 637         int ret = -EOPNOTSUPP;
 638
 639         if (ds->ops->set_wol)
 640                 ret = ds->ops->set_wol(ds, p->dp->index, w);
 641
 642         return ret;
 643 }
 644
 645 static int dsa_slave_set_eee(struct net_device *dev, struct ethtool_eee *e)
 646 {
 647         struct dsa_slave_priv *p = netdev_priv(dev);
 648         struct dsa_switch *ds = p->dp->ds;
 649         int ret;
 650
 651         /* Port's PHY and MAC both need to be EEE capable */
 652         if (!p->phy)
 653                 return -ENODEV;
 654
 655         if (!ds->ops->set_eee)
 656                 return -EOPNOTSUPP;
 657
 658         ret = ds->ops->set_eee(ds, p->dp->index, p->phy, e);
 659         if (ret)
 660                 return ret;
 661
 662         if (e->eee_enabled) {
 663                 ret = phy_init_eee(p->phy, 0);
 664                 if (ret)
 665                         return ret;
 666         }
 667
 668         return phy_ethtool_set_eee(p->phy, e);
 669 }
 670
 671 static int dsa_slave_get_eee(struct net_device *dev, struct ethtool_eee *e)
 672 {
 673         struct dsa_slave_priv *p = netdev_priv(dev);
 674         struct dsa_switch *ds = p->dp->ds;
 675         int ret;
 676
 677         /* Port's PHY and MAC both need to be EEE capable */
 678         if (!p->phy)
 679                 return -ENODEV;
 680
 681         if (!ds->ops->get_eee)
 682                 return -EOPNOTSUPP;
 683
 684         ret = ds->ops->get_eee(ds, p->dp->index, e);
 685         if (ret)
 686                 return ret;
 687
 688         return phy_ethtool_get_eee(p->phy, e);
 689 }
 690
 691 #ifdef CONFIG_NET_POLL_CONTROLLER
 692 static int dsa_slave_netpoll_setup(struct net_device *dev,
 693                                    struct netpoll_info *ni)
 694 {
 695         struct dsa_slave_priv *p = netdev_priv(dev);
 696         struct net_device *master = dsa_master_netdev(p);
 697         struct netpoll *netpoll;
 698         int err = 0;
 699
 700         netpoll = kzalloc(sizeof(*netpoll), GFP_KERNEL);
 701         if (!netpoll)
 702                 return -ENOMEM;
 703
 704         err = __netpoll_setup(netpoll, master);
 705         if (err) {
 706                 kfree(netpoll);
 707                 goto out;
 708         }
 709
 710         p->netpoll = netpoll;
 711 out:
 712         return err;
 713 }
 714
 715 static void dsa_slave_netpoll_cleanup(struct net_device *dev)
 716 {
 717         struct dsa_slave_priv *p = netdev_priv(dev);
 718         struct netpoll *netpoll = p->netpoll;
 719
 720         if (!netpoll)
 721                 return;
 722
 723         p->netpoll = NULL;
 724
 725         __netpoll_free_async(netpoll);
 726 }
 727
 728 static void dsa_slave_poll_controller(struct net_device *dev)
 729 {
 730 }
 731 #endif
 732
 733 static int dsa_slave_get_phys_port_name(struct net_device *dev,
 734                                         char *name, size_t len)
 735 {
 736         struct dsa_slave_priv *p = netdev_priv(dev);
 737
 738         if (snprintf(name, len, "p%d", p->dp->index) >= len)
 739                 return -EINVAL;
 740
 741         return 0;
 742 }
 743
 744 static struct dsa_mall_tc_entry *
 745 dsa_slave_mall_tc_entry_find(struct dsa_slave_priv *p,
 746                              unsigned long cookie)
 747 {
 748         struct dsa_mall_tc_entry *mall_tc_entry;
 749
 750         list_for_each_entry(mall_tc_entry, &p->mall_tc_list, list)
 751                 if (mall_tc_entry->cookie == cookie)
 752                         return mall_tc_entry;
 753
 754         return NULL;
 755 }
 756
 757 static int dsa_slave_add_cls_matchall(struct net_device *dev,
 758                                       __be16 protocol,
 759                                       struct tc_cls_matchall_offload *cls,
 760                                       bool ingress)
 761 {
 762         struct dsa_slave_priv *p = netdev_priv(dev);
 763         struct dsa_mall_tc_entry *mall_tc_entry;
 764         struct dsa_switch *ds = p->dp->ds;
 765         struct net *net = dev_net(dev);
 766         struct dsa_slave_priv *to_p;
 767         struct net_device *to_dev;
 768         const struct tc_action *a;
 769         int err = -EOPNOTSUPP;
 770         LIST_HEAD(actions);
 771         int ifindex;
 772
 773         if (!ds->ops->port_mirror_add)
 774                 return err;
 775
 776         if (!tc_single_action(cls->exts))
 777                 return err;
 778
 779         tcf_exts_to_list(cls->exts, &actions);
 780         a = list_first_entry(&actions, struct tc_action, list);
 781
 782         if (is_tcf_mirred_egress_mirror(a) && protocol == htons(ETH_P_ALL)) {
 783                 struct dsa_mall_mirror_tc_entry *mirror;
 784
 785                 ifindex = tcf_mirred_ifindex(a);
 786                 to_dev = __dev_get_by_index(net, ifindex);
 787                 if (!to_dev)
 788                         return -EINVAL;
 789
 790                 if (!dsa_slave_dev_check(to_dev))
 791                         return -EOPNOTSUPP;
 792
 793                 mall_tc_entry = kzalloc(sizeof(*mall_tc_entry), GFP_KERNEL);
 794                 if (!mall_tc_entry)
 795                         return -ENOMEM;
 796
 797                 mall_tc_entry->cookie = cls->cookie;
 798                 mall_tc_entry->type = DSA_PORT_MALL_MIRROR;
 799                 mirror = &mall_tc_entry->mirror;
 800
 801                 to_p = netdev_priv(to_dev);
 802
 803                 mirror->to_local_port = to_p->dp->index;
 804                 mirror->ingress = ingress;
 805
 806                 err = ds->ops->port_mirror_add(ds, p->dp->index, mirror,
 807                                                ingress);
 808                 if (err) {
 809                         kfree(mall_tc_entry);
 810                         return err;
 811                 }
 812
 813                 list_add_tail(&mall_tc_entry->list, &p->mall_tc_list);
 814         }
 815
 816         return 0;
 817 }
 818
 819 static void dsa_slave_del_cls_matchall(struct net_device *dev,
 820                                        struct tc_cls_matchall_offload *cls)
 821 {
 822         struct dsa_slave_priv *p = netdev_priv(dev);
 823         struct dsa_mall_tc_entry *mall_tc_entry;
 824         struct dsa_switch *ds = p->dp->ds;
 825
 826         if (!ds->ops->port_mirror_del)
 827                 return;
 828
 829         mall_tc_entry = dsa_slave_mall_tc_entry_find(p, cls->cookie);
 830         if (!mall_tc_entry)
 831                 return;
 832
 833         list_del(&mall_tc_entry->list);
 834
 835         switch (mall_tc_entry->type) {
 836         case DSA_PORT_MALL_MIRROR:
 837                 ds->ops->port_mirror_del(ds, p->dp->index,
 838                                          &mall_tc_entry->mirror);
 839                 break;
 840         default:
 841                 WARN_ON(1);
 842         }
 843
 844         kfree(mall_tc_entry);
 845 }
 846
 847 static int dsa_slave_setup_tc(struct net_device *dev, u32 handle,
 848                               u32 chain_index, __be16 protocol,
 849                               struct tc_to_netdev *tc)
 850 {
 851         bool ingress = TC_H_MAJ(handle) == TC_H_MAJ(TC_H_INGRESS);
 852
 853         if (chain_index)
 854                 return -EOPNOTSUPP;
 855
 856         switch (tc->type) {
 857         case TC_SETUP_MATCHALL:
 858                 switch (tc->cls_mall->command) {
 859                 case TC_CLSMATCHALL_REPLACE:
 860                         return dsa_slave_add_cls_matchall(dev, protocol,
 861                                                           tc->cls_mall,
 862                                                           ingress);
 863                 case TC_CLSMATCHALL_DESTROY:
 864                         dsa_slave_del_cls_matchall(dev, tc->cls_mall);
 865                         return 0;
 866                 }
 867         default:
 868                 return -EOPNOTSUPP;
 869         }
 870 }
 871
 872 void dsa_cpu_port_ethtool_init(struct ethtool_ops *ops)
 873 {
 874         ops->get_sset_count = dsa_cpu_port_get_sset_count;
 875         ops->get_ethtool_stats = dsa_cpu_port_get_ethtool_stats;
 876         ops->get_strings = dsa_cpu_port_get_strings;
 877 }
 878
 879 static int dsa_slave_get_rxnfc(struct net_device *dev,
 880                                struct ethtool_rxnfc *nfc, u32 *rule_locs)
 881 {
 882         struct dsa_slave_priv *p = netdev_priv(dev);
 883         struct dsa_switch *ds = p->dp->ds;
 884
 885         if (!ds->ops->get_rxnfc)
 886                 return -EOPNOTSUPP;
 887
 888         return ds->ops->get_rxnfc(ds, p->dp->index, nfc, rule_locs);
 889 }
 890
 891 static int dsa_slave_set_rxnfc(struct net_device *dev,
 892                                struct ethtool_rxnfc *nfc)
 893 {
 894         struct dsa_slave_priv *p = netdev_priv(dev);
 895         struct dsa_switch *ds = p->dp->ds;
 896
 897         if (!ds->ops->set_rxnfc)
 898                 return -EOPNOTSUPP;
 899
 900         return ds->ops->set_rxnfc(ds, p->dp->index, nfc);
 901 }
 902
 903 static const struct ethtool_ops dsa_slave_ethtool_ops = {
 904         .get_drvinfo            = dsa_slave_get_drvinfo,
 905         .get_regs_len           = dsa_slave_get_regs_len,
 906         .get_regs               = dsa_slave_get_regs,
 907         .nway_reset             = dsa_slave_nway_reset,
 908         .get_link               = dsa_slave_get_link,
 909         .get_eeprom_len         = dsa_slave_get_eeprom_len,
 910         .get_eeprom             = dsa_slave_get_eeprom,
 911         .set_eeprom             = dsa_slave_set_eeprom,
 912         .get_strings            = dsa_slave_get_strings,
 913         .get_ethtool_stats      = dsa_slave_get_ethtool_stats,
 914         .get_sset_count         = dsa_slave_get_sset_count,
 915         .set_wol                = dsa_slave_set_wol,
 916         .get_wol                = dsa_slave_get_wol,
 917         .set_eee                = dsa_slave_set_eee,
 918         .get_eee                = dsa_slave_get_eee,
 919         .get_link_ksettings     = dsa_slave_get_link_ksettings,
 920         .set_link_ksettings     = dsa_slave_set_link_ksettings,
 921         .get_rxnfc              = dsa_slave_get_rxnfc,
 922         .set_rxnfc              = dsa_slave_set_rxnfc,
 923 };
 924
 925 static const struct net_device_ops dsa_slave_netdev_ops = {
 926         .ndo_open               = dsa_slave_open,
 927         .ndo_stop               = dsa_slave_close,
 928         .ndo_start_xmit         = dsa_slave_xmit,
 929         .ndo_change_rx_flags    = dsa_slave_change_rx_flags,
 930         .ndo_set_rx_mode        = dsa_slave_set_rx_mode,
 931         .ndo_set_mac_address    = dsa_slave_set_mac_address,
 932         .ndo_fdb_add            = switchdev_port_fdb_add,
 933         .ndo_fdb_del            = switchdev_port_fdb_del,
 934         .ndo_fdb_dump           = switchdev_port_fdb_dump,
 935         .ndo_do_ioctl           = dsa_slave_ioctl,
 936         .ndo_get_iflink         = dsa_slave_get_iflink,
 937 #ifdef CONFIG_NET_POLL_CONTROLLER
 938         .ndo_netpoll_setup      = dsa_slave_netpoll_setup,
 939         .ndo_netpoll_cleanup    = dsa_slave_netpoll_cleanup,
 940         .ndo_poll_controller    = dsa_slave_poll_controller,
 941 #endif
 942         .ndo_bridge_getlink     = switchdev_port_bridge_getlink,
 943         .ndo_bridge_setlink     = switchdev_port_bridge_setlink,
 944         .ndo_bridge_dellink     = switchdev_port_bridge_dellink,
 945         .ndo_get_phys_port_name = dsa_slave_get_phys_port_name,
 946         .ndo_setup_tc           = dsa_slave_setup_tc,
 947 };
 948
 949 static const struct switchdev_ops dsa_slave_switchdev_ops = {
 950         .switchdev_port_attr_get        = dsa_slave_port_attr_get,
 951         .switchdev_port_attr_set        = dsa_slave_port_attr_set,
 952         .switchdev_port_obj_add         = dsa_slave_port_obj_add,
 953         .switchdev_port_obj_del         = dsa_slave_port_obj_del,
 954         .switchdev_port_obj_dump        = dsa_slave_port_obj_dump,
 955 };
 956
 957 static struct device_type dsa_type = {
 958         .name   = "dsa",
 959 };
 960
 961 static void dsa_slave_adjust_link(struct net_device *dev)
 962 {
 963         struct dsa_slave_priv *p = netdev_priv(dev);
 964         struct dsa_switch *ds = p->dp->ds;
 965         unsigned int status_changed = 0;
 966
 967         if (p->old_link != p->phy->link) {
 968                 status_changed = 1;
 969                 p->old_link = p->phy->link;
 970         }
 971
 972         if (p->old_duplex != p->phy->duplex) {
 973                 status_changed = 1;
 974                 p->old_duplex = p->phy->duplex;
 975         }
 976
 977         if (p->old_pause != p->phy->pause) {
 978                 status_changed = 1;
 979                 p->old_pause = p->phy->pause;
 980         }
 981
 982         if (ds->ops->adjust_link && status_changed)
 983                 ds->ops->adjust_link(ds, p->dp->index, p->phy);
 984
 985         if (status_changed)
 986                 phy_print_status(p->phy);
 987 }
 988
 989 static int dsa_slave_fixed_link_update(struct net_device *dev,
 990                                        struct fixed_phy_status *status)
 991 {
 992         struct dsa_slave_priv *p;
 993         struct dsa_switch *ds;
 994
 995         if (dev) {
 996                 p = netdev_priv(dev);
 997                 ds = p->dp->ds;
 998                 if (ds->ops->fixed_link_update)
 999                         ds->ops->fixed_link_update(ds, p->dp->index, status);
1000         }
1001
1002         return 0;
1003 }
1004
1005 /* slave device setup *******************************************************/
1006 static int dsa_slave_phy_connect(struct dsa_slave_priv *p,
1007                                  struct net_device *slave_dev,
1008                                  int addr)
1009 {
1010         struct dsa_switch *ds = p->dp->ds;
1011
1012         p->phy = mdiobus_get_phy(ds->slave_mii_bus, addr);
1013         if (!p->phy) {
1014                 netdev_err(slave_dev, "no phy at %d\n", addr);
1015                 return -ENODEV;
1016         }
1017
1018         /* Use already configured phy mode */
1019         if (p->phy_interface == PHY_INTERFACE_MODE_NA)
1020                 p->phy_interface = p->phy->interface;
1021         return phy_connect_direct(slave_dev, p->phy, dsa_slave_adjust_link,
1022                                   p->phy_interface);
1023 }
1024
1025 static int dsa_slave_phy_setup(struct dsa_slave_priv *p,
1026                                 struct net_device *slave_dev)
1027 {
1028         struct dsa_switch *ds = p->dp->ds;
1029         struct device_node *phy_dn, *port_dn;
1030         bool phy_is_fixed = false;
1031         u32 phy_flags = 0;
1032         int mode, ret;
1033
1034         port_dn = p->dp->dn;
1035         mode = of_get_phy_mode(port_dn);
1036         if (mode < 0)
1037                 mode = PHY_INTERFACE_MODE_NA;
1038         p->phy_interface = mode;
1039
1040         phy_dn = of_parse_phandle(port_dn, "phy-handle", 0);
1041         if (!phy_dn && of_phy_is_fixed_link(port_dn)) {
1042                 /* In the case of a fixed PHY, the DT node associated
1043                  * to the fixed PHY is the Port DT node
1044                  */
1045                 ret = of_phy_register_fixed_link(port_dn);
1046                 if (ret) {
1047                         netdev_err(slave_dev, "failed to register fixed PHY: %d\n", ret);
1048                         return ret;
1049                 }
1050                 phy_is_fixed = true;
1051                 phy_dn = of_node_get(port_dn);
1052         }
1053
1054         if (ds->ops->get_phy_flags)
1055                 phy_flags = ds->ops->get_phy_flags(ds, p->dp->index);
1056
1057         if (phy_dn) {
1058                 int phy_id = of_mdio_parse_addr(&slave_dev->dev, phy_dn);
1059
1060                 /* If this PHY address is part of phys_mii_mask, which means
1061                  * that we need to divert reads and writes to/from it, then we
1062                  * want to bind this device using the slave MII bus created by
1063                  * DSA to make that happen.
1064                  */
1065                 if (!phy_is_fixed && phy_id >= 0 &&
1066                     (ds->phys_mii_mask & (1 << phy_id))) {
1067                         ret = dsa_slave_phy_connect(p, slave_dev, phy_id);
1068                         if (ret) {
1069                                 netdev_err(slave_dev, "failed to connect to phy%d: %d\n", phy_id, ret);
1070                                 of_node_put(phy_dn);
1071                                 return ret;
1072                         }
1073                 } else {
1074                         p->phy = of_phy_connect(slave_dev, phy_dn,
1075                                                 dsa_slave_adjust_link,
1076                                                 phy_flags,
1077                                                 p->phy_interface);
1078                 }
1079
1080                 of_node_put(phy_dn);
1081         }
1082
1083         if (p->phy && phy_is_fixed)
1084                 fixed_phy_set_link_update(p->phy, dsa_slave_fixed_link_update);
1085
1086         /* We could not connect to a designated PHY, so use the switch internal
1087          * MDIO bus instead
1088          */
1089         if (!p->phy) {
1090                 ret = dsa_slave_phy_connect(p, slave_dev, p->dp->index);
1091                 if (ret) {
1092                         netdev_err(slave_dev, "failed to connect to port %d: %d\n",
1093                                    p->dp->index, ret);
1094                         if (phy_is_fixed)
1095                                 of_phy_deregister_fixed_link(port_dn);
1096                         return ret;
1097                 }
1098         }
1099
1100         phy_attached_info(p->phy);
1101
1102         return 0;
1103 }
1104
1105 static struct lock_class_key dsa_slave_netdev_xmit_lock_key;
1106 static void dsa_slave_set_lockdep_class_one(struct net_device *dev,
1107                                             struct netdev_queue *txq,
1108                                             void *_unused)
1109 {
1110         lockdep_set_class(&txq->_xmit_lock,
1111                           &dsa_slave_netdev_xmit_lock_key);
1112 }
1113
1114 int dsa_slave_suspend(struct net_device *slave_dev)
1115 {
1116         struct dsa_slave_priv *p = netdev_priv(slave_dev);
1117
1118         netif_device_detach(slave_dev);
1119
1120         if (p->phy) {
1121                 phy_stop(p->phy);
1122                 p->old_pause = -1;
1123                 p->old_link = -1;
1124                 p->old_duplex = -1;
1125                 phy_suspend(p->phy);
1126         }
1127
1128         return 0;
1129 }
1130
1131 int dsa_slave_resume(struct net_device *slave_dev)
1132 {
1133         struct dsa_slave_priv *p = netdev_priv(slave_dev);
1134
1135         netif_device_attach(slave_dev);
1136
1137         if (p->phy) {
1138                 phy_resume(p->phy);
1139                 phy_start(p->phy);
1140         }
1141
1142         return 0;
1143 }
1144
1145 int dsa_slave_create(struct dsa_switch *ds, struct device *parent,
1146                      int port, const char *name)
1147 {
1148         struct dsa_switch_tree *dst = ds->dst;
1149         struct net_device *master;
1150         struct net_device *slave_dev;
1151         struct dsa_slave_priv *p;
1152         struct dsa_port *cpu_dp;
1153         int ret;
1154
1155         cpu_dp = ds->dst->cpu_dp;
1156         master = cpu_dp->netdev;
1157
1158         slave_dev = alloc_netdev(sizeof(struct dsa_slave_priv), name,
1159                                  NET_NAME_UNKNOWN, ether_setup);
1160         if (slave_dev == NULL)
1161                 return -ENOMEM;
1162
1163         slave_dev->features = master->vlan_features | NETIF_F_HW_TC;
1164         slave_dev->hw_features |= NETIF_F_HW_TC;
1165         slave_dev->ethtool_ops = &dsa_slave_ethtool_ops;
1166         eth_hw_addr_inherit(slave_dev, master);
1167         slave_dev->priv_flags |= IFF_NO_QUEUE;
1168         slave_dev->netdev_ops = &dsa_slave_netdev_ops;
1169         slave_dev->switchdev_ops = &dsa_slave_switchdev_ops;
1170         slave_dev->min_mtu = 0;
1171         slave_dev->max_mtu = ETH_MAX_MTU;
1172         SET_NETDEV_DEVTYPE(slave_dev, &dsa_type);
1173
1174         netdev_for_each_tx_queue(slave_dev, dsa_slave_set_lockdep_class_one,
1175                                  NULL);
1176
1177         SET_NETDEV_DEV(slave_dev, parent);
1178         slave_dev->dev.of_node = ds->ports[port].dn;
1179         slave_dev->vlan_features = master->vlan_features;
1180
1181         p = netdev_priv(slave_dev);
1182         p->dp = &ds->ports[port];
1183         INIT_LIST_HEAD(&p->mall_tc_list);
1184         p->xmit = dst->tag_ops->xmit;
1185
1186         p->old_pause = -1;
1187         p->old_link = -1;
1188         p->old_duplex = -1;
1189
1190         ds->ports[port].netdev = slave_dev;
1191         ret = register_netdev(slave_dev);
1192         if (ret) {
1193                 netdev_err(master, "error %d registering interface %s\n",
1194                            ret, slave_dev->name);
1195                 ds->ports[port].netdev = NULL;
1196                 free_netdev(slave_dev);
1197                 return ret;
1198         }
1199
1200         netif_carrier_off(slave_dev);
1201
1202         ret = dsa_slave_phy_setup(p, slave_dev);
1203         if (ret) {
1204                 netdev_err(master, "error %d setting up slave phy\n", ret);
1205                 unregister_netdev(slave_dev);
1206                 free_netdev(slave_dev);
1207                 return ret;
1208         }
1209
1210         return 0;
1211 }
1212
1213 void dsa_slave_destroy(struct net_device *slave_dev)
1214 {
1215         struct dsa_slave_priv *p = netdev_priv(slave_dev);
1216         struct device_node *port_dn;
1217
1218         port_dn = p->dp->dn;
1219
1220         netif_carrier_off(slave_dev);
1221         if (p->phy) {
1222                 phy_disconnect(p->phy);
1223
1224                 if (of_phy_is_fixed_link(port_dn))
1225                         of_phy_deregister_fixed_link(port_dn);
1226         }
1227         unregister_netdev(slave_dev);
1228         free_netdev(slave_dev);
1229 }
1230
1231 static bool dsa_slave_dev_check(struct net_device *dev)
1232 {
1233         return dev->netdev_ops == &dsa_slave_netdev_ops;
1234 }
1235
1236 static int dsa_slave_changeupper(struct net_device *dev,
1237                                  struct netdev_notifier_changeupper_info *info)
1238 {
1239         struct dsa_slave_priv *p = netdev_priv(dev);
1240         struct dsa_port *dp = p->dp;
1241         int err = NOTIFY_DONE;
1242
1243         if (netif_is_bridge_master(info->upper_dev)) {
1244                 if (info->linking) {
1245                         err = dsa_port_bridge_join(dp, info->upper_dev);
1246                         err = notifier_from_errno(err);
1247                 } else {
1248                         dsa_port_bridge_leave(dp, info->upper_dev);
1249                         err = NOTIFY_OK;
1250                 }
1251         }
1252
1253         return err;
1254 }
1255
1256 static int dsa_slave_netdevice_event(struct notifier_block *nb,
1257                                      unsigned long event, void *ptr)
1258 {
1259         struct net_device *dev = netdev_notifier_info_to_dev(ptr);
1260
1261         if (dev->netdev_ops != &dsa_slave_netdev_ops)
1262                 return NOTIFY_DONE;
1263
1264         if (event == NETDEV_CHANGEUPPER)
1265                 return dsa_slave_changeupper(dev, ptr);
1266
1267         return NOTIFY_DONE;
1268 }
1269
1270 static struct notifier_block dsa_slave_nb __read_mostly = {
1271         .notifier_call  = dsa_slave_netdevice_event,
1272 };
1273
1274 int dsa_slave_register_notifier(void)
1275 {
1276         return register_netdevice_notifier(&dsa_slave_nb);
1277 }
1278
1279 void dsa_slave_unregister_notifier(void)
1280 {
1281         int err;
1282
1283         err = unregister_netdevice_notifier(&dsa_slave_nb);
1284         if (err)
1285                 pr_err("DSA: failed to unregister slave notifier (%d)\n", err);
1286 }