2 * Copyright (C) 2015 Josh Poimboeuf <jpoimboe@redhat.com>
4 * This program is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU General Public License
6 * as published by the Free Software Foundation; either version 2
7 * of the License, or (at your option) any later version.
9 * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
14 * You should have received a copy of the GNU General Public License
15 * along with this program; if not, see <http://www.gnu.org/licenses/>.
21 * This command analyzes every .o file and ensures the validity of its stack
22 * trace metadata. It enforces a set of rules on asm code and C inline
23 * assembly code so that stack traces can be reliable.
25 * For more information, see tools/objtool/Documentation/stack-validation.txt.
29 #include <subcmd/parse-options.h>
37 #include <linux/hashtable.h>
39 #define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
41 #define STATE_FP_SAVED 0x1
42 #define STATE_FP_SETUP 0x2
43 #define STATE_FENTRY 0x4
46 struct list_head list;
47 struct hlist_node hash;
50 unsigned int len, state;
52 unsigned long immediate;
53 bool alt_group, visited;
54 struct symbol *call_dest;
55 struct instruction *jump_dest;
56 struct list_head alts;
61 struct list_head list;
62 struct instruction *insn;
67 struct list_head insn_list;
68 DECLARE_HASHTABLE(insn_hash, 16);
69 struct section *rodata, *whitelist;
70 bool ignore_unreachables, c_file;
76 static struct instruction *find_insn(struct objtool_file *file,
77 struct section *sec, unsigned long offset)
79 struct instruction *insn;
81 hash_for_each_possible(file->insn_hash, insn, hash, offset)
82 if (insn->sec == sec && insn->offset == offset)
88 static struct instruction *next_insn_same_sec(struct objtool_file *file,
89 struct instruction *insn)
91 struct instruction *next = list_next_entry(insn, list);
93 if (&next->list == &file->insn_list || next->sec != insn->sec)
99 #define for_each_insn(file, insn) \
100 list_for_each_entry(insn, &file->insn_list, list)
102 #define func_for_each_insn(file, func, insn) \
103 for (insn = find_insn(file, func->sec, func->offset); \
104 insn && &insn->list != &file->insn_list && \
105 insn->sec == func->sec && \
106 insn->offset < func->offset + func->len; \
107 insn = list_next_entry(insn, list))
109 #define sec_for_each_insn_from(file, insn) \
110 for (; insn; insn = next_insn_same_sec(file, insn))
114 * Check if the function has been manually whitelisted with the
115 * STACK_FRAME_NON_STANDARD macro, or if it should be automatically whitelisted
116 * due to its use of a context switching instruction.
118 static bool ignore_func(struct objtool_file *file, struct symbol *func)
121 struct instruction *insn;
123 /* check for STACK_FRAME_NON_STANDARD */
124 if (file->whitelist && file->whitelist->rela)
125 list_for_each_entry(rela, &file->whitelist->rela->rela_list, list)
126 if (rela->sym->sec == func->sec &&
127 rela->addend == func->offset)
130 /* check if it has a context switching instruction */
131 func_for_each_insn(file, func, insn)
132 if (insn->type == INSN_CONTEXT_SWITCH)
139 * This checks to see if the given function is a "noreturn" function.
141 * For global functions which are outside the scope of this object file, we
142 * have to keep a manual list of them.
144 * For local functions, we have to detect them manually by simply looking for
145 * the lack of a return instruction.
152 static int __dead_end_function(struct objtool_file *file, struct symbol *func,
156 struct instruction *insn;
160 * Unfortunately these have to be hard coded because the noreturn
161 * attribute isn't provided in ELF data.
163 static const char * const global_noreturns[] = {
167 "__module_put_and_exit",
169 "kvm_spurious_fault",
174 if (func->bind == STB_WEAK)
177 if (func->bind == STB_GLOBAL)
178 for (i = 0; i < ARRAY_SIZE(global_noreturns); i++)
179 if (!strcmp(func->name, global_noreturns[i]))
185 func_for_each_insn(file, func, insn) {
188 if (insn->type == INSN_RETURN)
196 * A function can have a sibling call instead of a return. In that
197 * case, the function's dead-end status depends on whether the target
198 * of the sibling call returns.
200 func_for_each_insn(file, func, insn) {
201 if (insn->sec != func->sec ||
202 insn->offset >= func->offset + func->len)
205 if (insn->type == INSN_JUMP_UNCONDITIONAL) {
206 struct instruction *dest = insn->jump_dest;
207 struct symbol *dest_func;
210 /* sibling call to another file */
213 if (dest->sec != func->sec ||
214 dest->offset < func->offset ||
215 dest->offset >= func->offset + func->len) {
216 /* local sibling call */
217 dest_func = find_symbol_by_offset(dest->sec,
222 if (recursion == 5) {
223 WARN_FUNC("infinite recursion (objtool bug!)",
224 dest->sec, dest->offset);
228 return __dead_end_function(file, dest_func,
233 if (insn->type == INSN_JUMP_DYNAMIC && list_empty(&insn->alts))
241 static int dead_end_function(struct objtool_file *file, struct symbol *func)
243 return __dead_end_function(file, func, 0);
247 * Call the arch-specific instruction decoder for all the instructions and add
248 * them to the global instruction list.
250 static int decode_instructions(struct objtool_file *file)
254 unsigned long offset;
255 struct instruction *insn;
258 list_for_each_entry(sec, &file->elf->sections, list) {
260 if (!(sec->sh.sh_flags & SHF_EXECINSTR))
263 for (offset = 0; offset < sec->len; offset += insn->len) {
264 insn = malloc(sizeof(*insn));
265 memset(insn, 0, sizeof(*insn));
267 INIT_LIST_HEAD(&insn->alts);
269 insn->offset = offset;
271 ret = arch_decode_instruction(file->elf, sec, offset,
273 &insn->len, &insn->type,
278 if (!insn->type || insn->type > INSN_LAST) {
279 WARN_FUNC("invalid instruction type %d",
280 insn->sec, insn->offset, insn->type);
284 hash_add(file->insn_hash, &insn->hash, insn->offset);
285 list_add_tail(&insn->list, &file->insn_list);
288 list_for_each_entry(func, &sec->symbol_list, list) {
289 if (func->type != STT_FUNC)
292 if (!find_insn(file, sec, func->offset)) {
293 WARN("%s(): can't find starting instruction",
298 func_for_each_insn(file, func, insn)
308 * Warnings shouldn't be reported for ignored functions.
310 static void add_ignores(struct objtool_file *file)
312 struct instruction *insn;
316 list_for_each_entry(sec, &file->elf->sections, list) {
317 list_for_each_entry(func, &sec->symbol_list, list) {
318 if (func->type != STT_FUNC)
321 if (!ignore_func(file, func))
324 func_for_each_insn(file, func, insn)
325 insn->visited = true;
331 * Find the destination instructions for all jumps.
333 static int add_jump_destinations(struct objtool_file *file)
335 struct instruction *insn;
337 struct section *dest_sec;
338 unsigned long dest_off;
340 for_each_insn(file, insn) {
341 if (insn->type != INSN_JUMP_CONDITIONAL &&
342 insn->type != INSN_JUMP_UNCONDITIONAL)
349 rela = find_rela_by_dest_range(insn->sec, insn->offset,
352 dest_sec = insn->sec;
353 dest_off = insn->offset + insn->len + insn->immediate;
354 } else if (rela->sym->type == STT_SECTION) {
355 dest_sec = rela->sym->sec;
356 dest_off = rela->addend + 4;
357 } else if (rela->sym->sec->idx) {
358 dest_sec = rela->sym->sec;
359 dest_off = rela->sym->sym.st_value + rela->addend + 4;
366 insn->jump_dest = find_insn(file, dest_sec, dest_off);
367 if (!insn->jump_dest) {
370 * This is a special case where an alt instruction
371 * jumps past the end of the section. These are
372 * handled later in handle_group_alt().
374 if (!strcmp(insn->sec->name, ".altinstr_replacement"))
377 WARN_FUNC("can't find jump dest instruction at %s+0x%lx",
378 insn->sec, insn->offset, dest_sec->name,
388 * Find the destination instructions for all calls.
390 static int add_call_destinations(struct objtool_file *file)
392 struct instruction *insn;
393 unsigned long dest_off;
396 for_each_insn(file, insn) {
397 if (insn->type != INSN_CALL)
400 rela = find_rela_by_dest_range(insn->sec, insn->offset,
403 dest_off = insn->offset + insn->len + insn->immediate;
404 insn->call_dest = find_symbol_by_offset(insn->sec,
406 if (!insn->call_dest) {
407 WARN_FUNC("can't find call dest symbol at offset 0x%lx",
408 insn->sec, insn->offset, dest_off);
411 } else if (rela->sym->type == STT_SECTION) {
412 insn->call_dest = find_symbol_by_offset(rela->sym->sec,
414 if (!insn->call_dest ||
415 insn->call_dest->type != STT_FUNC) {
416 WARN_FUNC("can't find call dest symbol at %s+0x%x",
417 insn->sec, insn->offset,
418 rela->sym->sec->name,
423 insn->call_dest = rela->sym;
430 * The .alternatives section requires some extra special care, over and above
431 * what other special sections require:
433 * 1. Because alternatives are patched in-place, we need to insert a fake jump
434 * instruction at the end so that validate_branch() skips all the original
435 * replaced instructions when validating the new instruction path.
437 * 2. An added wrinkle is that the new instruction length might be zero. In
438 * that case the old instructions are replaced with noops. We simulate that
439 * by creating a fake jump as the only new instruction.
441 * 3. In some cases, the alternative section includes an instruction which
442 * conditionally jumps to the _end_ of the entry. We have to modify these
443 * jumps' destinations to point back to .text rather than the end of the
444 * entry in .altinstr_replacement.
446 * 4. It has been requested that we don't validate the !POPCNT feature path
447 * which is a "very very small percentage of machines".
449 static int handle_group_alt(struct objtool_file *file,
450 struct special_alt *special_alt,
451 struct instruction *orig_insn,
452 struct instruction **new_insn)
454 struct instruction *last_orig_insn, *last_new_insn, *insn, *fake_jump;
455 unsigned long dest_off;
457 last_orig_insn = NULL;
459 sec_for_each_insn_from(file, insn) {
460 if (insn->offset >= special_alt->orig_off + special_alt->orig_len)
463 if (special_alt->skip_orig)
464 insn->type = INSN_NOP;
466 insn->alt_group = true;
467 last_orig_insn = insn;
470 if (!next_insn_same_sec(file, last_orig_insn)) {
471 WARN("%s: don't know how to handle alternatives at end of section",
472 special_alt->orig_sec->name);
476 fake_jump = malloc(sizeof(*fake_jump));
478 WARN("malloc failed");
481 memset(fake_jump, 0, sizeof(*fake_jump));
482 INIT_LIST_HEAD(&fake_jump->alts);
483 fake_jump->sec = special_alt->new_sec;
484 fake_jump->offset = -1;
485 fake_jump->type = INSN_JUMP_UNCONDITIONAL;
486 fake_jump->jump_dest = list_next_entry(last_orig_insn, list);
488 if (!special_alt->new_len) {
489 *new_insn = fake_jump;
493 last_new_insn = NULL;
495 sec_for_each_insn_from(file, insn) {
496 if (insn->offset >= special_alt->new_off + special_alt->new_len)
499 last_new_insn = insn;
501 if (insn->type != INSN_JUMP_CONDITIONAL &&
502 insn->type != INSN_JUMP_UNCONDITIONAL)
505 if (!insn->immediate)
508 dest_off = insn->offset + insn->len + insn->immediate;
509 if (dest_off == special_alt->new_off + special_alt->new_len)
510 insn->jump_dest = fake_jump;
512 if (!insn->jump_dest) {
513 WARN_FUNC("can't find alternative jump destination",
514 insn->sec, insn->offset);
519 if (!last_new_insn) {
520 WARN_FUNC("can't find last new alternative instruction",
521 special_alt->new_sec, special_alt->new_off);
525 list_add(&fake_jump->list, &last_new_insn->list);
531 * A jump table entry can either convert a nop to a jump or a jump to a nop.
532 * If the original instruction is a jump, make the alt entry an effective nop
533 * by just skipping the original instruction.
535 static int handle_jump_alt(struct objtool_file *file,
536 struct special_alt *special_alt,
537 struct instruction *orig_insn,
538 struct instruction **new_insn)
540 if (orig_insn->type == INSN_NOP)
543 if (orig_insn->type != INSN_JUMP_UNCONDITIONAL) {
544 WARN_FUNC("unsupported instruction at jump label",
545 orig_insn->sec, orig_insn->offset);
549 *new_insn = list_next_entry(orig_insn, list);
554 * Read all the special sections which have alternate instructions which can be
555 * patched in or redirected to at runtime. Each instruction having alternate
556 * instruction(s) has them added to its insn->alts list, which will be
557 * traversed in validate_branch().
559 static int add_special_section_alts(struct objtool_file *file)
561 struct list_head special_alts;
562 struct instruction *orig_insn, *new_insn;
563 struct special_alt *special_alt, *tmp;
564 struct alternative *alt;
567 ret = special_get_alts(file->elf, &special_alts);
571 list_for_each_entry_safe(special_alt, tmp, &special_alts, list) {
572 alt = malloc(sizeof(*alt));
574 WARN("malloc failed");
579 orig_insn = find_insn(file, special_alt->orig_sec,
580 special_alt->orig_off);
582 WARN_FUNC("special: can't find orig instruction",
583 special_alt->orig_sec, special_alt->orig_off);
589 if (!special_alt->group || special_alt->new_len) {
590 new_insn = find_insn(file, special_alt->new_sec,
591 special_alt->new_off);
593 WARN_FUNC("special: can't find new instruction",
594 special_alt->new_sec,
595 special_alt->new_off);
601 if (special_alt->group) {
602 ret = handle_group_alt(file, special_alt, orig_insn,
606 } else if (special_alt->jump_or_nop) {
607 ret = handle_jump_alt(file, special_alt, orig_insn,
613 alt->insn = new_insn;
614 list_add_tail(&alt->list, &orig_insn->alts);
616 list_del(&special_alt->list);
624 static int add_switch_table(struct objtool_file *file, struct symbol *func,
625 struct instruction *insn, struct rela *table,
626 struct rela *next_table)
628 struct rela *rela = table;
629 struct instruction *alt_insn;
630 struct alternative *alt;
632 list_for_each_entry_from(rela, &file->rodata->rela->rela_list, list) {
633 if (rela == next_table)
636 if (rela->sym->sec != insn->sec ||
637 rela->addend <= func->offset ||
638 rela->addend >= func->offset + func->len)
641 alt_insn = find_insn(file, insn->sec, rela->addend);
643 WARN("%s: can't find instruction at %s+0x%x",
644 file->rodata->rela->name, insn->sec->name,
649 alt = malloc(sizeof(*alt));
651 WARN("malloc failed");
655 alt->insn = alt_insn;
656 list_add_tail(&alt->list, &insn->alts);
662 static int add_func_switch_tables(struct objtool_file *file,
665 struct instruction *insn, *prev_jump;
666 struct rela *text_rela, *rodata_rela, *prev_rela;
671 func_for_each_insn(file, func, insn) {
672 if (insn->type != INSN_JUMP_DYNAMIC)
675 text_rela = find_rela_by_dest_range(insn->sec, insn->offset,
677 if (!text_rela || text_rela->sym != file->rodata->sym)
680 /* common case: jmpq *[addr](,%rax,8) */
681 rodata_rela = find_rela_by_dest(file->rodata,
685 * rare case: jmpq *[addr](%rip)
687 * This check is for a rare gcc quirk, currently only seen in
688 * three driver functions in the kernel, only with certain
689 * obscure non-distro configs.
691 * As part of an optimization, gcc makes a copy of an existing
692 * switch jump table, modifies it, and then hard-codes the jump
693 * (albeit with an indirect jump) to use a single entry in the
694 * table. The rest of the jump table and some of its jump
695 * targets remain as dead code.
697 * In such a case we can just crudely ignore all unreachable
698 * instruction warnings for the entire object file. Ideally we
699 * would just ignore them for the function, but that would
700 * require redesigning the code quite a bit. And honestly
701 * that's just not worth doing: unreachable instruction
702 * warnings are of questionable value anyway, and this is such
706 * - https://lkml.kernel.org/r/201603231906.LWcVUpxm%25fengguang.wu@intel.com
707 * - https://lkml.kernel.org/r/201603271114.K9i45biy%25fengguang.wu@intel.com
708 * - https://lkml.kernel.org/r/201603291058.zuJ6ben1%25fengguang.wu@intel.com
711 * - https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70604
714 rodata_rela = find_rela_by_dest(file->rodata,
715 text_rela->addend + 4);
717 file->ignore_unreachables = true;
724 * We found a switch table, but we don't know yet how big it
725 * is. Don't add it until we reach the end of the function or
726 * the beginning of another switch table in the same function.
729 ret = add_switch_table(file, func, prev_jump, prev_rela,
736 prev_rela = rodata_rela;
740 ret = add_switch_table(file, func, prev_jump, prev_rela, NULL);
749 * For some switch statements, gcc generates a jump table in the .rodata
750 * section which contains a list of addresses within the function to jump to.
751 * This finds these jump tables and adds them to the insn->alts lists.
753 static int add_switch_table_alts(struct objtool_file *file)
759 if (!file->rodata || !file->rodata->rela)
762 list_for_each_entry(sec, &file->elf->sections, list) {
763 list_for_each_entry(func, &sec->symbol_list, list) {
764 if (func->type != STT_FUNC)
767 ret = add_func_switch_tables(file, func);
776 static int decode_sections(struct objtool_file *file)
780 ret = decode_instructions(file);
786 ret = add_jump_destinations(file);
790 ret = add_call_destinations(file);
794 ret = add_special_section_alts(file);
798 ret = add_switch_table_alts(file);
805 static bool is_fentry_call(struct instruction *insn)
807 if (insn->type == INSN_CALL &&
808 insn->call_dest->type == STT_NOTYPE &&
809 !strcmp(insn->call_dest->name, "__fentry__"))
815 static bool has_modified_stack_frame(struct instruction *insn)
817 return (insn->state & STATE_FP_SAVED) ||
818 (insn->state & STATE_FP_SETUP);
821 static bool has_valid_stack_frame(struct instruction *insn)
823 return (insn->state & STATE_FP_SAVED) &&
824 (insn->state & STATE_FP_SETUP);
827 static unsigned int frame_state(unsigned long state)
829 return (state & (STATE_FP_SAVED | STATE_FP_SETUP));
833 * Follow the branch starting at the given instruction, and recursively follow
834 * any other branches (jumps). Meanwhile, track the frame pointer state at
835 * each instruction and validate all the rules described in
836 * tools/objtool/Documentation/stack-validation.txt.
838 static int validate_branch(struct objtool_file *file,
839 struct instruction *first, unsigned char first_state)
841 struct alternative *alt;
842 struct instruction *insn;
844 struct symbol *func = NULL;
852 if (insn->alt_group && list_empty(&insn->alts)) {
853 WARN_FUNC("don't know how to handle branch to middle of alternative instruction group",
859 if (file->c_file && insn->func) {
860 if (func && func != insn->func) {
861 WARN("%s() falls through to next function %s()",
862 func->name, insn->func->name);
870 if (frame_state(insn->state) != frame_state(state)) {
871 WARN_FUNC("frame pointer state mismatch",
879 insn->visited = true;
882 list_for_each_entry(alt, &insn->alts, list) {
883 ret = validate_branch(file, alt->insn, state);
888 switch (insn->type) {
892 if (state & STATE_FP_SAVED) {
893 WARN_FUNC("duplicate frame pointer save",
897 state |= STATE_FP_SAVED;
903 if (state & STATE_FP_SETUP) {
904 WARN_FUNC("duplicate frame pointer setup",
908 state |= STATE_FP_SETUP;
912 case INSN_FP_RESTORE:
914 if (has_valid_stack_frame(insn))
915 state &= ~STATE_FP_SETUP;
917 state &= ~STATE_FP_SAVED;
922 if (!nofp && has_modified_stack_frame(insn)) {
923 WARN_FUNC("return without frame pointer restore",
930 if (is_fentry_call(insn)) {
931 state |= STATE_FENTRY;
935 ret = dead_end_function(file, insn->call_dest);
942 case INSN_CALL_DYNAMIC:
943 if (!nofp && !has_valid_stack_frame(insn)) {
944 WARN_FUNC("call without frame pointer save/setup",
950 case INSN_JUMP_CONDITIONAL:
951 case INSN_JUMP_UNCONDITIONAL:
952 if (insn->jump_dest) {
953 ret = validate_branch(file, insn->jump_dest,
957 } else if (has_modified_stack_frame(insn)) {
958 WARN_FUNC("sibling call from callable instruction with changed frame pointer",
961 } /* else it's a sibling call */
963 if (insn->type == INSN_JUMP_UNCONDITIONAL)
968 case INSN_JUMP_DYNAMIC:
969 if (list_empty(&insn->alts) &&
970 has_modified_stack_frame(insn)) {
971 WARN_FUNC("sibling call from callable instruction with changed frame pointer",
985 insn = next_insn_same_sec(file, insn);
987 WARN("%s: unexpected end of section", sec->name);
995 static bool is_gcov_insn(struct instruction *insn)
1000 unsigned long offset;
1002 rela = find_rela_by_dest_range(insn->sec, insn->offset, insn->len);
1006 if (rela->sym->type != STT_SECTION)
1009 sec = rela->sym->sec;
1010 offset = rela->addend + insn->offset + insn->len - rela->offset;
1012 list_for_each_entry(sym, &sec->symbol_list, list) {
1013 if (sym->type != STT_OBJECT)
1016 if (offset >= sym->offset && offset < sym->offset + sym->len)
1017 return (!memcmp(sym->name, "__gcov0.", 8));
1023 static bool is_kasan_insn(struct instruction *insn)
1025 return (insn->type == INSN_CALL &&
1026 !strcmp(insn->call_dest->name, "__asan_handle_no_return"));
1029 static bool is_ubsan_insn(struct instruction *insn)
1031 return (insn->type == INSN_CALL &&
1032 !strcmp(insn->call_dest->name,
1033 "__ubsan_handle_builtin_unreachable"));
1036 static bool ignore_unreachable_insn(struct symbol *func,
1037 struct instruction *insn)
1041 if (insn->type == INSN_NOP)
1044 if (is_gcov_insn(insn))
1048 * Check if this (or a subsequent) instruction is related to
1049 * CONFIG_UBSAN or CONFIG_KASAN.
1051 * End the search at 5 instructions to avoid going into the weeds.
1053 for (i = 0; i < 5; i++) {
1055 if (is_kasan_insn(insn) || is_ubsan_insn(insn))
1058 if (insn->type == INSN_JUMP_UNCONDITIONAL && insn->jump_dest) {
1059 insn = insn->jump_dest;
1063 if (insn->offset + insn->len >= func->offset + func->len)
1065 insn = list_next_entry(insn, list);
1071 static int validate_functions(struct objtool_file *file)
1073 struct section *sec;
1074 struct symbol *func;
1075 struct instruction *insn;
1076 int ret, warnings = 0;
1078 list_for_each_entry(sec, &file->elf->sections, list) {
1079 list_for_each_entry(func, &sec->symbol_list, list) {
1080 if (func->type != STT_FUNC)
1083 insn = find_insn(file, sec, func->offset);
1087 ret = validate_branch(file, insn, 0);
1092 list_for_each_entry(sec, &file->elf->sections, list) {
1093 list_for_each_entry(func, &sec->symbol_list, list) {
1094 if (func->type != STT_FUNC)
1097 func_for_each_insn(file, func, insn) {
1101 insn->visited = true;
1103 if (file->ignore_unreachables || warnings ||
1104 ignore_unreachable_insn(func, insn))
1107 WARN_FUNC("function has unreachable instruction", insn->sec, insn->offset);
1116 static int validate_uncallable_instructions(struct objtool_file *file)
1118 struct instruction *insn;
1121 for_each_insn(file, insn) {
1122 if (!insn->visited && insn->type == INSN_RETURN) {
1123 WARN_FUNC("return instruction outside of a callable function",
1124 insn->sec, insn->offset);
1132 static void cleanup(struct objtool_file *file)
1134 struct instruction *insn, *tmpinsn;
1135 struct alternative *alt, *tmpalt;
1137 list_for_each_entry_safe(insn, tmpinsn, &file->insn_list, list) {
1138 list_for_each_entry_safe(alt, tmpalt, &insn->alts, list) {
1139 list_del(&alt->list);
1142 list_del(&insn->list);
1143 hash_del(&insn->hash);
1146 elf_close(file->elf);
1149 const char * const check_usage[] = {
1150 "objtool check [<options>] file.o",
1154 int cmd_check(int argc, const char **argv)
1156 struct objtool_file file;
1157 int ret, warnings = 0;
1159 const struct option options[] = {
1160 OPT_BOOLEAN('f', "no-fp", &nofp, "Skip frame pointer validation"),
1164 argc = parse_options(argc, argv, options, check_usage, 0);
1167 usage_with_options(check_usage, options);
1171 file.elf = elf_open(objname);
1173 fprintf(stderr, "error reading elf file %s\n", objname);
1177 INIT_LIST_HEAD(&file.insn_list);
1178 hash_init(file.insn_hash);
1179 file.whitelist = find_section_by_name(file.elf, "__func_stack_frame_non_standard");
1180 file.rodata = find_section_by_name(file.elf, ".rodata");
1181 file.ignore_unreachables = false;
1182 file.c_file = find_section_by_name(file.elf, ".comment");
1184 ret = decode_sections(&file);
1189 ret = validate_functions(&file);
1194 ret = validate_uncallable_instructions(&file);
1202 /* ignore warnings for now until we get all the code cleaned up */
1203 if (ret || warnings)