void *privdata; /* for client to remember who they are */
};
-typedef enum { INPUT, OUTPUT, FOREIGN } HandleType;
+typedef enum { HT_INPUT, HT_OUTPUT, HT_FOREIGN } HandleType;
/* ----------------------------------------------------------------------
* Input threads.
struct handle_input *ctx = (struct handle_input *) param;
OVERLAPPED ovl, *povl;
HANDLE oev;
- int readret, readlen;
+ int readret, readlen, finished;
if (ctx->flags & HANDLE_FLAG_OVERLAPPED) {
povl = &ovl;
(ctx->flags & HANDLE_FLAG_IGNOREEOF))
continue;
+ /*
+ * If we just set ctx->len to 0, that means the read operation
+ * has returned end-of-file. Telling that to the main thread
+ * will cause it to set its 'defunct' flag and dispose of the
+ * handle structure at the next opportunity, in which case we
+ * mustn't touch ctx at all after the SetEvent. (Hence we do
+ * even _this_ check before the SetEvent.)
+ */
+ finished = (ctx->len == 0);
+
SetEvent(ctx->ev_to_main);
- if (!ctx->len)
+ if (finished)
break;
WaitForSingleObject(ctx->ev_from_main, INFINITE);
- if (ctx->done)
- break; /* main thread told us to shut down */
+ if (ctx->done) {
+ /*
+ * The main thread has asked us to shut down. Send back an
+ * event indicating that we've done so. Hereafter we must
+ * not touch ctx at all, because the main thread might
+ * have freed it.
+ */
+ SetEvent(ctx->ev_to_main);
+ break;
+ }
}
if (povl)
while (1) {
WaitForSingleObject(ctx->ev_from_main, INFINITE);
if (ctx->done) {
+ /*
+ * The main thread has asked us to shut down. Send back an
+ * event indicating that we've done so. Hereafter we must
+ * not touch ctx at all, because the main thread might
+ * have freed it.
+ */
SetEvent(ctx->ev_to_main);
break;
}
}
SetEvent(ctx->ev_to_main);
- if (!writeret)
+ if (!writeret) {
+ /*
+ * The write operation has suffered an error. Telling that
+ * to the main thread will cause it to set its 'defunct'
+ * flag and dispose of the handle structure at the next
+ * opportunity, so we must not touch ctx at all after
+ * this.
+ */
break;
+ }
}
if (povl)
struct handle *a = (struct handle *)av;
struct handle *b = (struct handle *)bv;
- if ((unsigned)a->u.g.ev_to_main < (unsigned)b->u.g.ev_to_main)
+ if ((uintptr_t)a->u.g.ev_to_main < (uintptr_t)b->u.g.ev_to_main)
return -1;
- else if ((unsigned)a->u.g.ev_to_main > (unsigned)b->u.g.ev_to_main)
+ else if ((uintptr_t)a->u.g.ev_to_main > (uintptr_t)b->u.g.ev_to_main)
return +1;
else
return 0;
HANDLE *a = (HANDLE *)av;
struct handle *b = (struct handle *)bv;
- if ((unsigned)*a < (unsigned)b->u.g.ev_to_main)
+ if ((uintptr_t)*a < (uintptr_t)b->u.g.ev_to_main)
return -1;
- else if ((unsigned)*a > (unsigned)b->u.g.ev_to_main)
+ else if ((uintptr_t)*a > (uintptr_t)b->u.g.ev_to_main)
return +1;
else
return 0;
struct handle *h = snew(struct handle);
DWORD in_threadid; /* required for Win9x */
- h->type = INPUT;
+ h->type = HT_INPUT;
h->u.i.h = handle;
h->u.i.ev_to_main = CreateEvent(NULL, FALSE, FALSE, NULL);
h->u.i.ev_from_main = CreateEvent(NULL, FALSE, FALSE, NULL);
struct handle *h = snew(struct handle);
DWORD out_threadid; /* required for Win9x */
- h->type = OUTPUT;
+ h->type = HT_OUTPUT;
h->u.o.h = handle;
h->u.o.ev_to_main = CreateEvent(NULL, FALSE, FALSE, NULL);
h->u.o.ev_from_main = CreateEvent(NULL, FALSE, FALSE, NULL);
{
struct handle *h = snew(struct handle);
- h->type = FOREIGN;
+ h->type = HT_FOREIGN;
h->u.f.h = INVALID_HANDLE_VALUE;
h->u.f.ev_to_main = event;
h->u.f.ev_from_main = INVALID_HANDLE_VALUE;
int handle_write(struct handle *h, const void *data, int len)
{
- assert(h->type == OUTPUT);
+ assert(h->type == HT_OUTPUT);
assert(h->u.o.outgoingeof == EOF_NO);
bufchain_add(&h->u.o.queued_data, data, len);
handle_try_output(&h->u.o);
* bidirectional handle if we're still interested in its incoming
* direction!
*/
- assert(h->type == OUTPUT);
+ assert(h->type == HT_OUTPUT);
if (!h->u.o.outgoingeof == EOF_NO) {
h->u.o.outgoingeof = EOF_PENDING;
handle_try_output(&h->u.o);
static void handle_destroy(struct handle *h)
{
- if (h->type == OUTPUT)
+ if (h->type == HT_OUTPUT)
bufchain_clear(&h->u.o.queued_data);
CloseHandle(h->u.g.ev_from_main);
CloseHandle(h->u.g.ev_to_main);
void handle_free(struct handle *h)
{
- /*
- * If the handle is currently busy, we cannot immediately free
- * it. Instead we must wait until it's finished its current
- * operation, because otherwise the subthread will write to
- * invalid memory after we free its context from under it.
- */
assert(h && !h->u.g.moribund);
- if (h->u.g.busy) {
- /*
- * Just set the moribund flag, which will be noticed next
- * time an operation completes.
+ if (h->u.g.busy && h->type != HT_FOREIGN) {
+ /*
+ * If the handle is currently busy, we cannot immediately free
+ * it, because its subthread is in the middle of something.
+ * (Exception: foreign handles don't have a subthread.)
+ *
+ * Instead we must wait until it's finished its current
+ * operation, because otherwise the subthread will write to
+ * invalid memory after we free its context from under it. So
+ * we set the moribund flag, which will be noticed next time
+ * an operation completes.
*/
h->u.g.moribund = TRUE;
} else if (h->u.g.defunct) {
if (h->u.g.moribund) {
/*
- * A moribund handle is already treated as dead from the
- * external user's point of view, so do nothing with the
- * actual event. Just signal the thread to die if
- * necessary, or destroy the handle if not.
+ * A moribund handle is one which we have either already
+ * signalled to die, or are waiting until its current I/O op
+ * completes to do so. Either way, it's treated as already
+ * dead from the external user's point of view, so we ignore
+ * the actual I/O result. We just signal the thread to die if
+ * we haven't yet done so, or destroy the handle if not.
*/
if (h->u.g.done) {
handle_destroy(h);
switch (h->type) {
int backlog;
- case INPUT:
+ case HT_INPUT:
h->u.i.busy = FALSE;
/*
/*
* EOF, or (nearly equivalently) read error.
*/
- h->u.i.gotdata(h, NULL, -h->u.i.readerr);
h->u.i.defunct = TRUE;
+ h->u.i.gotdata(h, NULL, -h->u.i.readerr);
} else {
backlog = h->u.i.gotdata(h, h->u.i.buffer, h->u.i.len);
handle_throttle(&h->u.i, backlog);
}
break;
- case OUTPUT:
+ case HT_OUTPUT:
h->u.o.busy = FALSE;
/*
* and mark the thread as defunct (because the output
* thread is terminating by now).
*/
- h->u.o.sentdata(h, -h->u.o.writeerr);
h->u.o.defunct = TRUE;
+ h->u.o.sentdata(h, -h->u.o.writeerr);
} else {
bufchain_consume(&h->u.o.queued_data, h->u.o.lenwritten);
h->u.o.sentdata(h, bufchain_size(&h->u.o.queued_data));
}
break;
- case FOREIGN:
+ case HT_FOREIGN:
/* Just call the callback. */
h->u.f.callback(h->u.f.ctx);
break;
void handle_unthrottle(struct handle *h, int backlog)
{
- assert(h->type == INPUT);
+ assert(h->type == HT_INPUT);
handle_throttle(&h->u.i, backlog);
}
int handle_backlog(struct handle *h)
{
- assert(h->type == OUTPUT);
+ assert(h->type == HT_OUTPUT);
return bufchain_size(&h->u.o.queued_data);
}