Introduce advise() to print hints

[git.git] / builtin / revert.c

diff --git a/builtin/revert.c b/builtin/revert.c
index e261fb23916724e9bbb3fa664f2aba13f6ada83e..74c1581fdc73129e61c2ade90701900586e3ee82 100644 (file)
--- a/builtin/revert.c
+++ b/builtin/revert.c
@@ -241,6 +241,15 @@ static void set_author_ident_env(const char *message)
                        sha1_to_hex(commit->object.sha1));
 }
 
+static void advise(const char *advice, ...)
+{
+       va_list params;
+
+       va_start(params, advice);
+       vreportf("hint: ", advice, params);
+       va_end(params);
+}
+
 static char *help_msg(void)
 {
        struct strbuf helpbuf = STRBUF_INIT;
@@ -521,8 +530,6 @@ static int do_pick_commit(void)
        } else {
                if (!no_commit)
                        res = run_git_commit(defmsg);
-               if (!res)
-                       fprintf(stderr, "Finished %s.\n", mebuf.buf);
        }
 
        strbuf_release(&mebuf);