builtin-gc.c: guard config parser from value=NULL

[git.git] / builtin-write-tree.c

diff --git a/builtin-write-tree.c b/builtin-write-tree.c
index b89d02efec813d33f8540d2a6d433a94ce1e0a31..d16b9ed0098fd5c12fe83638f51cc3f10fd87ed7 100644 (file)
--- a/builtin-write-tree.c
+++ b/builtin-write-tree.c
@@ -35,11 +35,9 @@ int write_tree(unsigned char *sha1, int missing_ok, const char *prefix)
                                      missing_ok, 0) < 0)
                        die("git-write-tree: error building trees");
                if (0 <= newfd) {
-                       if (!write_cache(newfd, active_cache, active_nr)
-                                       && !close(newfd)) {
-                               commit_lock_file(lock_file);
+                       if (!write_cache(newfd, active_cache, active_nr) &&
+                           !commit_lock_file(lock_file))
                                newfd = -1;
-                       }
                }
                /* Not being able to write is fine -- we are only interested
                 * in updating the cache-tree part, and if the next caller
@@ -60,8 +58,7 @@ int write_tree(unsigned char *sha1, int missing_ok, const char *prefix)
                hashcpy(sha1, active_cache_tree->sha1);
 
        if (0 <= newfd)
-               close(newfd);
-       rollback_lock_file(lock_file);
+               rollback_lock_file(lock_file);
 
        return 0;
 }