]> asedeno.scripts.mit.edu Git - linux.git/blobdiff - crypto/cryptd.c
Merge tag 'riscv-for-linus-5.6-mw0' of git://git.kernel.org/pub/scm/linux/kernel...
[linux.git] / crypto / cryptd.c
index 2c6649b1092327ff94d5599f47424e14b123463e..d94c75c840a5e76abc4b6531ce193bfee976744c 100644 (file)
@@ -221,48 +221,17 @@ static int cryptd_init_instance(struct crypto_instance *inst,
        return 0;
 }
 
-static void *cryptd_alloc_instance(struct crypto_alg *alg, unsigned int head,
-                                  unsigned int tail)
-{
-       char *p;
-       struct crypto_instance *inst;
-       int err;
-
-       p = kzalloc(head + sizeof(*inst) + tail, GFP_KERNEL);
-       if (!p)
-               return ERR_PTR(-ENOMEM);
-
-       inst = (void *)(p + head);
-
-       err = cryptd_init_instance(inst, alg);
-       if (err)
-               goto out_free_inst;
-
-out:
-       return p;
-
-out_free_inst:
-       kfree(p);
-       p = ERR_PTR(err);
-       goto out;
-}
-
 static int cryptd_skcipher_setkey(struct crypto_skcipher *parent,
                                  const u8 *key, unsigned int keylen)
 {
        struct cryptd_skcipher_ctx *ctx = crypto_skcipher_ctx(parent);
        struct crypto_sync_skcipher *child = ctx->child;
-       int err;
 
        crypto_sync_skcipher_clear_flags(child, CRYPTO_TFM_REQ_MASK);
        crypto_sync_skcipher_set_flags(child,
                                       crypto_skcipher_get_flags(parent) &
                                         CRYPTO_TFM_REQ_MASK);
-       err = crypto_sync_skcipher_setkey(child, key, keylen);
-       crypto_skcipher_set_flags(parent,
-                                 crypto_sync_skcipher_get_flags(child) &
-                                         CRYPTO_TFM_RES_MASK);
-       return err;
+       return crypto_sync_skcipher_setkey(child, key, keylen);
 }
 
 static void cryptd_skcipher_complete(struct skcipher_request *req, int err)
@@ -421,8 +390,8 @@ static int cryptd_create_skcipher(struct crypto_template *tmpl,
        ctx = skcipher_instance_ctx(inst);
        ctx->queue = queue;
 
-       crypto_set_skcipher_spawn(&ctx->spawn, skcipher_crypto_instance(inst));
-       err = crypto_grab_skcipher(&ctx->spawn, name, type, mask);
+       err = crypto_grab_skcipher(&ctx->spawn, skcipher_crypto_instance(inst),
+                                  name, type, mask);
        if (err)
                goto out_free_inst;
 
@@ -491,15 +460,11 @@ static int cryptd_hash_setkey(struct crypto_ahash *parent,
 {
        struct cryptd_hash_ctx *ctx   = crypto_ahash_ctx(parent);
        struct crypto_shash *child = ctx->child;
-       int err;
 
        crypto_shash_clear_flags(child, CRYPTO_TFM_REQ_MASK);
        crypto_shash_set_flags(child, crypto_ahash_get_flags(parent) &
                                      CRYPTO_TFM_REQ_MASK);
-       err = crypto_shash_setkey(child, key, keylen);
-       crypto_ahash_set_flags(parent, crypto_shash_get_flags(child) &
-                                      CRYPTO_TFM_RES_MASK);
-       return err;
+       return crypto_shash_setkey(child, key, keylen);
 }
 
 static int cryptd_hash_enqueue(struct ahash_request *req,
@@ -666,44 +631,49 @@ static int cryptd_hash_import(struct ahash_request *req, const void *in)
        return crypto_shash_import(desc, in);
 }
 
+static void cryptd_hash_free(struct ahash_instance *inst)
+{
+       struct hashd_instance_ctx *ctx = ahash_instance_ctx(inst);
+
+       crypto_drop_shash(&ctx->spawn);
+       kfree(inst);
+}
+
 static int cryptd_create_hash(struct crypto_template *tmpl, struct rtattr **tb,
                              struct cryptd_queue *queue)
 {
        struct hashd_instance_ctx *ctx;
        struct ahash_instance *inst;
-       struct shash_alg *salg;
-       struct crypto_alg *alg;
+       struct shash_alg *alg;
        u32 type = 0;
        u32 mask = 0;
        int err;
 
        cryptd_check_internal(tb, &type, &mask);
 
-       salg = shash_attr_alg(tb[1], type, mask);
-       if (IS_ERR(salg))
-               return PTR_ERR(salg);
-
-       alg = &salg->base;
-       inst = cryptd_alloc_instance(alg, ahash_instance_headroom(),
-                                    sizeof(*ctx));
-       err = PTR_ERR(inst);
-       if (IS_ERR(inst))
-               goto out_put_alg;
+       inst = kzalloc(sizeof(*inst) + sizeof(*ctx), GFP_KERNEL);
+       if (!inst)
+               return -ENOMEM;
 
        ctx = ahash_instance_ctx(inst);
        ctx->queue = queue;
 
-       err = crypto_init_shash_spawn(&ctx->spawn, salg,
-                                     ahash_crypto_instance(inst));
+       err = crypto_grab_shash(&ctx->spawn, ahash_crypto_instance(inst),
+                               crypto_attr_alg_name(tb[1]), type, mask);
        if (err)
-               goto out_free_inst;
+               goto err_free_inst;
+       alg = crypto_spawn_shash_alg(&ctx->spawn);
+
+       err = cryptd_init_instance(ahash_crypto_instance(inst), &alg->base);
+       if (err)
+               goto err_free_inst;
 
        inst->alg.halg.base.cra_flags = CRYPTO_ALG_ASYNC |
-               (alg->cra_flags & (CRYPTO_ALG_INTERNAL |
-                                  CRYPTO_ALG_OPTIONAL_KEY));
+               (alg->base.cra_flags & (CRYPTO_ALG_INTERNAL |
+                                       CRYPTO_ALG_OPTIONAL_KEY));
 
-       inst->alg.halg.digestsize = salg->digestsize;
-       inst->alg.halg.statesize = salg->statesize;
+       inst->alg.halg.digestsize = alg->digestsize;
+       inst->alg.halg.statesize = alg->statesize;
        inst->alg.halg.base.cra_ctxsize = sizeof(struct cryptd_hash_ctx);
 
        inst->alg.halg.base.cra_init = cryptd_hash_init_tfm;
@@ -715,19 +685,18 @@ static int cryptd_create_hash(struct crypto_template *tmpl, struct rtattr **tb,
        inst->alg.finup  = cryptd_hash_finup_enqueue;
        inst->alg.export = cryptd_hash_export;
        inst->alg.import = cryptd_hash_import;
-       if (crypto_shash_alg_has_setkey(salg))
+       if (crypto_shash_alg_has_setkey(alg))
                inst->alg.setkey = cryptd_hash_setkey;
        inst->alg.digest = cryptd_hash_digest_enqueue;
 
+       inst->free = cryptd_hash_free;
+
        err = ahash_register_instance(tmpl, inst);
        if (err) {
+err_free_inst:
                crypto_drop_shash(&ctx->spawn);
-out_free_inst:
                kfree(inst);
        }
-
-out_put_alg:
-       crypto_mod_put(alg);
        return err;
 }
 
@@ -849,6 +818,14 @@ static void cryptd_aead_exit_tfm(struct crypto_aead *tfm)
        crypto_free_aead(ctx->child);
 }
 
+static void cryptd_aead_free(struct aead_instance *inst)
+{
+       struct aead_instance_ctx *ctx = aead_instance_ctx(inst);
+
+       crypto_drop_aead(&ctx->aead_spawn);
+       kfree(inst);
+}
+
 static int cryptd_create_aead(struct crypto_template *tmpl,
                              struct rtattr **tb,
                              struct cryptd_queue *queue)
@@ -874,8 +851,8 @@ static int cryptd_create_aead(struct crypto_template *tmpl,
        ctx = aead_instance_ctx(inst);
        ctx->queue = queue;
 
-       crypto_set_aead_spawn(&ctx->aead_spawn, aead_crypto_instance(inst));
-       err = crypto_grab_aead(&ctx->aead_spawn, name, type, mask);
+       err = crypto_grab_aead(&ctx->aead_spawn, aead_crypto_instance(inst),
+                              name, type, mask);
        if (err)
                goto out_free_inst;
 
@@ -898,6 +875,8 @@ static int cryptd_create_aead(struct crypto_template *tmpl,
        inst->alg.encrypt = cryptd_aead_encrypt_enqueue;
        inst->alg.decrypt = cryptd_aead_decrypt_enqueue;
 
+       inst->free = cryptd_aead_free;
+
        err = aead_register_instance(tmpl, inst);
        if (err) {
 out_drop_aead:
@@ -930,31 +909,9 @@ static int cryptd_create(struct crypto_template *tmpl, struct rtattr **tb)
        return -EINVAL;
 }
 
-static void cryptd_free(struct crypto_instance *inst)
-{
-       struct cryptd_instance_ctx *ctx = crypto_instance_ctx(inst);
-       struct hashd_instance_ctx *hctx = crypto_instance_ctx(inst);
-       struct aead_instance_ctx *aead_ctx = crypto_instance_ctx(inst);
-
-       switch (inst->alg.cra_flags & CRYPTO_ALG_TYPE_MASK) {
-       case CRYPTO_ALG_TYPE_AHASH:
-               crypto_drop_shash(&hctx->spawn);
-               kfree(ahash_instance(inst));
-               return;
-       case CRYPTO_ALG_TYPE_AEAD:
-               crypto_drop_aead(&aead_ctx->aead_spawn);
-               kfree(aead_instance(inst));
-               return;
-       default:
-               crypto_drop_spawn(&ctx->spawn);
-               kfree(inst);
-       }
-}
-
 static struct crypto_template cryptd_tmpl = {
        .name = "cryptd",
        .create = cryptd_create,
-       .free = cryptd_free,
        .module = THIS_MODULE,
 };