nvmet-loop: fix possible leakage during error flow

[linux.git] / drivers / firmware / arm_scpi.c

diff --git a/drivers/firmware/arm_scpi.c b/drivers/firmware/arm_scpi.c
index 725164b832424d07af472bf314ab84f77a84ac78..a80c331c3a6e5b11cff260a9b68c1a3a5910ea05 100644 (file)
--- a/drivers/firmware/arm_scpi.c
+++ b/drivers/firmware/arm_scpi.c
@@ -1011,10 +1011,6 @@ static int scpi_probe(struct platform_device *pdev)
                                   scpi_info->firmware_version));
        scpi_info->scpi_ops = &scpi_ops;
 
-       ret = devm_device_add_groups(dev, versions_groups);
-       if (ret)
-               dev_err(dev, "unable to create sysfs version group\n");
-
        return devm_of_platform_populate(dev);
 }
 
@@ -1030,6 +1026,7 @@ static struct platform_driver scpi_driver = {
        .driver = {
                .name = "scpi_protocol",
                .of_match_table = scpi_of_match,
+               .dev_groups = versions_groups,
        },
        .probe = scpi_probe,
        .remove = scpi_remove,