drm/amd/powerplay: Ratelimit all "was not implemented" messages

[linux.git] / drivers / gpu / drm / amd / powerplay / amd_powerplay.c

diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index e8964cae6b93dba0c3d183dcc5383fa12734fca3..b68c2e0fef018d51b60a74596b89ec1441dd4cd1 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -300,7 +300,7 @@ static int pp_set_clockgating_by_smu(void *handle, uint32_t msg_id)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->update_clock_gatings == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
 
@@ -387,7 +387,7 @@ static uint32_t pp_dpm_get_sclk(void *handle, bool low)
                return 0;
 
        if (hwmgr->hwmgr_func->get_sclk == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -405,7 +405,7 @@ static uint32_t pp_dpm_get_mclk(void *handle, bool low)
                return 0;
 
        if (hwmgr->hwmgr_func->get_mclk == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -422,7 +422,7 @@ static void pp_dpm_powergate_vce(void *handle, bool gate)
                return;
 
        if (hwmgr->hwmgr_func->powergate_vce == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -438,7 +438,7 @@ static void pp_dpm_powergate_uvd(void *handle, bool gate)
                return;
 
        if (hwmgr->hwmgr_func->powergate_uvd == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -505,7 +505,7 @@ static void pp_dpm_set_fan_control_mode(void *handle, uint32_t mode)
                return;
 
        if (hwmgr->hwmgr_func->set_fan_control_mode == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -522,7 +522,7 @@ static uint32_t pp_dpm_get_fan_control_mode(void *handle)
                return 0;
 
        if (hwmgr->hwmgr_func->get_fan_control_mode == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -540,7 +540,7 @@ static int pp_dpm_set_fan_speed_percent(void *handle, uint32_t percent)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->set_fan_speed_percent == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -558,7 +558,7 @@ static int pp_dpm_get_fan_speed_percent(void *handle, uint32_t *speed)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->get_fan_speed_percent == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
 
@@ -594,7 +594,7 @@ static int pp_dpm_set_fan_speed_rpm(void *handle, uint32_t rpm)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->set_fan_speed_rpm == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -720,14 +720,17 @@ static int pp_dpm_force_clock_level(void *handle,
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->force_clock_level == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
+
+       if (hwmgr->dpm_level != AMD_DPM_FORCED_LEVEL_MANUAL) {
+               pr_info("force clock level is for dpm manual mode only.\n");
+               return -EINVAL;
+       }
+
        mutex_lock(&hwmgr->smu_lock);
-       if (hwmgr->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL)
-               ret = hwmgr->hwmgr_func->force_clock_level(hwmgr, type, mask);
-       else
-               ret = -EINVAL;
+       ret = hwmgr->hwmgr_func->force_clock_level(hwmgr, type, mask);
        mutex_unlock(&hwmgr->smu_lock);
        return ret;
 }
@@ -742,7 +745,7 @@ static int pp_dpm_print_clock_levels(void *handle,
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->print_clock_levels == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -760,7 +763,7 @@ static int pp_dpm_get_sclk_od(void *handle)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->get_sclk_od == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -778,7 +781,7 @@ static int pp_dpm_set_sclk_od(void *handle, uint32_t value)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->set_sclk_od == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
 
@@ -797,7 +800,7 @@ static int pp_dpm_get_mclk_od(void *handle)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->get_mclk_od == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -815,7 +818,7 @@ static int pp_dpm_set_mclk_od(void *handle, uint32_t value)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->set_mclk_od == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
        mutex_lock(&hwmgr->smu_lock);
@@ -875,7 +878,7 @@ static int pp_get_power_profile_mode(void *handle, char *buf)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->get_power_profile_mode == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return snprintf(buf, PAGE_SIZE, "\n");
        }
 
@@ -891,7 +894,7 @@ static int pp_set_power_profile_mode(void *handle, long *input, uint32_t size)
                return ret;
 
        if (hwmgr->hwmgr_func->set_power_profile_mode == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return ret;
        }
 
@@ -914,7 +917,7 @@ static int pp_odn_edit_dpm_table(void *handle, uint32_t type, long *input, uint3
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->odn_edit_dpm_table == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return -EINVAL;
        }
 
@@ -932,7 +935,7 @@ static int pp_dpm_switch_power_profile(void *handle,
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->set_power_profile_mode == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return -EINVAL;
        }
 
@@ -963,19 +966,26 @@ static int pp_dpm_switch_power_profile(void *handle,
 static int pp_set_power_limit(void *handle, uint32_t limit)
 {
        struct pp_hwmgr *hwmgr = handle;
+       uint32_t max_power_limit;
 
        if (!hwmgr || !hwmgr->pm_en)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->set_power_limit == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return -EINVAL;
        }
 
        if (limit == 0)
                limit = hwmgr->default_power_limit;
 
-       if (limit > hwmgr->default_power_limit)
+       max_power_limit = hwmgr->default_power_limit;
+       if (hwmgr->od_enabled) {
+               max_power_limit *= (100 + hwmgr->platform_descriptor.TDPODLimit);
+               max_power_limit /= 100;
+       }
+
+       if (limit > max_power_limit)
                return -EINVAL;
 
        mutex_lock(&hwmgr->smu_lock);
@@ -994,8 +1004,13 @@ static int pp_get_power_limit(void *handle, uint32_t *limit, bool default_limit)
 
        mutex_lock(&hwmgr->smu_lock);
 
-       if (default_limit)
+       if (default_limit) {
                *limit = hwmgr->default_power_limit;
+               if (hwmgr->od_enabled) {
+                       *limit *= (100 + hwmgr->platform_descriptor.TDPODLimit);
+                       *limit /= 100;
+               }
+       }
        else
                *limit = hwmgr->power_limit;
 
@@ -1197,7 +1212,7 @@ static int pp_dpm_powergate_mmhub(void *handle)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->powergate_mmhub == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
 
@@ -1212,7 +1227,7 @@ static int pp_dpm_powergate_gfx(void *handle, bool gate)
                return 0;
 
        if (hwmgr->hwmgr_func->powergate_gfx == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return 0;
        }
 
@@ -1227,7 +1242,7 @@ static void pp_dpm_powergate_acp(void *handle, bool gate)
                return;
 
        if (hwmgr->hwmgr_func->powergate_acp == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return;
        }
 
@@ -1242,7 +1257,7 @@ static void pp_dpm_powergate_sdma(void *handle, bool gate)
                return;
 
        if (hwmgr->hwmgr_func->powergate_sdma == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return;
        }
 
@@ -1288,7 +1303,7 @@ static int pp_notify_smu_enable_pwe(void *handle)
                return -EINVAL;
 
        if (hwmgr->hwmgr_func->smus_notify_pwe == NULL) {
-               pr_info("%s was not implemented.\n", __func__);
+               pr_info_ratelimited("%s was not implemented.\n", __func__);
                return -EINVAL;;
        }
 
@@ -1303,12 +1318,12 @@ static int pp_enable_mgpu_fan_boost(void *handle)
 {
        struct pp_hwmgr *hwmgr = handle;
 
-       if (!hwmgr || !hwmgr->pm_en)
+       if (!hwmgr)
                return -EINVAL;
 
-       if (hwmgr->hwmgr_func->enable_mgpu_fan_boost == NULL) {
+       if (!hwmgr->pm_en ||
+            hwmgr->hwmgr_func->enable_mgpu_fan_boost == NULL)
                return 0;
-       }
 
        mutex_lock(&hwmgr->smu_lock);
        hwmgr->hwmgr_func->enable_mgpu_fan_boost(hwmgr);