]> asedeno.scripts.mit.edu Git - linux.git/blobdiff - drivers/gpu/drm/bochs/bochs_kms.c
drm/bochs: use simple display pipe
[linux.git] / drivers / gpu / drm / bochs / bochs_kms.c
index c6993c2d596db2c6a92080fa7d21fdfef25538f7..5e905f50449da70e51a2ce8644eae3d84c2347ad 100644 (file)
@@ -9,6 +9,8 @@
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_plane_helper.h>
 #include <drm/drm_atomic_uapi.h>
+#include <drm/drm_gem_framebuffer_helper.h>
+#include <drm/drm_probe_helper.h>
 
 static int defx = 1024;
 static int defy = 768;
@@ -20,277 +22,82 @@ MODULE_PARM_DESC(defy, "default y resolution");
 
 /* ---------------------------------------------------------------------- */
 
-static void bochs_crtc_dpms(struct drm_crtc *crtc, int mode)
-{
-       switch (mode) {
-       case DRM_MODE_DPMS_ON:
-       case DRM_MODE_DPMS_STANDBY:
-       case DRM_MODE_DPMS_SUSPEND:
-       case DRM_MODE_DPMS_OFF:
-       default:
-               return;
-       }
-}
+static const uint32_t bochs_formats[] = {
+       DRM_FORMAT_XRGB8888,
+       DRM_FORMAT_BGRX8888,
+};
 
-static int bochs_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,
-                                   struct drm_framebuffer *old_fb)
+static void bochs_plane_update(struct bochs_device *bochs,
+                              struct drm_plane_state *state)
 {
-       struct bochs_device *bochs =
-               container_of(crtc, struct bochs_device, crtc);
        struct bochs_bo *bo;
-       u64 gpu_addr = 0;
-       int ret;
-
-       if (old_fb) {
-               bo = gem_to_bochs_bo(old_fb->obj[0]);
-               ret = ttm_bo_reserve(&bo->bo, true, false, NULL);
-               if (ret) {
-                       DRM_ERROR("failed to reserve old_fb bo\n");
-               } else {
-                       bochs_bo_unpin(bo);
-                       ttm_bo_unreserve(&bo->bo);
-               }
-       }
-
-       if (WARN_ON(crtc->primary->fb == NULL))
-               return -EINVAL;
-
-       bo = gem_to_bochs_bo(crtc->primary->fb->obj[0]);
-       ret = ttm_bo_reserve(&bo->bo, true, false, NULL);
-       if (ret)
-               return ret;
-
-       ret = bochs_bo_pin(bo, TTM_PL_FLAG_VRAM, &gpu_addr);
-       if (ret) {
-               ttm_bo_unreserve(&bo->bo);
-               return ret;
-       }
-
-       ttm_bo_unreserve(&bo->bo);
-       bochs_hw_setbase(bochs, x, y, gpu_addr);
-       return 0;
-}
-
-static int bochs_crtc_mode_set(struct drm_crtc *crtc,
-                              struct drm_display_mode *mode,
-                              struct drm_display_mode *adjusted_mode,
-                              int x, int y, struct drm_framebuffer *old_fb)
-{
-       struct bochs_device *bochs =
-               container_of(crtc, struct bochs_device, crtc);
-
-       if (WARN_ON(crtc->primary->fb == NULL))
-               return -EINVAL;
-
-       bochs_hw_setmode(bochs, mode);
-       bochs_hw_setformat(bochs, crtc->primary->fb->format);
-       bochs_crtc_mode_set_base(crtc, x, y, old_fb);
-       return 0;
-}
 
-static void bochs_crtc_mode_set_nofb(struct drm_crtc *crtc)
-{
-       struct bochs_device *bochs =
-               container_of(crtc, struct bochs_device, crtc);
+       if (!state->fb || !bochs->stride)
+               return;
 
-       bochs_hw_setmode(bochs, &crtc->mode);
+       bo = gem_to_bochs_bo(state->fb->obj[0]);
+       bochs_hw_setbase(bochs,
+                        state->crtc_x,
+                        state->crtc_y,
+                        bo->bo.offset);
+       bochs_hw_setformat(bochs, state->fb->format);
 }
 
-static void bochs_crtc_prepare(struct drm_crtc *crtc)
+static void bochs_pipe_enable(struct drm_simple_display_pipe *pipe,
+                             struct drm_crtc_state *crtc_state,
+                             struct drm_plane_state *plane_state)
 {
-}
+       struct bochs_device *bochs = pipe->crtc.dev->dev_private;
 
-static void bochs_crtc_commit(struct drm_crtc *crtc)
-{
+       bochs_hw_setmode(bochs, &crtc_state->mode);
+       bochs_plane_update(bochs, plane_state);
 }
 
-static int bochs_crtc_page_flip(struct drm_crtc *crtc,
-                               struct drm_framebuffer *fb,
-                               struct drm_pending_vblank_event *event,
-                               uint32_t page_flip_flags,
-                               struct drm_modeset_acquire_ctx *ctx)
+static void bochs_pipe_update(struct drm_simple_display_pipe *pipe,
+                             struct drm_plane_state *old_state)
 {
-       struct bochs_device *bochs =
-               container_of(crtc, struct bochs_device, crtc);
-       struct drm_framebuffer *old_fb = crtc->primary->fb;
-       unsigned long irqflags;
-
-       drm_atomic_set_fb_for_plane(crtc->primary->state, fb);
-       bochs_crtc_mode_set_base(crtc, 0, 0, old_fb);
-       if (event) {
-               spin_lock_irqsave(&bochs->dev->event_lock, irqflags);
-               drm_crtc_send_vblank_event(crtc, event);
-               spin_unlock_irqrestore(&bochs->dev->event_lock, irqflags);
-       }
-       return 0;
-}
+       struct bochs_device *bochs = pipe->crtc.dev->dev_private;
+       struct drm_crtc *crtc = &pipe->crtc;
 
-static void bochs_crtc_atomic_enable(struct drm_crtc *crtc,
-                                    struct drm_crtc_state *old_crtc_state)
-{
-}
-
-static void bochs_crtc_atomic_flush(struct drm_crtc *crtc,
-                                   struct drm_crtc_state *old_crtc_state)
-{
-       struct drm_device *dev = crtc->dev;
-       struct drm_pending_vblank_event *event;
-
-       if (crtc->state && crtc->state->event) {
-               unsigned long irqflags;
+       bochs_plane_update(bochs, pipe->plane.state);
 
-               spin_lock_irqsave(&dev->event_lock, irqflags);
-               event = crtc->state->event;
+       if (crtc->state->event) {
+               spin_lock_irq(&crtc->dev->event_lock);
+               drm_crtc_send_vblank_event(crtc, crtc->state->event);
                crtc->state->event = NULL;
-               drm_crtc_send_vblank_event(crtc, event);
-               spin_unlock_irqrestore(&dev->event_lock, irqflags);
+               spin_unlock_irq(&crtc->dev->event_lock);
        }
 }
 
-
-/* These provide the minimum set of functions required to handle a CRTC */
-static const struct drm_crtc_funcs bochs_crtc_funcs = {
-       .set_config = drm_crtc_helper_set_config,
-       .destroy = drm_crtc_cleanup,
-       .page_flip = bochs_crtc_page_flip,
-       .reset = drm_atomic_helper_crtc_reset,
-       .atomic_duplicate_state = drm_atomic_helper_crtc_duplicate_state,
-       .atomic_destroy_state = drm_atomic_helper_crtc_destroy_state,
-};
-
-static const struct drm_crtc_helper_funcs bochs_helper_funcs = {
-       .dpms = bochs_crtc_dpms,
-       .mode_set = bochs_crtc_mode_set,
-       .mode_set_base = bochs_crtc_mode_set_base,
-       .mode_set_nofb = bochs_crtc_mode_set_nofb,
-       .prepare = bochs_crtc_prepare,
-       .commit = bochs_crtc_commit,
-       .atomic_enable = bochs_crtc_atomic_enable,
-       .atomic_flush = bochs_crtc_atomic_flush,
-};
-
-static const uint32_t bochs_formats[] = {
-       DRM_FORMAT_XRGB8888,
-       DRM_FORMAT_BGRX8888,
-};
-
-static void bochs_plane_atomic_update(struct drm_plane *plane,
-                                     struct drm_plane_state *old_state)
-{
-       struct bochs_device *bochs = plane->dev->dev_private;
-       struct bochs_bo *bo;
-
-       if (!plane->state->fb)
-               return;
-       bo = gem_to_bochs_bo(plane->state->fb->obj[0]);
-       bochs_hw_setbase(bochs,
-                        plane->state->crtc_x,
-                        plane->state->crtc_y,
-                        bo->bo.offset);
-       bochs_hw_setformat(bochs, plane->state->fb->format);
-}
-
-static int bochs_plane_prepare_fb(struct drm_plane *plane,
-                               struct drm_plane_state *new_state)
+static int bochs_pipe_prepare_fb(struct drm_simple_display_pipe *pipe,
+                                struct drm_plane_state *new_state)
 {
        struct bochs_bo *bo;
-       int ret;
 
        if (!new_state->fb)
                return 0;
        bo = gem_to_bochs_bo(new_state->fb->obj[0]);
-
-       ret = ttm_bo_reserve(&bo->bo, true, false, NULL);
-       if (ret)
-               return ret;
-       ret = bochs_bo_pin(bo, TTM_PL_FLAG_VRAM, NULL);
-       ttm_bo_unreserve(&bo->bo);
-       return ret;
+       return bochs_bo_pin(bo, TTM_PL_FLAG_VRAM);
 }
 
-static void bochs_plane_cleanup_fb(struct drm_plane *plane,
-                                  struct drm_plane_state *old_state)
+static void bochs_pipe_cleanup_fb(struct drm_simple_display_pipe *pipe,
+                                 struct drm_plane_state *old_state)
 {
        struct bochs_bo *bo;
-       int ret;
 
        if (!old_state->fb)
                return;
        bo = gem_to_bochs_bo(old_state->fb->obj[0]);
-       ret = ttm_bo_reserve(&bo->bo, true, false, NULL);
-       if (ret)
-               return;
        bochs_bo_unpin(bo);
-       ttm_bo_unreserve(&bo->bo);
-}
-
-static const struct drm_plane_helper_funcs bochs_plane_helper_funcs = {
-       .atomic_update = bochs_plane_atomic_update,
-       .prepare_fb = bochs_plane_prepare_fb,
-       .cleanup_fb = bochs_plane_cleanup_fb,
-};
-
-static const struct drm_plane_funcs bochs_plane_funcs = {
-       .update_plane   = drm_atomic_helper_update_plane,
-       .disable_plane  = drm_atomic_helper_disable_plane,
-       .destroy        = drm_primary_helper_destroy,
-       .reset          = drm_atomic_helper_plane_reset,
-       .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
-       .atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
-};
-
-static struct drm_plane *bochs_primary_plane(struct drm_device *dev)
-{
-       struct drm_plane *primary;
-       int ret;
-
-       primary = kzalloc(sizeof(*primary), GFP_KERNEL);
-       if (primary == NULL) {
-               DRM_DEBUG_KMS("Failed to allocate primary plane\n");
-               return NULL;
-       }
-
-       ret = drm_universal_plane_init(dev, primary, 0,
-                                      &bochs_plane_funcs,
-                                      bochs_formats,
-                                      ARRAY_SIZE(bochs_formats),
-                                      NULL,
-                                      DRM_PLANE_TYPE_PRIMARY, NULL);
-       if (ret) {
-               kfree(primary);
-               return NULL;
-       }
-
-       drm_plane_helper_add(primary, &bochs_plane_helper_funcs);
-       return primary;
-}
-
-static void bochs_crtc_init(struct drm_device *dev)
-{
-       struct bochs_device *bochs = dev->dev_private;
-       struct drm_crtc *crtc = &bochs->crtc;
-       struct drm_plane *primary = bochs_primary_plane(dev);
-
-       drm_crtc_init_with_planes(dev, crtc, primary, NULL,
-                                 &bochs_crtc_funcs, NULL);
-       drm_crtc_helper_add(crtc, &bochs_helper_funcs);
 }
 
-static const struct drm_encoder_funcs bochs_encoder_encoder_funcs = {
-       .destroy = drm_encoder_cleanup,
+static const struct drm_simple_display_pipe_funcs bochs_pipe_funcs = {
+       .enable     = bochs_pipe_enable,
+       .update     = bochs_pipe_update,
+       .prepare_fb = bochs_pipe_prepare_fb,
+       .cleanup_fb = bochs_pipe_cleanup_fb,
 };
 
-static void bochs_encoder_init(struct drm_device *dev)
-{
-       struct bochs_device *bochs = dev->dev_private;
-       struct drm_encoder *encoder = &bochs->encoder;
-
-       encoder->possible_crtcs = 0x1;
-       drm_encoder_init(dev, encoder, &bochs_encoder_encoder_funcs,
-                        DRM_MODE_ENCODER_DAC, NULL);
-}
-
-
 static int bochs_connector_get_modes(struct drm_connector *connector)
 {
        struct bochs_device *bochs =
@@ -326,20 +133,9 @@ static enum drm_mode_status bochs_connector_mode_valid(struct drm_connector *con
        return MODE_OK;
 }
 
-static struct drm_encoder *
-bochs_connector_best_encoder(struct drm_connector *connector)
-{
-       int enc_id = connector->encoder_ids[0];
-       /* pick the encoder ids */
-       if (enc_id)
-               return drm_encoder_find(connector->dev, NULL, enc_id);
-       return NULL;
-}
-
 static const struct drm_connector_helper_funcs bochs_connector_connector_helper_funcs = {
        .get_modes = bochs_connector_get_modes,
        .mode_valid = bochs_connector_mode_valid,
-       .best_encoder = bochs_connector_best_encoder,
 };
 
 static const struct drm_connector_funcs bochs_connector_connector_funcs = {
@@ -370,11 +166,26 @@ static void bochs_connector_init(struct drm_device *dev)
        }
 }
 
+static struct drm_framebuffer *
+bochs_gem_fb_create(struct drm_device *dev, struct drm_file *file,
+                   const struct drm_mode_fb_cmd2 *mode_cmd)
+{
+       if (mode_cmd->pixel_format != DRM_FORMAT_XRGB8888 &&
+           mode_cmd->pixel_format != DRM_FORMAT_BGRX8888)
+               return ERR_PTR(-EINVAL);
+
+       return drm_gem_fb_create(dev, file, mode_cmd);
+}
+
+const struct drm_mode_config_funcs bochs_mode_funcs = {
+       .fb_create = bochs_gem_fb_create,
+       .atomic_check = drm_atomic_helper_check,
+       .atomic_commit = drm_atomic_helper_commit,
+};
 
 int bochs_kms_init(struct bochs_device *bochs)
 {
        drm_mode_config_init(bochs->dev);
-       bochs->mode_config_initialized = true;
 
        bochs->dev->mode_config.max_width = 8192;
        bochs->dev->mode_config.max_height = 8192;
@@ -386,11 +197,14 @@ int bochs_kms_init(struct bochs_device *bochs)
 
        bochs->dev->mode_config.funcs = &bochs_mode_funcs;
 
-       bochs_crtc_init(bochs->dev);
-       bochs_encoder_init(bochs->dev);
        bochs_connector_init(bochs->dev);
-       drm_connector_attach_encoder(&bochs->connector,
-                                         &bochs->encoder);
+       drm_simple_display_pipe_init(bochs->dev,
+                                    &bochs->pipe,
+                                    &bochs_pipe_funcs,
+                                    bochs_formats,
+                                    ARRAY_SIZE(bochs_formats),
+                                    NULL,
+                                    &bochs->connector);
 
        drm_mode_config_reset(bochs->dev);
 
@@ -399,8 +213,6 @@ int bochs_kms_init(struct bochs_device *bochs)
 
 void bochs_kms_fini(struct bochs_device *bochs)
 {
-       if (bochs->mode_config_initialized) {
-               drm_mode_config_cleanup(bochs->dev);
-               bochs->mode_config_initialized = false;
-       }
+       drm_atomic_helper_shutdown(bochs->dev);
+       drm_mode_config_cleanup(bochs->dev);
 }