]> asedeno.scripts.mit.edu Git - linux.git/blobdiff - drivers/gpu/drm/msm/adreno/adreno_gpu.c
drm/msm: Fix error about comments within a comment block
[linux.git] / drivers / gpu / drm / msm / adreno / adreno_gpu.c
index 048c8be426f3254c37294cca600a0714d1fd84cf..7fd29829b2fad47f066d6e6fd250fa4f9b75e4e7 100644 (file)
@@ -14,6 +14,7 @@
 #include <linux/pm_opp.h>
 #include <linux/slab.h>
 #include <linux/soc/qcom/mdt_loader.h>
+#include <soc/qcom/ocmem.h>
 #include "adreno_gpu.h"
 #include "msm_gem.h"
 #include "msm_mmu.h"
@@ -25,6 +26,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
 {
        struct device *dev = &gpu->pdev->dev;
        const struct firmware *fw;
+       const char *signed_fwname = NULL;
        struct device_node *np, *mem_np;
        struct resource r;
        phys_addr_t mem_phys;
@@ -57,8 +59,43 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
 
        mem_phys = r.start;
 
-       /* Request the MDT file for the firmware */
-       fw = adreno_request_fw(to_adreno_gpu(gpu), fwname);
+       /*
+        * Check for a firmware-name property.  This is the new scheme
+        * to handle firmware that may be signed with device specific
+        * keys, allowing us to have a different zap fw path for different
+        * devices.
+        *
+        * If the firmware-name property is found, we bypass the
+        * adreno_request_fw() mechanism, because we don't need to handle
+        * the /lib/firmware/qcom/... vs /lib/firmware/... case.
+        *
+        * If the firmware-name property is not found, for backwards
+        * compatibility we fall back to the fwname from the gpulist
+        * table.
+        */
+       of_property_read_string_index(np, "firmware-name", 0, &signed_fwname);
+       if (signed_fwname) {
+               fwname = signed_fwname;
+               ret = request_firmware_direct(&fw, fwname, gpu->dev->dev);
+               if (ret)
+                       fw = ERR_PTR(ret);
+       } else if (fwname) {
+               /* Request the MDT file from the default location: */
+               fw = adreno_request_fw(to_adreno_gpu(gpu), fwname);
+       } else {
+               /*
+                * For new targets, we require the firmware-name property,
+                * if a zap-shader is required, rather than falling back
+                * to a firmware name specified in gpulist.
+                *
+                * Because the firmware is signed with a (potentially)
+                * device specific key, having the name come from gpulist
+                * was a bad idea, and is only provided for backwards
+                * compatibility for older targets.
+                */
+               return -ENODEV;
+       }
+
        if (IS_ERR(fw)) {
                DRM_DEV_ERROR(dev, "Unable to load %s\n", fwname);
                return PTR_ERR(fw);
@@ -94,7 +131,7 @@ static int zap_shader_load_mdt(struct msm_gpu *gpu, const char *fwname,
         * not.  But since we've already gotten through adreno_request_fw()
         * we know which of the two cases it is:
         */
-       if (to_adreno_gpu(gpu)->fwloc == FW_LOCATION_LEGACY) {
+       if (signed_fwname || (to_adreno_gpu(gpu)->fwloc == FW_LOCATION_LEGACY)) {
                ret = qcom_mdt_load(dev, fw, fwname, pasid,
                                mem_region, mem_phys, mem_size, NULL);
        } else {
@@ -145,14 +182,6 @@ int adreno_zap_shader_load(struct msm_gpu *gpu, u32 pasid)
                return -EPROBE_DEFER;
        }
 
-       /* Each GPU has a target specific zap shader firmware name to use */
-       if (!adreno_gpu->info->zapfw) {
-               zap_available = false;
-               DRM_DEV_ERROR(&pdev->dev,
-                       "Zap shader firmware file not specified for this target\n");
-               return -ENODEV;
-       }
-
        return zap_shader_load_mdt(gpu, adreno_gpu->info->zapfw, pasid);
 }
 
@@ -825,7 +854,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev)
 
        node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels");
        if (!node) {
-               DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n");
+               DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n");
                return -ENXIO;
        }
 
@@ -886,13 +915,63 @@ static int adreno_get_pwrlevels(struct device *dev,
        DBG("fast_rate=%u, slow_rate=27000000", gpu->fast_rate);
 
        /* Check for an interconnect path for the bus */
-       gpu->icc_path = of_icc_get(dev, NULL);
+       gpu->icc_path = of_icc_get(dev, "gfx-mem");
+       if (!gpu->icc_path) {
+               /*
+                * Keep compatbility with device trees that don't have an
+                * interconnect-names property.
+                */
+               gpu->icc_path = of_icc_get(dev, NULL);
+       }
        if (IS_ERR(gpu->icc_path))
                gpu->icc_path = NULL;
 
+       gpu->ocmem_icc_path = of_icc_get(dev, "ocmem");
+       if (IS_ERR(gpu->ocmem_icc_path))
+               gpu->ocmem_icc_path = NULL;
+
+       return 0;
+}
+
+int adreno_gpu_ocmem_init(struct device *dev, struct adreno_gpu *adreno_gpu,
+                         struct adreno_ocmem *adreno_ocmem)
+{
+       struct ocmem_buf *ocmem_hdl;
+       struct ocmem *ocmem;
+
+       ocmem = of_get_ocmem(dev);
+       if (IS_ERR(ocmem)) {
+               if (PTR_ERR(ocmem) == -ENODEV) {
+                       /*
+                        * Return success since either the ocmem property was
+                        * not specified in device tree, or ocmem support is
+                        * not compiled into the kernel.
+                        */
+                       return 0;
+               }
+
+               return PTR_ERR(ocmem);
+       }
+
+       ocmem_hdl = ocmem_allocate(ocmem, OCMEM_GRAPHICS, adreno_gpu->gmem);
+       if (IS_ERR(ocmem_hdl))
+               return PTR_ERR(ocmem_hdl);
+
+       adreno_ocmem->ocmem = ocmem;
+       adreno_ocmem->base = ocmem_hdl->addr;
+       adreno_ocmem->hdl = ocmem_hdl;
+       adreno_gpu->gmem = ocmem_hdl->len;
+
        return 0;
 }
 
+void adreno_gpu_ocmem_cleanup(struct adreno_ocmem *adreno_ocmem)
+{
+       if (adreno_ocmem && adreno_ocmem->base)
+               ocmem_free(adreno_ocmem->ocmem, OCMEM_GRAPHICS,
+                          adreno_ocmem->hdl);
+}
+
 int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev,
                struct adreno_gpu *adreno_gpu,
                const struct adreno_gpu_funcs *funcs, int nr_rings)
@@ -937,6 +1016,7 @@ void adreno_gpu_cleanup(struct adreno_gpu *adreno_gpu)
                release_firmware(adreno_gpu->fw[i]);
 
        icc_put(gpu->icc_path);
+       icc_put(gpu->ocmem_icc_path);
 
        msm_gpu_cleanup(&adreno_gpu->base);
 }