]> asedeno.scripts.mit.edu Git - linux.git/blobdiff - drivers/gpu/drm/panel/panel-simple.c
drm/panel: Add support for AUO B116XAK01 panel
[linux.git] / drivers / gpu / drm / panel / panel-simple.c
index 5d487686d25c510cb55fede3eb624b284e273b90..0c3444c62014de7c72d7af132c6264728e9defa3 100644 (file)
@@ -21,7 +21,6 @@
  * DEALINGS IN THE SOFTWARE.
  */
 
-#include <linux/backlight.h>
 #include <linux/delay.h>
 #include <linux/gpio/consumer.h>
 #include <linux/module.h>
@@ -105,7 +104,6 @@ struct panel_simple {
 
        const struct panel_desc *desc;
 
-       struct backlight_device *backlight;
        struct regulator *supply;
        struct i2c_adapter *ddc;
 
@@ -119,10 +117,9 @@ static inline struct panel_simple *to_panel_simple(struct drm_panel *panel)
        return container_of(panel, struct panel_simple, base);
 }
 
-static unsigned int panel_simple_get_timings_modes(struct panel_simple *panel)
+static unsigned int panel_simple_get_timings_modes(struct panel_simple *panel,
+                                                  struct drm_connector *connector)
 {
-       struct drm_connector *connector = panel->base.connector;
-       struct drm_device *drm = panel->base.drm;
        struct drm_display_mode *mode;
        unsigned int i, num = 0;
 
@@ -131,9 +128,9 @@ static unsigned int panel_simple_get_timings_modes(struct panel_simple *panel)
                struct videomode vm;
 
                videomode_from_timing(dt, &vm);
-               mode = drm_mode_create(drm);
+               mode = drm_mode_create(connector->dev);
                if (!mode) {
-                       dev_err(drm->dev, "failed to add mode %ux%u\n",
+                       dev_err(panel->base.dev, "failed to add mode %ux%u\n",
                                dt->hactive.typ, dt->vactive.typ);
                        continue;
                }
@@ -152,19 +149,18 @@ static unsigned int panel_simple_get_timings_modes(struct panel_simple *panel)
        return num;
 }
 
-static unsigned int panel_simple_get_display_modes(struct panel_simple *panel)
+static unsigned int panel_simple_get_display_modes(struct panel_simple *panel,
+                                                  struct drm_connector *connector)
 {
-       struct drm_connector *connector = panel->base.connector;
-       struct drm_device *drm = panel->base.drm;
        struct drm_display_mode *mode;
        unsigned int i, num = 0;
 
        for (i = 0; i < panel->desc->num_modes; i++) {
                const struct drm_display_mode *m = &panel->desc->modes[i];
 
-               mode = drm_mode_duplicate(drm, m);
+               mode = drm_mode_duplicate(connector->dev, m);
                if (!mode) {
-                       dev_err(drm->dev, "failed to add mode %ux%u@%u\n",
+                       dev_err(panel->base.dev, "failed to add mode %ux%u@%u\n",
                                m->hdisplay, m->vdisplay, m->vrefresh);
                        continue;
                }
@@ -183,10 +179,9 @@ static unsigned int panel_simple_get_display_modes(struct panel_simple *panel)
        return num;
 }
 
-static int panel_simple_get_non_edid_modes(struct panel_simple *panel)
+static int panel_simple_get_non_edid_modes(struct panel_simple *panel,
+                                          struct drm_connector *connector)
 {
-       struct drm_connector *connector = panel->base.connector;
-       struct drm_device *drm = panel->base.drm;
        struct drm_display_mode *mode;
        bool has_override = panel->override_mode.type;
        unsigned int num = 0;
@@ -195,18 +190,19 @@ static int panel_simple_get_non_edid_modes(struct panel_simple *panel)
                return 0;
 
        if (has_override) {
-               mode = drm_mode_duplicate(drm, &panel->override_mode);
+               mode = drm_mode_duplicate(connector->dev,
+                                         &panel->override_mode);
                if (mode) {
                        drm_mode_probed_add(connector, mode);
                        num = 1;
                } else {
-                       dev_err(drm->dev, "failed to add override mode\n");
+                       dev_err(panel->base.dev, "failed to add override mode\n");
                }
        }
 
        /* Only add timings if override was not there or failed to validate */
        if (num == 0 && panel->desc->num_timings)
-               num = panel_simple_get_timings_modes(panel);
+               num = panel_simple_get_timings_modes(panel, connector);
 
        /*
         * Only add fixed modes if timings/override added no mode.
@@ -216,7 +212,7 @@ static int panel_simple_get_non_edid_modes(struct panel_simple *panel)
         */
        WARN_ON(panel->desc->num_timings && panel->desc->num_modes);
        if (num == 0)
-               num = panel_simple_get_display_modes(panel);
+               num = panel_simple_get_display_modes(panel, connector);
 
        connector->display_info.bpc = panel->desc->bpc;
        connector->display_info.width_mm = panel->desc->size.width;
@@ -236,12 +232,6 @@ static int panel_simple_disable(struct drm_panel *panel)
        if (!p->enabled)
                return 0;
 
-       if (p->backlight) {
-               p->backlight->props.power = FB_BLANK_POWERDOWN;
-               p->backlight->props.state |= BL_CORE_FBBLANK;
-               backlight_update_status(p->backlight);
-       }
-
        if (p->desc->delay.disable)
                msleep(p->desc->delay.disable);
 
@@ -307,34 +297,30 @@ static int panel_simple_enable(struct drm_panel *panel)
        if (p->desc->delay.enable)
                msleep(p->desc->delay.enable);
 
-       if (p->backlight) {
-               p->backlight->props.state &= ~BL_CORE_FBBLANK;
-               p->backlight->props.power = FB_BLANK_UNBLANK;
-               backlight_update_status(p->backlight);
-       }
-
        p->enabled = true;
 
        return 0;
 }
 
-static int panel_simple_get_modes(struct drm_panel *panel)
+static int panel_simple_get_modes(struct drm_panel *panel,
+                                 struct drm_connector *connector)
 {
        struct panel_simple *p = to_panel_simple(panel);
        int num = 0;
 
        /* probe EDID if a DDC bus is available */
        if (p->ddc) {
-               struct edid *edid = drm_get_edid(panel->connector, p->ddc);
-               drm_connector_update_edid_property(panel->connector, edid);
+               struct edid *edid = drm_get_edid(connector, p->ddc);
+
+               drm_connector_update_edid_property(connector, edid);
                if (edid) {
-                       num += drm_add_edid_modes(panel->connector, edid);
+                       num += drm_add_edid_modes(connector, edid);
                        kfree(edid);
                }
        }
 
        /* add hard-coded panel modes */
-       num += panel_simple_get_non_edid_modes(p);
+       num += panel_simple_get_non_edid_modes(p, connector);
 
        return num;
 }
@@ -414,9 +400,9 @@ static void panel_simple_parse_panel_timing_node(struct device *dev,
 
 static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
 {
-       struct device_node *backlight, *ddc;
        struct panel_simple *panel;
        struct display_timing dt;
+       struct device_node *ddc;
        int err;
 
        panel = devm_kzalloc(dev, sizeof(*panel), GFP_KERNEL);
@@ -442,24 +428,13 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
                return err;
        }
 
-       backlight = of_parse_phandle(dev->of_node, "backlight", 0);
-       if (backlight) {
-               panel->backlight = of_find_backlight_by_node(backlight);
-               of_node_put(backlight);
-
-               if (!panel->backlight)
-                       return -EPROBE_DEFER;
-       }
-
        ddc = of_parse_phandle(dev->of_node, "ddc-i2c-bus", 0);
        if (ddc) {
                panel->ddc = of_find_i2c_adapter_by_node(ddc);
                of_node_put(ddc);
 
-               if (!panel->ddc) {
-                       err = -EPROBE_DEFER;
-                       goto free_backlight;
-               }
+               if (!panel->ddc)
+                       return -EPROBE_DEFER;
        }
 
        if (!of_get_display_timing(dev->of_node, "panel-timing", &dt))
@@ -468,6 +443,10 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
        drm_panel_init(&panel->base, dev, &panel_simple_funcs,
                       desc->connector_type);
 
+       err = drm_panel_of_backlight(&panel->base);
+       if (err)
+               goto free_ddc;
+
        err = drm_panel_add(&panel->base);
        if (err < 0)
                goto free_ddc;
@@ -479,9 +458,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
 free_ddc:
        if (panel->ddc)
                put_device(&panel->ddc->dev);
-free_backlight:
-       if (panel->backlight)
-               put_device(&panel->backlight->dev);
 
        return err;
 }
@@ -491,16 +467,12 @@ static int panel_simple_remove(struct device *dev)
        struct panel_simple *panel = dev_get_drvdata(dev);
 
        drm_panel_remove(&panel->base);
-
-       panel_simple_disable(&panel->base);
-       panel_simple_unprepare(&panel->base);
+       drm_panel_disable(&panel->base);
+       drm_panel_unprepare(&panel->base);
 
        if (panel->ddc)
                put_device(&panel->ddc->dev);
 
-       if (panel->backlight)
-               put_device(&panel->backlight->dev);
-
        return 0;
 }
 
@@ -508,8 +480,8 @@ static void panel_simple_shutdown(struct device *dev)
 {
        struct panel_simple *panel = dev_get_drvdata(dev);
 
-       panel_simple_disable(&panel->base);
-       panel_simple_unprepare(&panel->base);
+       drm_panel_disable(&panel->base);
+       drm_panel_unprepare(&panel->base);
 }
 
 static const struct drm_display_mode ampire_am_480272h3tmqw_t01h_mode = {
@@ -657,6 +629,35 @@ static const struct panel_desc auo_b101xtn01 = {
        },
 };
 
+static const struct drm_display_mode auo_b116xak01_mode = {
+       .clock = 69300,
+       .hdisplay = 1366,
+       .hsync_start = 1366 + 48,
+       .hsync_end = 1366 + 48 + 32,
+       .htotal = 1366 + 48 + 32 + 10,
+       .vdisplay = 768,
+       .vsync_start = 768 + 4,
+       .vsync_end = 768 + 4 + 6,
+       .vtotal = 768 + 4 + 6 + 15,
+       .vrefresh = 60,
+       .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc auo_b116xak01 = {
+       .modes = &auo_b116xak01_mode,
+       .num_modes = 1,
+       .bpc = 6,
+       .size = {
+               .width = 256,
+               .height = 144,
+       },
+       .delay = {
+               .hpd_absent_delay = 200,
+       },
+       .bus_format = MEDIA_BUS_FMT_RGB666_1X18,
+       .connector_type = DRM_MODE_CONNECTOR_eDP,
+};
+
 static const struct drm_display_mode auo_b116xw03_mode = {
        .clock = 70589,
        .hdisplay = 1366,
@@ -2061,6 +2062,40 @@ static const struct drm_display_mode mitsubishi_aa070mc01_mode = {
        .flags = DRM_MODE_FLAG_NHSYNC | DRM_MODE_FLAG_NVSYNC,
 };
 
+static const struct drm_display_mode logicpd_type_28_mode = {
+       .clock = 9000,
+       .hdisplay = 480,
+       .hsync_start = 480 + 3,
+       .hsync_end = 480 + 3 + 42,
+       .htotal = 480 + 3 + 42 + 2,
+
+       .vdisplay = 272,
+       .vsync_start = 272 + 2,
+       .vsync_end = 272 + 2 + 11,
+       .vtotal = 272 + 2 + 11 + 3,
+       .vrefresh = 60,
+       .flags = DRM_MODE_FLAG_PHSYNC | DRM_MODE_FLAG_PVSYNC,
+};
+
+static const struct panel_desc logicpd_type_28 = {
+       .modes = &logicpd_type_28_mode,
+       .num_modes = 1,
+       .bpc = 8,
+       .size = {
+               .width = 105,
+               .height = 67,
+       },
+       .delay = {
+               .prepare = 200,
+               .enable = 200,
+               .unprepare = 200,
+               .disable = 200,
+       },
+       .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+       .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE |
+                    DRM_BUS_FLAG_SYNC_DRIVE_NEGEDGE,
+};
+
 static const struct panel_desc mitsubishi_aa070mc01 = {
        .modes = &mitsubishi_aa070mc01_mode,
        .num_modes = 1,
@@ -3119,6 +3154,9 @@ static const struct of_device_id platform_of_match[] = {
        }, {
                .compatible = "auo,b101xtn01",
                .data = &auo_b101xtn01,
+       }, {
+               .compatible = "auo,b116xa01",
+               .data = &auo_b116xak01,
        }, {
                .compatible = "auo,b116xw03",
                .data = &auo_b116xw03,
@@ -3287,6 +3325,9 @@ static const struct of_device_id platform_of_match[] = {
        }, {
                .compatible = "lg,lp129qe",
                .data = &lg_lp129qe,
+       }, {
+               .compatible = "logicpd,type28",
+               .data = &logicpd_type_28,
        }, {
                .compatible = "mitsubishi,aa070mc01-ca1",
                .data = &mitsubishi_aa070mc01,