drm: sun4i: add quirks for TCON TOP

[linux.git] / drivers / gpu / drm / sun4i / sun8i_tcon_top.c

diff --git a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
index 9831a9fe2cf4714bf70855a87d8cca4afa1f0ca9..e94e3fb1736bf7cd105a474d7204a3700fba4efe 100644 (file)
--- a/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
+++ b/drivers/gpu/drm/sun4i/sun8i_tcon_top.c
@@ -9,11 +9,17 @@
 #include <linux/component.h>
 #include <linux/device.h>
 #include <linux/module.h>
+#include <linux/of_device.h>
 #include <linux/of_graph.h>
 #include <linux/platform_device.h>
 
 #include "sun8i_tcon_top.h"
 
+struct sun8i_tcon_top_quirks {
+       bool has_tcon_tv1;
+       bool has_dsi;
+};
+
 static bool sun8i_tcon_top_node_is_tcon_top(struct device_node *node)
 {
        return !!of_match_node(sun8i_tcon_top_of_table, node);
@@ -121,10 +127,13 @@ static int sun8i_tcon_top_bind(struct device *dev, struct device *master,
        struct platform_device *pdev = to_platform_device(dev);
        struct clk_hw_onecell_data *clk_data;
        struct sun8i_tcon_top *tcon_top;
+       const struct sun8i_tcon_top_quirks *quirks;
        struct resource *res;
        void __iomem *regs;
        int ret, i;
 
+       quirks = of_device_get_match_data(&pdev->dev);
+
        tcon_top = devm_kzalloc(dev, sizeof(*tcon_top), GFP_KERNEL);
        if (!tcon_top)
                return -ENOMEM;
@@ -167,6 +176,13 @@ static int sun8i_tcon_top_bind(struct device *dev, struct device *master,
                goto err_assert_reset;
        }
 
+       /*
+        * At least on H6, some registers have some bits set by default
+        * which may cause issues. Clear them here.
+        */
+       writel(0, regs + TCON_TOP_PORT_SEL_REG);
+       writel(0, regs + TCON_TOP_GATE_SRC_REG);
+
        /*
         * TCON TOP has two muxes, which select parent clock for each TCON TV
         * channel clock. Parent could be either TCON TV or TVE clock. For now
@@ -180,15 +196,17 @@ static int sun8i_tcon_top_bind(struct device *dev, struct device *master,
                                             &tcon_top->reg_lock,
                                             TCON_TOP_TCON_TV0_GATE, 0);
 
-       clk_data->hws[CLK_TCON_TOP_TV1] =
-               sun8i_tcon_top_register_gate(dev, "tcon-tv1", regs,
-                                            &tcon_top->reg_lock,
-                                            TCON_TOP_TCON_TV1_GATE, 1);
+       if (quirks->has_tcon_tv1)
+               clk_data->hws[CLK_TCON_TOP_TV1] =
+                       sun8i_tcon_top_register_gate(dev, "tcon-tv1", regs,
+                                                    &tcon_top->reg_lock,
+                                                    TCON_TOP_TCON_TV1_GATE, 1);
 
-       clk_data->hws[CLK_TCON_TOP_DSI] =
-               sun8i_tcon_top_register_gate(dev, "dsi", regs,
-                                            &tcon_top->reg_lock,
-                                            TCON_TOP_TCON_DSI_GATE, 2);
+       if (quirks->has_dsi)
+               clk_data->hws[CLK_TCON_TOP_DSI] =
+                       sun8i_tcon_top_register_gate(dev, "dsi", regs,
+                                                    &tcon_top->reg_lock,
+                                                    TCON_TOP_TCON_DSI_GATE, 2);
 
        for (i = 0; i < CLK_NUM; i++)
                if (IS_ERR(clk_data->hws[i])) {
@@ -250,8 +268,17 @@ static int sun8i_tcon_top_remove(struct platform_device *pdev)
        return 0;
 }
 
+const struct sun8i_tcon_top_quirks sun8i_r40_tcon_top_quirks = {
+       .has_tcon_tv1   = true,
+       .has_dsi        = true,
+};
+
 /* sun4i_drv uses this list to check if a device node is a TCON TOP */
 const struct of_device_id sun8i_tcon_top_of_table[] = {
+       {
+               .compatible = "allwinner,sun8i-r40-tcon-top",
+               .data = &sun8i_r40_tcon_top_quirks
+       },
        { /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, sun8i_tcon_top_of_table);