]> asedeno.scripts.mit.edu Git - linux.git/blobdiff - drivers/media/v4l2-core/v4l2-compat-ioctl32.c
Merge branch 'pipe-exclusive-wakeup'
[linux.git] / drivers / media / v4l2-core / v4l2-compat-ioctl32.c
index e1eaf1135c7f88d3a09a7b7d26dd027b50e4cbc5..a99e82ec9ab60de072215206c7042274ed81d319 100644 (file)
@@ -468,13 +468,43 @@ struct v4l2_plane32 {
        __u32                   reserved[11];
 };
 
+/*
+ * This is correct for all architectures including i386, but not x32,
+ * which has different alignment requirements for timestamp
+ */
 struct v4l2_buffer32 {
        __u32                   index;
        __u32                   type;   /* enum v4l2_buf_type */
        __u32                   bytesused;
        __u32                   flags;
        __u32                   field;  /* enum v4l2_field */
-       struct compat_timeval   timestamp;
+       struct {
+               compat_s64      tv_sec;
+               compat_s64      tv_usec;
+       }                       timestamp;
+       struct v4l2_timecode    timecode;
+       __u32                   sequence;
+
+       /* memory location */
+       __u32                   memory; /* enum v4l2_memory */
+       union {
+               __u32           offset;
+               compat_long_t   userptr;
+               compat_caddr_t  planes;
+               __s32           fd;
+       } m;
+       __u32                   length;
+       __u32                   reserved2;
+       __s32                   request_fd;
+};
+
+struct v4l2_buffer32_time32 {
+       __u32                   index;
+       __u32                   type;   /* enum v4l2_buf_type */
+       __u32                   bytesused;
+       __u32                   flags;
+       __u32                   field;  /* enum v4l2_field */
+       struct old_timeval32    timestamp;
        struct v4l2_timecode    timecode;
        __u32                   sequence;
 
@@ -581,6 +611,31 @@ static int bufsize_v4l2_buffer(struct v4l2_buffer32 __user *p32, u32 *size)
        return 0;
 }
 
+static int bufsize_v4l2_buffer_time32(struct v4l2_buffer32_time32 __user *p32, u32 *size)
+{
+       u32 type;
+       u32 length;
+
+       if (!access_ok(p32, sizeof(*p32)) ||
+           get_user(type, &p32->type) ||
+           get_user(length, &p32->length))
+               return -EFAULT;
+
+       if (V4L2_TYPE_IS_MULTIPLANAR(type)) {
+               if (length > VIDEO_MAX_PLANES)
+                       return -EINVAL;
+
+               /*
+                * We don't really care if userspace decides to kill itself
+                * by passing a very big length value
+                */
+               *size = length * sizeof(struct v4l2_plane);
+       } else {
+               *size = 0;
+       }
+       return 0;
+}
+
 static int get_v4l2_buffer32(struct v4l2_buffer __user *p64,
                             struct v4l2_buffer32 __user *p32,
                             void __user *aux_buf, u32 aux_space)
@@ -681,6 +736,106 @@ static int get_v4l2_buffer32(struct v4l2_buffer __user *p64,
        return 0;
 }
 
+static int get_v4l2_buffer32_time32(struct v4l2_buffer_time32 __user *p64,
+                                   struct v4l2_buffer32_time32 __user *p32,
+                                   void __user *aux_buf, u32 aux_space)
+{
+       u32 type;
+       u32 length;
+       s32 request_fd;
+       enum v4l2_memory memory;
+       struct v4l2_plane32 __user *uplane32;
+       struct v4l2_plane __user *uplane;
+       compat_caddr_t p;
+       int ret;
+
+       if (!access_ok(p32, sizeof(*p32)) ||
+           assign_in_user(&p64->index, &p32->index) ||
+           get_user(type, &p32->type) ||
+           put_user(type, &p64->type) ||
+           assign_in_user(&p64->flags, &p32->flags) ||
+           get_user(memory, &p32->memory) ||
+           put_user(memory, &p64->memory) ||
+           get_user(length, &p32->length) ||
+           put_user(length, &p64->length) ||
+           get_user(request_fd, &p32->request_fd) ||
+           put_user(request_fd, &p64->request_fd))
+               return -EFAULT;
+
+       if (V4L2_TYPE_IS_OUTPUT(type))
+               if (assign_in_user(&p64->bytesused, &p32->bytesused) ||
+                   assign_in_user(&p64->field, &p32->field) ||
+                   assign_in_user(&p64->timestamp.tv_sec,
+                                  &p32->timestamp.tv_sec) ||
+                   assign_in_user(&p64->timestamp.tv_usec,
+                                  &p32->timestamp.tv_usec))
+                       return -EFAULT;
+
+       if (V4L2_TYPE_IS_MULTIPLANAR(type)) {
+               u32 num_planes = length;
+
+               if (num_planes == 0) {
+                       /*
+                        * num_planes == 0 is legal, e.g. when userspace doesn't
+                        * need planes array on DQBUF
+                        */
+                       return put_user(NULL, &p64->m.planes);
+               }
+               if (num_planes > VIDEO_MAX_PLANES)
+                       return -EINVAL;
+
+               if (get_user(p, &p32->m.planes))
+                       return -EFAULT;
+
+               uplane32 = compat_ptr(p);
+               if (!access_ok(uplane32,
+                              num_planes * sizeof(*uplane32)))
+                       return -EFAULT;
+
+               /*
+                * We don't really care if userspace decides to kill itself
+                * by passing a very big num_planes value
+                */
+               if (aux_space < num_planes * sizeof(*uplane))
+                       return -EFAULT;
+
+               uplane = aux_buf;
+               if (put_user_force(uplane, &p64->m.planes))
+                       return -EFAULT;
+
+               while (num_planes--) {
+                       ret = get_v4l2_plane32(uplane, uplane32, memory);
+                       if (ret)
+                               return ret;
+                       uplane++;
+                       uplane32++;
+               }
+       } else {
+               switch (memory) {
+               case V4L2_MEMORY_MMAP:
+               case V4L2_MEMORY_OVERLAY:
+                       if (assign_in_user(&p64->m.offset, &p32->m.offset))
+                               return -EFAULT;
+                       break;
+               case V4L2_MEMORY_USERPTR: {
+                       compat_ulong_t userptr;
+
+                       if (get_user(userptr, &p32->m.userptr) ||
+                           put_user((unsigned long)compat_ptr(userptr),
+                                    &p64->m.userptr))
+                               return -EFAULT;
+                       break;
+               }
+               case V4L2_MEMORY_DMABUF:
+                       if (assign_in_user(&p64->m.fd, &p32->m.fd))
+                               return -EFAULT;
+                       break;
+               }
+       }
+
+       return 0;
+}
+
 static int put_v4l2_buffer32(struct v4l2_buffer __user *p64,
                             struct v4l2_buffer32 __user *p32)
 {
@@ -761,6 +916,86 @@ static int put_v4l2_buffer32(struct v4l2_buffer __user *p64,
        return 0;
 }
 
+static int put_v4l2_buffer32_time32(struct v4l2_buffer_time32 __user *p64,
+                                   struct v4l2_buffer32_time32 __user *p32)
+{
+       u32 type;
+       u32 length;
+       enum v4l2_memory memory;
+       struct v4l2_plane32 __user *uplane32;
+       struct v4l2_plane *uplane;
+       compat_caddr_t p;
+       int ret;
+
+       if (!access_ok(p32, sizeof(*p32)) ||
+           assign_in_user(&p32->index, &p64->index) ||
+           get_user(type, &p64->type) ||
+           put_user(type, &p32->type) ||
+           assign_in_user(&p32->flags, &p64->flags) ||
+           get_user(memory, &p64->memory) ||
+           put_user(memory, &p32->memory))
+               return -EFAULT;
+
+       if (assign_in_user(&p32->bytesused, &p64->bytesused) ||
+           assign_in_user(&p32->field, &p64->field) ||
+           assign_in_user(&p32->timestamp.tv_sec, &p64->timestamp.tv_sec) ||
+           assign_in_user(&p32->timestamp.tv_usec, &p64->timestamp.tv_usec) ||
+           copy_in_user(&p32->timecode, &p64->timecode, sizeof(p64->timecode)) ||
+           assign_in_user(&p32->sequence, &p64->sequence) ||
+           assign_in_user(&p32->reserved2, &p64->reserved2) ||
+           assign_in_user(&p32->request_fd, &p64->request_fd) ||
+           get_user(length, &p64->length) ||
+           put_user(length, &p32->length))
+               return -EFAULT;
+
+       if (V4L2_TYPE_IS_MULTIPLANAR(type)) {
+               u32 num_planes = length;
+
+               if (num_planes == 0)
+                       return 0;
+               /* We need to define uplane without __user, even though
+                * it does point to data in userspace here. The reason is
+                * that v4l2-ioctl.c copies it from userspace to kernelspace,
+                * so its definition in videodev2.h doesn't have a
+                * __user markup. Defining uplane with __user causes
+                * smatch warnings, so instead declare it without __user
+                * and cast it as a userspace pointer to put_v4l2_plane32().
+                */
+               if (get_user(uplane, &p64->m.planes))
+                       return -EFAULT;
+               if (get_user(p, &p32->m.planes))
+                       return -EFAULT;
+               uplane32 = compat_ptr(p);
+
+               while (num_planes--) {
+                       ret = put_v4l2_plane32((void __user *)uplane,
+                                              uplane32, memory);
+                       if (ret)
+                               return ret;
+                       ++uplane;
+                       ++uplane32;
+               }
+       } else {
+               switch (memory) {
+               case V4L2_MEMORY_MMAP:
+               case V4L2_MEMORY_OVERLAY:
+                       if (assign_in_user(&p32->m.offset, &p64->m.offset))
+                               return -EFAULT;
+                       break;
+               case V4L2_MEMORY_USERPTR:
+                       if (assign_in_user(&p32->m.userptr, &p64->m.userptr))
+                               return -EFAULT;
+                       break;
+               case V4L2_MEMORY_DMABUF:
+                       if (assign_in_user(&p32->m.fd, &p64->m.fd))
+                               return -EFAULT;
+                       break;
+               }
+       }
+
+       return 0;
+}
+
 struct v4l2_framebuffer32 {
        __u32                   capability;
        __u32                   flags;
@@ -1028,6 +1263,15 @@ static int put_v4l2_ext_controls32(struct file *file,
        return 0;
 }
 
+#ifdef CONFIG_X86_64
+/*
+ * x86 is the only compat architecture with different struct alignment
+ * between 32-bit and 64-bit tasks.
+ *
+ * On all other architectures, v4l2_event32 and v4l2_event32_time32 are
+ * the same as v4l2_event and v4l2_event_time32, so we can use the native
+ * handlers, converting v4l2_event to v4l2_event_time32 if necessary.
+ */
 struct v4l2_event32 {
        __u32                           type;
        union {
@@ -1036,7 +1280,23 @@ struct v4l2_event32 {
        } u;
        __u32                           pending;
        __u32                           sequence;
-       struct compat_timespec          timestamp;
+       struct {
+               compat_s64              tv_sec;
+               compat_s64              tv_nsec;
+       } timestamp;
+       __u32                           id;
+       __u32                           reserved[8];
+};
+
+struct v4l2_event32_time32 {
+       __u32                           type;
+       union {
+               compat_s64              value64;
+               __u8                    data[64];
+       } u;
+       __u32                           pending;
+       __u32                           sequence;
+       struct old_timespec32           timestamp;
        __u32                           id;
        __u32                           reserved[8];
 };
@@ -1057,6 +1317,23 @@ static int put_v4l2_event32(struct v4l2_event __user *p64,
        return 0;
 }
 
+static int put_v4l2_event32_time32(struct v4l2_event_time32 __user *p64,
+                                  struct v4l2_event32_time32 __user *p32)
+{
+       if (!access_ok(p32, sizeof(*p32)) ||
+           assign_in_user(&p32->type, &p64->type) ||
+           copy_in_user(&p32->u, &p64->u, sizeof(p64->u)) ||
+           assign_in_user(&p32->pending, &p64->pending) ||
+           assign_in_user(&p32->sequence, &p64->sequence) ||
+           assign_in_user(&p32->timestamp.tv_sec, &p64->timestamp.tv_sec) ||
+           assign_in_user(&p32->timestamp.tv_nsec, &p64->timestamp.tv_nsec) ||
+           assign_in_user(&p32->id, &p64->id) ||
+           copy_in_user(p32->reserved, p64->reserved, sizeof(p32->reserved)))
+               return -EFAULT;
+       return 0;
+}
+#endif
+
 struct v4l2_edid32 {
        __u32 pad;
        __u32 start_block;
@@ -1108,10 +1385,13 @@ static int put_v4l2_edid32(struct v4l2_edid __user *p64,
 #define VIDIOC_G_FMT32         _IOWR('V',  4, struct v4l2_format32)
 #define VIDIOC_S_FMT32         _IOWR('V',  5, struct v4l2_format32)
 #define VIDIOC_QUERYBUF32      _IOWR('V',  9, struct v4l2_buffer32)
+#define VIDIOC_QUERYBUF32_TIME32 _IOWR('V',  9, struct v4l2_buffer32_time32)
 #define VIDIOC_G_FBUF32                _IOR ('V', 10, struct v4l2_framebuffer32)
 #define VIDIOC_S_FBUF32                _IOW ('V', 11, struct v4l2_framebuffer32)
 #define VIDIOC_QBUF32          _IOWR('V', 15, struct v4l2_buffer32)
+#define VIDIOC_QBUF32_TIME32   _IOWR('V', 15, struct v4l2_buffer32_time32)
 #define VIDIOC_DQBUF32         _IOWR('V', 17, struct v4l2_buffer32)
+#define VIDIOC_DQBUF32_TIME32  _IOWR('V', 17, struct v4l2_buffer32_time32)
 #define VIDIOC_ENUMSTD32       _IOWR('V', 25, struct v4l2_standard32)
 #define VIDIOC_ENUMINPUT32     _IOWR('V', 26, struct v4l2_input32)
 #define VIDIOC_G_EDID32                _IOWR('V', 40, struct v4l2_edid32)
@@ -1121,8 +1401,10 @@ static int put_v4l2_edid32(struct v4l2_edid __user *p64,
 #define VIDIOC_S_EXT_CTRLS32    _IOWR('V', 72, struct v4l2_ext_controls32)
 #define VIDIOC_TRY_EXT_CTRLS32  _IOWR('V', 73, struct v4l2_ext_controls32)
 #define        VIDIOC_DQEVENT32        _IOR ('V', 89, struct v4l2_event32)
+#define        VIDIOC_DQEVENT32_TIME32 _IOR ('V', 89, struct v4l2_event32_time32)
 #define VIDIOC_CREATE_BUFS32   _IOWR('V', 92, struct v4l2_create_buffers32)
 #define VIDIOC_PREPARE_BUF32   _IOWR('V', 93, struct v4l2_buffer32)
+#define VIDIOC_PREPARE_BUF32_TIME32 _IOWR('V', 93, struct v4l2_buffer32_time32)
 
 #define VIDIOC_OVERLAY32       _IOW ('V', 14, s32)
 #define VIDIOC_STREAMON32      _IOW ('V', 18, s32)
@@ -1183,36 +1465,45 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
        u32 aux_space;
        int compatible_arg = 1;
        long err = 0;
+       unsigned int ncmd;
 
        /*
         * 1. When struct size is different, converts the command.
         */
        switch (cmd) {
-       case VIDIOC_G_FMT32: cmd = VIDIOC_G_FMT; break;
-       case VIDIOC_S_FMT32: cmd = VIDIOC_S_FMT; break;
-       case VIDIOC_QUERYBUF32: cmd = VIDIOC_QUERYBUF; break;
-       case VIDIOC_G_FBUF32: cmd = VIDIOC_G_FBUF; break;
-       case VIDIOC_S_FBUF32: cmd = VIDIOC_S_FBUF; break;
-       case VIDIOC_QBUF32: cmd = VIDIOC_QBUF; break;
-       case VIDIOC_DQBUF32: cmd = VIDIOC_DQBUF; break;
-       case VIDIOC_ENUMSTD32: cmd = VIDIOC_ENUMSTD; break;
-       case VIDIOC_ENUMINPUT32: cmd = VIDIOC_ENUMINPUT; break;
-       case VIDIOC_TRY_FMT32: cmd = VIDIOC_TRY_FMT; break;
-       case VIDIOC_G_EXT_CTRLS32: cmd = VIDIOC_G_EXT_CTRLS; break;
-       case VIDIOC_S_EXT_CTRLS32: cmd = VIDIOC_S_EXT_CTRLS; break;
-       case VIDIOC_TRY_EXT_CTRLS32: cmd = VIDIOC_TRY_EXT_CTRLS; break;
-       case VIDIOC_DQEVENT32: cmd = VIDIOC_DQEVENT; break;
-       case VIDIOC_OVERLAY32: cmd = VIDIOC_OVERLAY; break;
-       case VIDIOC_STREAMON32: cmd = VIDIOC_STREAMON; break;
-       case VIDIOC_STREAMOFF32: cmd = VIDIOC_STREAMOFF; break;
-       case VIDIOC_G_INPUT32: cmd = VIDIOC_G_INPUT; break;
-       case VIDIOC_S_INPUT32: cmd = VIDIOC_S_INPUT; break;
-       case VIDIOC_G_OUTPUT32: cmd = VIDIOC_G_OUTPUT; break;
-       case VIDIOC_S_OUTPUT32: cmd = VIDIOC_S_OUTPUT; break;
-       case VIDIOC_CREATE_BUFS32: cmd = VIDIOC_CREATE_BUFS; break;
-       case VIDIOC_PREPARE_BUF32: cmd = VIDIOC_PREPARE_BUF; break;
-       case VIDIOC_G_EDID32: cmd = VIDIOC_G_EDID; break;
-       case VIDIOC_S_EDID32: cmd = VIDIOC_S_EDID; break;
+       case VIDIOC_G_FMT32: ncmd = VIDIOC_G_FMT; break;
+       case VIDIOC_S_FMT32: ncmd = VIDIOC_S_FMT; break;
+       case VIDIOC_QUERYBUF32: ncmd = VIDIOC_QUERYBUF; break;
+       case VIDIOC_QUERYBUF32_TIME32: ncmd = VIDIOC_QUERYBUF_TIME32; break;
+       case VIDIOC_G_FBUF32: ncmd = VIDIOC_G_FBUF; break;
+       case VIDIOC_S_FBUF32: ncmd = VIDIOC_S_FBUF; break;
+       case VIDIOC_QBUF32: ncmd = VIDIOC_QBUF; break;
+       case VIDIOC_QBUF32_TIME32: ncmd = VIDIOC_QBUF_TIME32; break;
+       case VIDIOC_DQBUF32: ncmd = VIDIOC_DQBUF; break;
+       case VIDIOC_DQBUF32_TIME32: ncmd = VIDIOC_DQBUF_TIME32; break;
+       case VIDIOC_ENUMSTD32: ncmd = VIDIOC_ENUMSTD; break;
+       case VIDIOC_ENUMINPUT32: ncmd = VIDIOC_ENUMINPUT; break;
+       case VIDIOC_TRY_FMT32: ncmd = VIDIOC_TRY_FMT; break;
+       case VIDIOC_G_EXT_CTRLS32: ncmd = VIDIOC_G_EXT_CTRLS; break;
+       case VIDIOC_S_EXT_CTRLS32: ncmd = VIDIOC_S_EXT_CTRLS; break;
+       case VIDIOC_TRY_EXT_CTRLS32: ncmd = VIDIOC_TRY_EXT_CTRLS; break;
+#ifdef CONFIG_X86_64
+       case VIDIOC_DQEVENT32: ncmd = VIDIOC_DQEVENT; break;
+       case VIDIOC_DQEVENT32_TIME32: ncmd = VIDIOC_DQEVENT_TIME32; break;
+#endif
+       case VIDIOC_OVERLAY32: ncmd = VIDIOC_OVERLAY; break;
+       case VIDIOC_STREAMON32: ncmd = VIDIOC_STREAMON; break;
+       case VIDIOC_STREAMOFF32: ncmd = VIDIOC_STREAMOFF; break;
+       case VIDIOC_G_INPUT32: ncmd = VIDIOC_G_INPUT; break;
+       case VIDIOC_S_INPUT32: ncmd = VIDIOC_S_INPUT; break;
+       case VIDIOC_G_OUTPUT32: ncmd = VIDIOC_G_OUTPUT; break;
+       case VIDIOC_S_OUTPUT32: ncmd = VIDIOC_S_OUTPUT; break;
+       case VIDIOC_CREATE_BUFS32: ncmd = VIDIOC_CREATE_BUFS; break;
+       case VIDIOC_PREPARE_BUF32: ncmd = VIDIOC_PREPARE_BUF; break;
+       case VIDIOC_PREPARE_BUF32_TIME32: ncmd = VIDIOC_PREPARE_BUF_TIME32; break;
+       case VIDIOC_G_EDID32: ncmd = VIDIOC_G_EDID; break;
+       case VIDIOC_S_EDID32: ncmd = VIDIOC_S_EDID; break;
+       default: ncmd = cmd; break;
        }
 
        /*
@@ -1221,11 +1512,11 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
         * argument into it.
         */
        switch (cmd) {
-       case VIDIOC_OVERLAY:
-       case VIDIOC_STREAMON:
-       case VIDIOC_STREAMOFF:
-       case VIDIOC_S_INPUT:
-       case VIDIOC_S_OUTPUT:
+       case VIDIOC_OVERLAY32:
+       case VIDIOC_STREAMON32:
+       case VIDIOC_STREAMOFF32:
+       case VIDIOC_S_INPUT32:
+       case VIDIOC_S_OUTPUT32:
                err = alloc_userspace(sizeof(unsigned int), 0, &new_p64);
                if (!err && assign_in_user((unsigned int __user *)new_p64,
                                           (compat_uint_t __user *)p32))
@@ -1233,23 +1524,23 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
                compatible_arg = 0;
                break;
 
-       case VIDIOC_G_INPUT:
-       case VIDIOC_G_OUTPUT:
+       case VIDIOC_G_INPUT32:
+       case VIDIOC_G_OUTPUT32:
                err = alloc_userspace(sizeof(unsigned int), 0, &new_p64);
                compatible_arg = 0;
                break;
 
-       case VIDIOC_G_EDID:
-       case VIDIOC_S_EDID:
+       case VIDIOC_G_EDID32:
+       case VIDIOC_S_EDID32:
                err = alloc_userspace(sizeof(struct v4l2_edid), 0, &new_p64);
                if (!err)
                        err = get_v4l2_edid32(new_p64, p32);
                compatible_arg = 0;
                break;
 
-       case VIDIOC_G_FMT:
-       case VIDIOC_S_FMT:
-       case VIDIOC_TRY_FMT:
+       case VIDIOC_G_FMT32:
+       case VIDIOC_S_FMT32:
+       case VIDIOC_TRY_FMT32:
                err = bufsize_v4l2_format(p32, &aux_space);
                if (!err)
                        err = alloc_userspace(sizeof(struct v4l2_format),
@@ -1262,7 +1553,7 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
                compatible_arg = 0;
                break;
 
-       case VIDIOC_CREATE_BUFS:
+       case VIDIOC_CREATE_BUFS32:
                err = bufsize_v4l2_create(p32, &aux_space);
                if (!err)
                        err = alloc_userspace(sizeof(struct v4l2_create_buffers),
@@ -1275,10 +1566,10 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
                compatible_arg = 0;
                break;
 
-       case VIDIOC_PREPARE_BUF:
-       case VIDIOC_QUERYBUF:
-       case VIDIOC_QBUF:
-       case VIDIOC_DQBUF:
+       case VIDIOC_PREPARE_BUF32:
+       case VIDIOC_QUERYBUF32:
+       case VIDIOC_QBUF32:
+       case VIDIOC_DQBUF32:
                err = bufsize_v4l2_buffer(p32, &aux_space);
                if (!err)
                        err = alloc_userspace(sizeof(struct v4l2_buffer),
@@ -1291,7 +1582,23 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
                compatible_arg = 0;
                break;
 
-       case VIDIOC_S_FBUF:
+       case VIDIOC_PREPARE_BUF32_TIME32:
+       case VIDIOC_QUERYBUF32_TIME32:
+       case VIDIOC_QBUF32_TIME32:
+       case VIDIOC_DQBUF32_TIME32:
+               err = bufsize_v4l2_buffer_time32(p32, &aux_space);
+               if (!err)
+                       err = alloc_userspace(sizeof(struct v4l2_buffer),
+                                             aux_space, &new_p64);
+               if (!err) {
+                       aux_buf = new_p64 + sizeof(struct v4l2_buffer);
+                       err = get_v4l2_buffer32_time32(new_p64, p32,
+                                                      aux_buf, aux_space);
+               }
+               compatible_arg = 0;
+               break;
+
+       case VIDIOC_S_FBUF32:
                err = alloc_userspace(sizeof(struct v4l2_framebuffer), 0,
                                      &new_p64);
                if (!err)
@@ -1299,13 +1606,13 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
                compatible_arg = 0;
                break;
 
-       case VIDIOC_G_FBUF:
+       case VIDIOC_G_FBUF32:
                err = alloc_userspace(sizeof(struct v4l2_framebuffer), 0,
                                      &new_p64);
                compatible_arg = 0;
                break;
 
-       case VIDIOC_ENUMSTD:
+       case VIDIOC_ENUMSTD32:
                err = alloc_userspace(sizeof(struct v4l2_standard), 0,
                                      &new_p64);
                if (!err)
@@ -1313,16 +1620,16 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
                compatible_arg = 0;
                break;
 
-       case VIDIOC_ENUMINPUT:
+       case VIDIOC_ENUMINPUT32:
                err = alloc_userspace(sizeof(struct v4l2_input), 0, &new_p64);
                if (!err)
                        err = get_v4l2_input32(new_p64, p32);
                compatible_arg = 0;
                break;
 
-       case VIDIOC_G_EXT_CTRLS:
-       case VIDIOC_S_EXT_CTRLS:
-       case VIDIOC_TRY_EXT_CTRLS:
+       case VIDIOC_G_EXT_CTRLS32:
+       case VIDIOC_S_EXT_CTRLS32:
+       case VIDIOC_TRY_EXT_CTRLS32:
                err = bufsize_v4l2_ext_controls(p32, &aux_space);
                if (!err)
                        err = alloc_userspace(sizeof(struct v4l2_ext_controls),
@@ -1334,10 +1641,16 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
                }
                compatible_arg = 0;
                break;
-       case VIDIOC_DQEVENT:
+#ifdef CONFIG_X86_64
+       case VIDIOC_DQEVENT32:
                err = alloc_userspace(sizeof(struct v4l2_event), 0, &new_p64);
                compatible_arg = 0;
                break;
+       case VIDIOC_DQEVENT32_TIME32:
+               err = alloc_userspace(sizeof(struct v4l2_event_time32), 0, &new_p64);
+               compatible_arg = 0;
+               break;
+#endif
        }
        if (err)
                return err;
@@ -1352,9 +1665,9 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
         * Otherwise, it will pass the newly allocated @new_p64 argument.
         */
        if (compatible_arg)
-               err = native_ioctl(file, cmd, (unsigned long)p32);
+               err = native_ioctl(file, ncmd, (unsigned long)p32);
        else
-               err = native_ioctl(file, cmd, (unsigned long)new_p64);
+               err = native_ioctl(file, ncmd, (unsigned long)new_p64);
 
        if (err == -ENOTTY)
                return err;
@@ -1370,13 +1683,13 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
         * the blocks to maximum allowed value.
         */
        switch (cmd) {
-       case VIDIOC_G_EXT_CTRLS:
-       case VIDIOC_S_EXT_CTRLS:
-       case VIDIOC_TRY_EXT_CTRLS:
+       case VIDIOC_G_EXT_CTRLS32:
+       case VIDIOC_S_EXT_CTRLS32:
+       case VIDIOC_TRY_EXT_CTRLS32:
                if (put_v4l2_ext_controls32(file, new_p64, p32))
                        err = -EFAULT;
                break;
-       case VIDIOC_S_EDID:
+       case VIDIOC_S_EDID32:
                if (put_v4l2_edid32(new_p64, p32))
                        err = -EFAULT;
                break;
@@ -1389,49 +1702,62 @@ static long do_video_ioctl(struct file *file, unsigned int cmd, unsigned long ar
         * the original 32 bits structure.
         */
        switch (cmd) {
-       case VIDIOC_S_INPUT:
-       case VIDIOC_S_OUTPUT:
-       case VIDIOC_G_INPUT:
-       case VIDIOC_G_OUTPUT:
+       case VIDIOC_S_INPUT32:
+       case VIDIOC_S_OUTPUT32:
+       case VIDIOC_G_INPUT32:
+       case VIDIOC_G_OUTPUT32:
                if (assign_in_user((compat_uint_t __user *)p32,
                                   ((unsigned int __user *)new_p64)))
                        err = -EFAULT;
                break;
 
-       case VIDIOC_G_FBUF:
+       case VIDIOC_G_FBUF32:
                err = put_v4l2_framebuffer32(new_p64, p32);
                break;
 
-       case VIDIOC_DQEVENT:
+#ifdef CONFIG_X86_64
+       case VIDIOC_DQEVENT32:
                err = put_v4l2_event32(new_p64, p32);
                break;
 
-       case VIDIOC_G_EDID:
+       case VIDIOC_DQEVENT32_TIME32:
+               err = put_v4l2_event32_time32(new_p64, p32);
+               break;
+#endif
+
+       case VIDIOC_G_EDID32:
                err = put_v4l2_edid32(new_p64, p32);
                break;
 
-       case VIDIOC_G_FMT:
-       case VIDIOC_S_FMT:
-       case VIDIOC_TRY_FMT:
+       case VIDIOC_G_FMT32:
+       case VIDIOC_S_FMT32:
+       case VIDIOC_TRY_FMT32:
                err = put_v4l2_format32(new_p64, p32);
                break;
 
-       case VIDIOC_CREATE_BUFS:
+       case VIDIOC_CREATE_BUFS32:
                err = put_v4l2_create32(new_p64, p32);
                break;
 
-       case VIDIOC_PREPARE_BUF:
-       case VIDIOC_QUERYBUF:
-       case VIDIOC_QBUF:
-       case VIDIOC_DQBUF:
+       case VIDIOC_PREPARE_BUF32:
+       case VIDIOC_QUERYBUF32:
+       case VIDIOC_QBUF32:
+       case VIDIOC_DQBUF32:
                err = put_v4l2_buffer32(new_p64, p32);
                break;
 
-       case VIDIOC_ENUMSTD:
+       case VIDIOC_PREPARE_BUF32_TIME32:
+       case VIDIOC_QUERYBUF32_TIME32:
+       case VIDIOC_QBUF32_TIME32:
+       case VIDIOC_DQBUF32_TIME32:
+               err = put_v4l2_buffer32_time32(new_p64, p32);
+               break;
+
+       case VIDIOC_ENUMSTD32:
                err = put_v4l2_standard32(new_p64, p32);
                break;
 
-       case VIDIOC_ENUMINPUT:
+       case VIDIOC_ENUMINPUT32:
                err = put_v4l2_input32(new_p64, p32);
                break;
        }