drivers: Remove explicit invocations of mmiowb()

[linux.git] / drivers / net / ethernet / renesas / sh_eth.c

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 339b2eae21006d1983c45ae38042093279e5001a..ed30aebdb941a02e2136b89997ea5727613fd4de 100644 (file)
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -2010,7 +2010,6 @@ static void sh_eth_adjust_link(struct net_device *ndev)
        if ((mdp->cd->no_psr || mdp->no_ether_link) && phydev->link)
                sh_eth_rcv_snd_enable(ndev);
 
-       mmiowb();
        spin_unlock_irqrestore(&mdp->lock, flags);
 
        if (new_state && netif_msg_link(mdp))
@@ -3181,12 +3180,16 @@ static struct sh_eth_plat_data *sh_eth_parse_dt(struct device *dev)
        struct device_node *np = dev->of_node;
        struct sh_eth_plat_data *pdata;
        const char *mac_addr;
+       int ret;
 
        pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
        if (!pdata)
                return NULL;
 
-       pdata->phy_interface = of_get_phy_mode(np);
+       ret = of_get_phy_mode(np);
+       if (ret < 0)
+               return NULL;
+       pdata->phy_interface = ret;
 
        mac_addr = of_get_mac_address(np);
        if (mac_addr)