]> asedeno.scripts.mit.edu Git - linux.git/blobdiff - drivers/pinctrl/pinctrl-ingenic.c
csky: Enable defer flush_dcache_page for abiv2 cpus (807/810/860)
[linux.git] / drivers / pinctrl / pinctrl-ingenic.c
index 369e04350e3dec7b29309e1b6b4deb64ef7bea9e..96f04d121ebd01db1c95a8f8d553151427e7c6e8 100644 (file)
@@ -3,7 +3,7 @@
  * Ingenic SoCs pinctrl driver
  *
  * Copyright (c) 2017 Paul Cercueil <paul@crapouillou.net>
- * Copyright (c) 2019 Zhou Yanjie <zhouyanjie@zoho.com>
+ * Copyright (c) 2019 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
  */
 
 #include <linux/compiler.h>
 #define JZ4760_GPIO_FLAG       0x50
 #define JZ4760_GPIO_PEN                0x70
 
-#define X1000_GPIO_PZ_BASE             0x700
-#define X1000_GPIO_PZ_GID2LD   0x7f0
+#define X1830_GPIO_PEL                 0x110
+#define X1830_GPIO_PEH                 0x120
 
 #define REG_SET(x) ((x) + 0x4)
 #define REG_CLEAR(x) ((x) + 0x8)
 
+#define REG_PZ_BASE(x) ((x) * 7)
+#define REG_PZ_GID2LD(x) ((x) * 7 + 0xf0)
+
+#define GPIO_PULL_DIS  0
+#define GPIO_PULL_UP   1
+#define GPIO_PULL_DOWN 2
+
 #define PINS_PER_GPIO_CHIP 32
 
 enum jz_version {
        ID_JZ4740,
        ID_JZ4725B,
        ID_JZ4760,
-       ID_JZ4760B,
        ID_JZ4770,
        ID_JZ4780,
        ID_X1000,
-       ID_X1000E,
        ID_X1500,
+       ID_X1830,
 };
 
 struct ingenic_chip_info {
        unsigned int num_chips;
+       unsigned int reg_offset;
+       enum jz_version version;
 
        const struct group_desc *groups;
        unsigned int num_groups;
@@ -79,7 +87,6 @@ struct ingenic_pinctrl {
        struct regmap *map;
        struct pinctrl_dev *pctl;
        struct pinctrl_pin_desc *pdesc;
-       enum jz_version version;
 
        const struct ingenic_chip_info *info;
 };
@@ -216,6 +223,8 @@ static const struct function_desc jz4740_functions[] = {
 
 static const struct ingenic_chip_info jz4740_chip_info = {
        .num_chips = 4,
+       .reg_offset = 0x100,
+       .version = ID_JZ4740,
        .groups = jz4740_groups,
        .num_groups = ARRAY_SIZE(jz4740_groups),
        .functions = jz4740_functions,
@@ -339,6 +348,8 @@ static const struct function_desc jz4725b_functions[] = {
 
 static const struct ingenic_chip_info jz4725b_chip_info = {
        .num_chips = 4,
+       .reg_offset = 0x100,
+       .version = ID_JZ4725B,
        .groups = jz4725b_groups,
        .num_groups = ARRAY_SIZE(jz4725b_groups),
        .functions = jz4725b_functions,
@@ -592,16 +603,8 @@ static const struct function_desc jz4760_functions[] = {
 
 static const struct ingenic_chip_info jz4760_chip_info = {
        .num_chips = 6,
-       .groups = jz4760_groups,
-       .num_groups = ARRAY_SIZE(jz4760_groups),
-       .functions = jz4760_functions,
-       .num_functions = ARRAY_SIZE(jz4760_functions),
-       .pull_ups = jz4760_pull_ups,
-       .pull_downs = jz4760_pull_downs,
-};
-
-static const struct ingenic_chip_info jz4760b_chip_info = {
-       .num_chips = 6,
+       .reg_offset = 0x100,
+       .version = ID_JZ4760,
        .groups = jz4760_groups,
        .num_groups = ARRAY_SIZE(jz4760_groups),
        .functions = jz4760_functions,
@@ -880,6 +883,8 @@ static const struct function_desc jz4770_functions[] = {
 
 static const struct ingenic_chip_info jz4770_chip_info = {
        .num_chips = 6,
+       .reg_offset = 0x100,
+       .version = ID_JZ4770,
        .groups = jz4770_groups,
        .num_groups = ARRAY_SIZE(jz4770_groups),
        .functions = jz4770_functions,
@@ -1013,6 +1018,8 @@ static const struct function_desc jz4780_functions[] = {
 
 static const struct ingenic_chip_info jz4780_chip_info = {
        .num_chips = 6,
+       .reg_offset = 0x100,
+       .version = ID_JZ4780,
        .groups = jz4780_groups,
        .num_groups = ARRAY_SIZE(jz4780_groups),
        .functions = jz4780_functions,
@@ -1022,7 +1029,7 @@ static const struct ingenic_chip_info jz4780_chip_info = {
 };
 
 static const u32 x1000_pull_ups[4] = {
-       0xffffffff, 0x8dffffff, 0x7d3fffff, 0xffffffff,
+       0xffffffff, 0xfdffffff, 0x0dffffff, 0x0000003f,
 };
 
 static const u32 x1000_pull_downs[4] = {
@@ -1033,28 +1040,45 @@ static int x1000_uart0_data_pins[] = { 0x4a, 0x4b, };
 static int x1000_uart0_hwflow_pins[] = { 0x4c, 0x4d, };
 static int x1000_uart1_data_a_pins[] = { 0x04, 0x05, };
 static int x1000_uart1_data_d_pins[] = { 0x62, 0x63, };
-static int x1000_uart1_hwflow_d_pins[] = { 0x64, 0x65, };
+static int x1000_uart1_hwflow_pins[] = { 0x64, 0x65, };
 static int x1000_uart2_data_a_pins[] = { 0x02, 0x03, };
 static int x1000_uart2_data_d_pins[] = { 0x65, 0x64, };
+static int x1000_sfc_pins[] = { 0x1d, 0x1c, 0x1e, 0x1f, 0x1a, 0x1b, };
+static int x1000_ssi_dt_a_22_pins[] = { 0x16, };
+static int x1000_ssi_dt_a_29_pins[] = { 0x1d, };
+static int x1000_ssi_dt_d_pins[] = { 0x62, };
+static int x1000_ssi_dr_a_23_pins[] = { 0x17, };
+static int x1000_ssi_dr_a_28_pins[] = { 0x1c, };
+static int x1000_ssi_dr_d_pins[] = { 0x63, };
+static int x1000_ssi_clk_a_24_pins[] = { 0x18, };
+static int x1000_ssi_clk_a_26_pins[] = { 0x1a, };
+static int x1000_ssi_clk_d_pins[] = { 0x60, };
+static int x1000_ssi_gpc_a_20_pins[] = { 0x14, };
+static int x1000_ssi_gpc_a_31_pins[] = { 0x1f, };
+static int x1000_ssi_ce0_a_25_pins[] = { 0x19, };
+static int x1000_ssi_ce0_a_27_pins[] = { 0x1b, };
+static int x1000_ssi_ce0_d_pins[] = { 0x61, };
+static int x1000_ssi_ce1_a_21_pins[] = { 0x15, };
+static int x1000_ssi_ce1_a_30_pins[] = { 0x1e, };
 static int x1000_mmc0_1bit_pins[] = { 0x18, 0x19, 0x17, };
 static int x1000_mmc0_4bit_pins[] = { 0x16, 0x15, 0x14, };
 static int x1000_mmc0_8bit_pins[] = { 0x13, 0x12, 0x11, 0x10, };
 static int x1000_mmc1_1bit_pins[] = { 0x40, 0x41, 0x42, };
 static int x1000_mmc1_4bit_pins[] = { 0x43, 0x44, 0x45, };
-static int x1000_nemc_8bit_data_pins[] = {
+static int x1000_emc_8bit_data_pins[] = {
        0x00, 0x01, 0x02, 0x03, 0x04, 0x05, 0x06, 0x07,
 };
-static int x1000_nemc_16bit_data_pins[] = {
+static int x1000_emc_16bit_data_pins[] = {
        0x08, 0x09, 0x0a, 0x0b, 0x0c, 0x0d, 0x0e, 0x0f,
 };
-static int x1000_nemc_addr_pins[] = {
+static int x1000_emc_addr_pins[] = {
        0x20, 0x21, 0x22, 0x23, 0x24, 0x25, 0x26, 0x27,
        0x28, 0x29, 0x2a, 0x2b, 0x2c, 0x2d, 0x2e, 0x2f,
 };
-static int x1000_nemc_rd_we_pins[] = { 0x30, 0x31, };
-static int x1000_nemc_wait_pins[] = { 0x34, };
-static int x1000_nemc_cs1_pins[] = { 0x32, };
-static int x1000_nemc_cs2_pins[] = { 0x33, };
+static int x1000_emc_rd_we_pins[] = { 0x30, 0x31, };
+static int x1000_emc_wait_pins[] = { 0x34, };
+static int x1000_emc_cs1_pins[] = { 0x32, };
+static int x1000_emc_cs2_pins[] = { 0x33, };
 static int x1000_i2c0_pins[] = { 0x38, 0x37, };
 static int x1000_i2c1_a_pins[] = { 0x01, 0x00, };
 static int x1000_i2c1_c_pins[] = { 0x5b, 0x5a, };
@@ -1083,23 +1107,40 @@ static int x1000_uart0_data_funcs[] = { 0, 0, };
 static int x1000_uart0_hwflow_funcs[] = { 0, 0, };
 static int x1000_uart1_data_a_funcs[] = { 2, 2, };
 static int x1000_uart1_data_d_funcs[] = { 1, 1, };
-static int x1000_uart1_hwflow_d_funcs[] = { 1, 1, };
+static int x1000_uart1_hwflow_funcs[] = { 1, 1, };
 static int x1000_uart2_data_a_funcs[] = { 2, 2, };
 static int x1000_uart2_data_d_funcs[] = { 0, 0, };
+static int x1000_sfc_funcs[] = { 1, 1, 1, 1, 1, 1, };
+static int x1000_ssi_dt_a_22_funcs[] = { 2, };
+static int x1000_ssi_dt_a_29_funcs[] = { 2, };
+static int x1000_ssi_dt_d_funcs[] = { 0, };
+static int x1000_ssi_dr_a_23_funcs[] = { 2, };
+static int x1000_ssi_dr_a_28_funcs[] = { 2, };
+static int x1000_ssi_dr_d_funcs[] = { 0, };
+static int x1000_ssi_clk_a_24_funcs[] = { 2, };
+static int x1000_ssi_clk_a_26_funcs[] = { 2, };
+static int x1000_ssi_clk_d_funcs[] = { 0, };
+static int x1000_ssi_gpc_a_20_funcs[] = { 2, };
+static int x1000_ssi_gpc_a_31_funcs[] = { 2, };
+static int x1000_ssi_ce0_a_25_funcs[] = { 2, };
+static int x1000_ssi_ce0_a_27_funcs[] = { 2, };
+static int x1000_ssi_ce0_d_funcs[] = { 0, };
+static int x1000_ssi_ce1_a_21_funcs[] = { 2, };
+static int x1000_ssi_ce1_a_30_funcs[] = { 2, };
 static int x1000_mmc0_1bit_funcs[] = { 1, 1, 1, };
 static int x1000_mmc0_4bit_funcs[] = { 1, 1, 1, };
 static int x1000_mmc0_8bit_funcs[] = { 1, 1, 1, 1, 1, };
 static int x1000_mmc1_1bit_funcs[] = { 0, 0, 0, };
 static int x1000_mmc1_4bit_funcs[] = { 0, 0, 0, };
-static int x1000_nemc_8bit_data_funcs[] = { 0, 0, 0, 0, 0, 0, 0, 0, };
-static int x1000_nemc_16bit_data_funcs[] = { 0, 0, 0, 0, 0, 0, 0, 0, };
-static int x1000_nemc_addr_funcs[] = {
+static int x1000_emc_8bit_data_funcs[] = { 0, 0, 0, 0, 0, 0, 0, 0, };
+static int x1000_emc_16bit_data_funcs[] = { 0, 0, 0, 0, 0, 0, 0, 0, };
+static int x1000_emc_addr_funcs[] = {
        0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
 };
-static int x1000_nemc_rd_we_funcs[] = { 0, 0, };
-static int x1000_nemc_wait_funcs[] = { 0, };
-static int x1000_nemc_cs1_funcs[] = { 0, };
-static int x1000_nemc_cs2_funcs[] = { 0, };
+static int x1000_emc_rd_we_funcs[] = { 0, 0, };
+static int x1000_emc_wait_funcs[] = { 0, };
+static int x1000_emc_cs1_funcs[] = { 0, };
+static int x1000_emc_cs2_funcs[] = { 0, };
 static int x1000_i2c0_funcs[] = { 0, 0, };
 static int x1000_i2c1_a_funcs[] = { 2, 2, };
 static int x1000_i2c1_c_funcs[] = { 0, 0, };
@@ -1121,21 +1162,38 @@ static const struct group_desc x1000_groups[] = {
        INGENIC_PIN_GROUP("uart0-hwflow", x1000_uart0_hwflow),
        INGENIC_PIN_GROUP("uart1-data-a", x1000_uart1_data_a),
        INGENIC_PIN_GROUP("uart1-data-d", x1000_uart1_data_d),
-       INGENIC_PIN_GROUP("uart1-hwflow-d", x1000_uart1_hwflow_d),
+       INGENIC_PIN_GROUP("uart1-hwflow", x1000_uart1_hwflow),
        INGENIC_PIN_GROUP("uart2-data-a", x1000_uart2_data_a),
        INGENIC_PIN_GROUP("uart2-data-d", x1000_uart2_data_d),
+       INGENIC_PIN_GROUP("sfc", x1000_sfc),
+       INGENIC_PIN_GROUP("ssi-dt-a-22", x1000_ssi_dt_a_22),
+       INGENIC_PIN_GROUP("ssi-dt-a-29", x1000_ssi_dt_a_29),
+       INGENIC_PIN_GROUP("ssi-dt-d", x1000_ssi_dt_d),
+       INGENIC_PIN_GROUP("ssi-dr-a-23", x1000_ssi_dr_a_23),
+       INGENIC_PIN_GROUP("ssi-dr-a-28", x1000_ssi_dr_a_28),
+       INGENIC_PIN_GROUP("ssi-dr-d", x1000_ssi_dr_d),
+       INGENIC_PIN_GROUP("ssi-clk-a-24", x1000_ssi_clk_a_24),
+       INGENIC_PIN_GROUP("ssi-clk-a-26", x1000_ssi_clk_a_26),
+       INGENIC_PIN_GROUP("ssi-clk-d", x1000_ssi_clk_d),
+       INGENIC_PIN_GROUP("ssi-gpc-a-20", x1000_ssi_gpc_a_20),
+       INGENIC_PIN_GROUP("ssi-gpc-a-31", x1000_ssi_gpc_a_31),
+       INGENIC_PIN_GROUP("ssi-ce0-a-25", x1000_ssi_ce0_a_25),
+       INGENIC_PIN_GROUP("ssi-ce0-a-27", x1000_ssi_ce0_a_27),
+       INGENIC_PIN_GROUP("ssi-ce0-d", x1000_ssi_ce0_d),
+       INGENIC_PIN_GROUP("ssi-ce1-a-21", x1000_ssi_ce1_a_21),
+       INGENIC_PIN_GROUP("ssi-ce1-a-30", x1000_ssi_ce1_a_30),
        INGENIC_PIN_GROUP("mmc0-1bit", x1000_mmc0_1bit),
        INGENIC_PIN_GROUP("mmc0-4bit", x1000_mmc0_4bit),
        INGENIC_PIN_GROUP("mmc0-8bit", x1000_mmc0_8bit),
        INGENIC_PIN_GROUP("mmc1-1bit", x1000_mmc1_1bit),
        INGENIC_PIN_GROUP("mmc1-4bit", x1000_mmc1_4bit),
-       INGENIC_PIN_GROUP("nemc-8bit-data", x1000_nemc_8bit_data),
-       INGENIC_PIN_GROUP("nemc-16bit-data", x1000_nemc_16bit_data),
-       INGENIC_PIN_GROUP("nemc-addr", x1000_nemc_addr),
-       INGENIC_PIN_GROUP("nemc-rd-we", x1000_nemc_rd_we),
-       INGENIC_PIN_GROUP("nemc-wait", x1000_nemc_wait),
-       INGENIC_PIN_GROUP("nemc-cs1", x1000_nemc_cs1),
-       INGENIC_PIN_GROUP("nemc-cs2", x1000_nemc_cs2),
+       INGENIC_PIN_GROUP("emc-8bit-data", x1000_emc_8bit_data),
+       INGENIC_PIN_GROUP("emc-16bit-data", x1000_emc_16bit_data),
+       INGENIC_PIN_GROUP("emc-addr", x1000_emc_addr),
+       INGENIC_PIN_GROUP("emc-rd-we", x1000_emc_rd_we),
+       INGENIC_PIN_GROUP("emc-wait", x1000_emc_wait),
+       INGENIC_PIN_GROUP("emc-cs1", x1000_emc_cs1),
+       INGENIC_PIN_GROUP("emc-cs2", x1000_emc_cs2),
        INGENIC_PIN_GROUP("i2c0-data", x1000_i2c0),
        INGENIC_PIN_GROUP("i2c1-data-a", x1000_i2c1_a),
        INGENIC_PIN_GROUP("i2c1-data-c", x1000_i2c1_c),
@@ -1154,21 +1212,30 @@ static const struct group_desc x1000_groups[] = {
 
 static const char *x1000_uart0_groups[] = { "uart0-data", "uart0-hwflow", };
 static const char *x1000_uart1_groups[] = {
-       "uart1-data-a", "uart1-data-d", "uart1-hwflow-d",
+       "uart1-data-a", "uart1-data-d", "uart1-hwflow",
 };
 static const char *x1000_uart2_groups[] = { "uart2-data-a", "uart2-data-d", };
+static const char *x1000_sfc_groups[] = { "sfc", };
+static const char *x1000_ssi_groups[] = {
+       "ssi-dt-a-22", "ssi-dt-a-29", "ssi-dt-d",
+       "ssi-dr-a-23", "ssi-dr-a-28", "ssi-dr-d",
+       "ssi-clk-a-24", "ssi-clk-a-26", "ssi-clk-d",
+       "ssi-gpc-a-20", "ssi-gpc-a-31",
+       "ssi-ce0-a-25", "ssi-ce0-a-27", "ssi-ce0-d",
+       "ssi-ce1-a-21", "ssi-ce1-a-30",
+};
 static const char *x1000_mmc0_groups[] = {
        "mmc0-1bit", "mmc0-4bit", "mmc0-8bit",
 };
 static const char *x1000_mmc1_groups[] = {
-       "mmc1-1bit-e", "mmc1-4bit-e",
+       "mmc1-1bit", "mmc1-4bit",
 };
-static const char *x1000_nemc_groups[] = {
-       "nemc-8bit-data", "nemc-16bit-data",
-       "nemc-addr", "nemc-rd-we", "nemc-wait",
+static const char *x1000_emc_groups[] = {
+       "emc-8bit-data", "emc-16bit-data",
+       "emc-addr", "emc-rd-we", "emc-wait",
 };
-static const char *x1000_cs1_groups[] = { "nemc-cs1", };
-static const char *x1000_cs2_groups[] = { "nemc-cs2", };
+static const char *x1000_cs1_groups[] = { "emc-cs1", };
+static const char *x1000_cs2_groups[] = { "emc-cs2", };
 static const char *x1000_i2c0_groups[] = { "i2c0-data", };
 static const char *x1000_i2c1_groups[] = { "i2c1-data-a", "i2c1-data-c", };
 static const char *x1000_i2c2_groups[] = { "i2c2-data", };
@@ -1187,11 +1254,13 @@ static const struct function_desc x1000_functions[] = {
        { "uart0", x1000_uart0_groups, ARRAY_SIZE(x1000_uart0_groups), },
        { "uart1", x1000_uart1_groups, ARRAY_SIZE(x1000_uart1_groups), },
        { "uart2", x1000_uart2_groups, ARRAY_SIZE(x1000_uart2_groups), },
+       { "sfc", x1000_sfc_groups, ARRAY_SIZE(x1000_sfc_groups), },
+       { "ssi", x1000_ssi_groups, ARRAY_SIZE(x1000_ssi_groups), },
        { "mmc0", x1000_mmc0_groups, ARRAY_SIZE(x1000_mmc0_groups), },
        { "mmc1", x1000_mmc1_groups, ARRAY_SIZE(x1000_mmc1_groups), },
-       { "nemc", x1000_nemc_groups, ARRAY_SIZE(x1000_nemc_groups), },
-       { "nemc-cs1", x1000_cs1_groups, ARRAY_SIZE(x1000_cs1_groups), },
-       { "nemc-cs2", x1000_cs2_groups, ARRAY_SIZE(x1000_cs2_groups), },
+       { "emc", x1000_emc_groups, ARRAY_SIZE(x1000_emc_groups), },
+       { "emc-cs1", x1000_cs1_groups, ARRAY_SIZE(x1000_cs1_groups), },
+       { "emc-cs2", x1000_cs2_groups, ARRAY_SIZE(x1000_cs2_groups), },
        { "i2c0", x1000_i2c0_groups, ARRAY_SIZE(x1000_i2c0_groups), },
        { "i2c1", x1000_i2c1_groups, ARRAY_SIZE(x1000_i2c1_groups), },
        { "i2c2", x1000_i2c2_groups, ARRAY_SIZE(x1000_i2c2_groups), },
@@ -1207,16 +1276,8 @@ static const struct function_desc x1000_functions[] = {
 
 static const struct ingenic_chip_info x1000_chip_info = {
        .num_chips = 4,
-       .groups = x1000_groups,
-       .num_groups = ARRAY_SIZE(x1000_groups),
-       .functions = x1000_functions,
-       .num_functions = ARRAY_SIZE(x1000_functions),
-       .pull_ups = x1000_pull_ups,
-       .pull_downs = x1000_pull_downs,
-};
-
-static const struct ingenic_chip_info x1000e_chip_info = {
-       .num_chips = 4,
+       .reg_offset = 0x100,
+       .version = ID_X1000,
        .groups = x1000_groups,
        .num_groups = ARRAY_SIZE(x1000_groups),
        .functions = x1000_functions,
@@ -1229,11 +1290,11 @@ static int x1500_uart0_data_pins[] = { 0x4a, 0x4b, };
 static int x1500_uart0_hwflow_pins[] = { 0x4c, 0x4d, };
 static int x1500_uart1_data_a_pins[] = { 0x04, 0x05, };
 static int x1500_uart1_data_d_pins[] = { 0x62, 0x63, };
-static int x1500_uart1_hwflow_d_pins[] = { 0x64, 0x65, };
+static int x1500_uart1_hwflow_pins[] = { 0x64, 0x65, };
 static int x1500_uart2_data_a_pins[] = { 0x02, 0x03, };
 static int x1500_uart2_data_d_pins[] = { 0x65, 0x64, };
-static int x1500_mmc0_1bit_pins[] = { 0x18, 0x19, 0x17, };
-static int x1500_mmc0_4bit_pins[] = { 0x16, 0x15, 0x14, };
+static int x1500_mmc_1bit_pins[] = { 0x18, 0x19, 0x17, };
+static int x1500_mmc_4bit_pins[] = { 0x16, 0x15, 0x14, };
 static int x1500_i2c0_pins[] = { 0x38, 0x37, };
 static int x1500_i2c1_a_pins[] = { 0x01, 0x00, };
 static int x1500_i2c1_c_pins[] = { 0x5b, 0x5a, };
@@ -1252,11 +1313,11 @@ static int x1500_uart0_data_funcs[] = { 0, 0, };
 static int x1500_uart0_hwflow_funcs[] = { 0, 0, };
 static int x1500_uart1_data_a_funcs[] = { 2, 2, };
 static int x1500_uart1_data_d_funcs[] = { 1, 1, };
-static int x1500_uart1_hwflow_d_funcs[] = { 1, 1, };
+static int x1500_uart1_hwflow_funcs[] = { 1, 1, };
 static int x1500_uart2_data_a_funcs[] = { 2, 2, };
 static int x1500_uart2_data_d_funcs[] = { 0, 0, };
-static int x1500_mmc0_1bit_funcs[] = { 1, 1, 1, };
-static int x1500_mmc0_4bit_funcs[] = { 1, 1, 1, };
+static int x1500_mmc_1bit_funcs[] = { 1, 1, 1, };
+static int x1500_mmc_4bit_funcs[] = { 1, 1, 1, };
 static int x1500_i2c0_funcs[] = { 0, 0, };
 static int x1500_i2c1_a_funcs[] = { 2, 2, };
 static int x1500_i2c1_c_funcs[] = { 0, 0, };
@@ -1273,11 +1334,12 @@ static const struct group_desc x1500_groups[] = {
        INGENIC_PIN_GROUP("uart0-hwflow", x1500_uart0_hwflow),
        INGENIC_PIN_GROUP("uart1-data-a", x1500_uart1_data_a),
        INGENIC_PIN_GROUP("uart1-data-d", x1500_uart1_data_d),
-       INGENIC_PIN_GROUP("uart1-hwflow-d", x1500_uart1_hwflow_d),
+       INGENIC_PIN_GROUP("uart1-hwflow", x1500_uart1_hwflow),
        INGENIC_PIN_GROUP("uart2-data-a", x1500_uart2_data_a),
        INGENIC_PIN_GROUP("uart2-data-d", x1500_uart2_data_d),
-       INGENIC_PIN_GROUP("mmc0-1bit", x1500_mmc0_1bit),
-       INGENIC_PIN_GROUP("mmc0-4bit", x1500_mmc0_4bit),
+       INGENIC_PIN_GROUP("sfc", x1000_sfc),
+       INGENIC_PIN_GROUP("mmc-1bit", x1500_mmc_1bit),
+       INGENIC_PIN_GROUP("mmc-4bit", x1500_mmc_4bit),
        INGENIC_PIN_GROUP("i2c0-data", x1500_i2c0),
        INGENIC_PIN_GROUP("i2c1-data-a", x1500_i2c1_a),
        INGENIC_PIN_GROUP("i2c1-data-c", x1500_i2c1_c),
@@ -1293,10 +1355,10 @@ static const struct group_desc x1500_groups[] = {
 
 static const char *x1500_uart0_groups[] = { "uart0-data", "uart0-hwflow", };
 static const char *x1500_uart1_groups[] = {
-       "uart1-data-a", "uart1-data-d", "uart1-hwflow-d",
+       "uart1-data-a", "uart1-data-d", "uart1-hwflow",
 };
 static const char *x1500_uart2_groups[] = { "uart2-data-a", "uart2-data-d", };
-static const char *x1500_mmc0_groups[] = { "mmc0-1bit", "mmc0-4bit", };
+static const char *x1500_mmc_groups[] = { "mmc-1bit", "mmc-4bit", };
 static const char *x1500_i2c0_groups[] = { "i2c0-data", };
 static const char *x1500_i2c1_groups[] = { "i2c1-data-a", "i2c1-data-c", };
 static const char *x1500_i2c2_groups[] = { "i2c2-data", };
@@ -1312,7 +1374,8 @@ static const struct function_desc x1500_functions[] = {
        { "uart0", x1500_uart0_groups, ARRAY_SIZE(x1500_uart0_groups), },
        { "uart1", x1500_uart1_groups, ARRAY_SIZE(x1500_uart1_groups), },
        { "uart2", x1500_uart2_groups, ARRAY_SIZE(x1500_uart2_groups), },
-       { "mmc0", x1500_mmc0_groups, ARRAY_SIZE(x1500_mmc0_groups), },
+       { "sfc", x1000_sfc_groups, ARRAY_SIZE(x1000_sfc_groups), },
+       { "mmc", x1500_mmc_groups, ARRAY_SIZE(x1500_mmc_groups), },
        { "i2c0", x1500_i2c0_groups, ARRAY_SIZE(x1500_i2c0_groups), },
        { "i2c1", x1500_i2c1_groups, ARRAY_SIZE(x1500_i2c1_groups), },
        { "i2c2", x1500_i2c2_groups, ARRAY_SIZE(x1500_i2c2_groups), },
@@ -1327,6 +1390,8 @@ static const struct function_desc x1500_functions[] = {
 
 static const struct ingenic_chip_info x1500_chip_info = {
        .num_chips = 4,
+       .reg_offset = 0x100,
+       .version = ID_X1500,
        .groups = x1500_groups,
        .num_groups = ARRAY_SIZE(x1500_groups),
        .functions = x1500_functions,
@@ -1335,6 +1400,222 @@ static const struct ingenic_chip_info x1500_chip_info = {
        .pull_downs = x1000_pull_downs,
 };
 
+static const u32 x1830_pull_ups[4] = {
+       0x5fdfffc0, 0xffffefff, 0x1ffffbff, 0x0fcff3fc,
+};
+
+static const u32 x1830_pull_downs[4] = {
+       0x5fdfffc0, 0xffffefff, 0x1ffffbff, 0x0fcff3fc,
+};
+
+static int x1830_uart0_data_pins[] = { 0x33, 0x36, };
+static int x1830_uart0_hwflow_pins[] = { 0x34, 0x35, };
+static int x1830_uart1_data_pins[] = { 0x38, 0x37, };
+static int x1830_sfc_pins[] = { 0x17, 0x18, 0x1a, 0x19, 0x1b, 0x1c, };
+static int x1830_ssi0_dt_pins[] = { 0x4c, };
+static int x1830_ssi0_dr_pins[] = { 0x4b, };
+static int x1830_ssi0_clk_pins[] = { 0x4f, };
+static int x1830_ssi0_gpc_pins[] = { 0x4d, };
+static int x1830_ssi0_ce0_pins[] = { 0x50, };
+static int x1830_ssi0_ce1_pins[] = { 0x4e, };
+static int x1830_ssi1_dt_c_pins[] = { 0x53, };
+static int x1830_ssi1_dr_c_pins[] = { 0x54, };
+static int x1830_ssi1_clk_c_pins[] = { 0x57, };
+static int x1830_ssi1_gpc_c_pins[] = { 0x55, };
+static int x1830_ssi1_ce0_c_pins[] = { 0x58, };
+static int x1830_ssi1_ce1_c_pins[] = { 0x56, };
+static int x1830_ssi1_dt_d_pins[] = { 0x62, };
+static int x1830_ssi1_dr_d_pins[] = { 0x63, };
+static int x1830_ssi1_clk_d_pins[] = { 0x66, };
+static int x1830_ssi1_gpc_d_pins[] = { 0x64, };
+static int x1830_ssi1_ce0_d_pins[] = { 0x67, };
+static int x1830_ssi1_ce1_d_pins[] = { 0x65, };
+static int x1830_mmc0_1bit_pins[] = { 0x24, 0x25, 0x20, };
+static int x1830_mmc0_4bit_pins[] = { 0x21, 0x22, 0x23, };
+static int x1830_mmc1_1bit_pins[] = { 0x42, 0x43, 0x44, };
+static int x1830_mmc1_4bit_pins[] = { 0x45, 0x46, 0x47, };
+static int x1830_i2c0_pins[] = { 0x0c, 0x0d, };
+static int x1830_i2c1_pins[] = { 0x39, 0x3a, };
+static int x1830_i2c2_pins[] = { 0x5b, 0x5c, };
+static int x1830_pwm_pwm0_b_pins[] = { 0x31, };
+static int x1830_pwm_pwm0_c_pins[] = { 0x4b, };
+static int x1830_pwm_pwm1_b_pins[] = { 0x32, };
+static int x1830_pwm_pwm1_c_pins[] = { 0x4c, };
+static int x1830_pwm_pwm2_c_8_pins[] = { 0x48, };
+static int x1830_pwm_pwm2_c_13_pins[] = { 0x4d, };
+static int x1830_pwm_pwm3_c_9_pins[] = { 0x49, };
+static int x1830_pwm_pwm3_c_14_pins[] = { 0x4e, };
+static int x1830_pwm_pwm4_c_15_pins[] = { 0x4f, };
+static int x1830_pwm_pwm4_c_25_pins[] = { 0x59, };
+static int x1830_pwm_pwm5_c_16_pins[] = { 0x50, };
+static int x1830_pwm_pwm5_c_26_pins[] = { 0x5a, };
+static int x1830_pwm_pwm6_c_17_pins[] = { 0x51, };
+static int x1830_pwm_pwm6_c_27_pins[] = { 0x5b, };
+static int x1830_pwm_pwm7_c_18_pins[] = { 0x52, };
+static int x1830_pwm_pwm7_c_28_pins[] = { 0x5c, };
+static int x1830_mac_pins[] = {
+       0x29, 0x30, 0x2f, 0x28, 0x2e, 0x2d, 0x2a, 0x2b, 0x26, 0x27,
+};
+
+static int x1830_uart0_data_funcs[] = { 0, 0, };
+static int x1830_uart0_hwflow_funcs[] = { 0, 0, };
+static int x1830_uart1_data_funcs[] = { 0, 0, };
+static int x1830_sfc_funcs[] = { 1, 1, 1, 1, 1, 1, };
+static int x1830_ssi0_dt_funcs[] = { 0, };
+static int x1830_ssi0_dr_funcs[] = { 0, };
+static int x1830_ssi0_clk_funcs[] = { 0, };
+static int x1830_ssi0_gpc_funcs[] = { 0, };
+static int x1830_ssi0_ce0_funcs[] = { 0, };
+static int x1830_ssi0_ce1_funcs[] = { 0, };
+static int x1830_ssi1_dt_c_funcs[] = { 1, };
+static int x1830_ssi1_dr_c_funcs[] = { 1, };
+static int x1830_ssi1_clk_c_funcs[] = { 1, };
+static int x1830_ssi1_gpc_c_funcs[] = { 1, };
+static int x1830_ssi1_ce0_c_funcs[] = { 1, };
+static int x1830_ssi1_ce1_c_funcs[] = { 1, };
+static int x1830_ssi1_dt_d_funcs[] = { 2, };
+static int x1830_ssi1_dr_d_funcs[] = { 2, };
+static int x1830_ssi1_clk_d_funcs[] = { 2, };
+static int x1830_ssi1_gpc_d_funcs[] = { 2, };
+static int x1830_ssi1_ce0_d_funcs[] = { 2, };
+static int x1830_ssi1_ce1_d_funcs[] = { 2, };
+static int x1830_mmc0_1bit_funcs[] = { 0, 0, 0, };
+static int x1830_mmc0_4bit_funcs[] = { 0, 0, 0, };
+static int x1830_mmc1_1bit_funcs[] = { 0, 0, 0, };
+static int x1830_mmc1_4bit_funcs[] = { 0, 0, 0, };
+static int x1830_i2c0_funcs[] = { 1, 1, };
+static int x1830_i2c1_funcs[] = { 0, 0, };
+static int x1830_i2c2_funcs[] = { 1, 1, };
+static int x1830_pwm_pwm0_b_funcs[] = { 0, };
+static int x1830_pwm_pwm0_c_funcs[] = { 1, };
+static int x1830_pwm_pwm1_b_funcs[] = { 0, };
+static int x1830_pwm_pwm1_c_funcs[] = { 1, };
+static int x1830_pwm_pwm2_c_8_funcs[] = { 0, };
+static int x1830_pwm_pwm2_c_13_funcs[] = { 1, };
+static int x1830_pwm_pwm3_c_9_funcs[] = { 0, };
+static int x1830_pwm_pwm3_c_14_funcs[] = { 1, };
+static int x1830_pwm_pwm4_c_15_funcs[] = { 1, };
+static int x1830_pwm_pwm4_c_25_funcs[] = { 0, };
+static int x1830_pwm_pwm5_c_16_funcs[] = { 1, };
+static int x1830_pwm_pwm5_c_26_funcs[] = { 0, };
+static int x1830_pwm_pwm6_c_17_funcs[] = { 1, };
+static int x1830_pwm_pwm6_c_27_funcs[] = { 0, };
+static int x1830_pwm_pwm7_c_18_funcs[] = { 1, };
+static int x1830_pwm_pwm7_c_28_funcs[] = { 0, };
+static int x1830_mac_funcs[] = { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, };
+
+static const struct group_desc x1830_groups[] = {
+       INGENIC_PIN_GROUP("uart0-data", x1830_uart0_data),
+       INGENIC_PIN_GROUP("uart0-hwflow", x1830_uart0_hwflow),
+       INGENIC_PIN_GROUP("uart1-data", x1830_uart1_data),
+       INGENIC_PIN_GROUP("sfc", x1830_sfc),
+       INGENIC_PIN_GROUP("ssi0-dt", x1830_ssi0_dt),
+       INGENIC_PIN_GROUP("ssi0-dr", x1830_ssi0_dr),
+       INGENIC_PIN_GROUP("ssi0-clk", x1830_ssi0_clk),
+       INGENIC_PIN_GROUP("ssi0-gpc", x1830_ssi0_gpc),
+       INGENIC_PIN_GROUP("ssi0-ce0", x1830_ssi0_ce0),
+       INGENIC_PIN_GROUP("ssi0-ce1", x1830_ssi0_ce1),
+       INGENIC_PIN_GROUP("ssi1-dt-c", x1830_ssi1_dt_c),
+       INGENIC_PIN_GROUP("ssi1-dr-c", x1830_ssi1_dr_c),
+       INGENIC_PIN_GROUP("ssi1-clk-c", x1830_ssi1_clk_c),
+       INGENIC_PIN_GROUP("ssi1-gpc-c", x1830_ssi1_gpc_c),
+       INGENIC_PIN_GROUP("ssi1-ce0-c", x1830_ssi1_ce0_c),
+       INGENIC_PIN_GROUP("ssi1-ce1-c", x1830_ssi1_ce1_c),
+       INGENIC_PIN_GROUP("ssi1-dt-d", x1830_ssi1_dt_d),
+       INGENIC_PIN_GROUP("ssi1-dr-d", x1830_ssi1_dr_d),
+       INGENIC_PIN_GROUP("ssi1-clk-d", x1830_ssi1_clk_d),
+       INGENIC_PIN_GROUP("ssi1-gpc-d", x1830_ssi1_gpc_d),
+       INGENIC_PIN_GROUP("ssi1-ce0-d", x1830_ssi1_ce0_d),
+       INGENIC_PIN_GROUP("ssi1-ce1-d", x1830_ssi1_ce1_d),
+       INGENIC_PIN_GROUP("mmc0-1bit", x1830_mmc0_1bit),
+       INGENIC_PIN_GROUP("mmc0-4bit", x1830_mmc0_4bit),
+       INGENIC_PIN_GROUP("mmc1-1bit", x1830_mmc1_1bit),
+       INGENIC_PIN_GROUP("mmc1-4bit", x1830_mmc1_4bit),
+       INGENIC_PIN_GROUP("i2c0-data", x1830_i2c0),
+       INGENIC_PIN_GROUP("i2c1-data", x1830_i2c1),
+       INGENIC_PIN_GROUP("i2c2-data", x1830_i2c2),
+       INGENIC_PIN_GROUP("pwm0-b", x1830_pwm_pwm0_b),
+       INGENIC_PIN_GROUP("pwm0-c", x1830_pwm_pwm0_c),
+       INGENIC_PIN_GROUP("pwm1-b", x1830_pwm_pwm1_b),
+       INGENIC_PIN_GROUP("pwm1-c", x1830_pwm_pwm1_c),
+       INGENIC_PIN_GROUP("pwm2-c-8", x1830_pwm_pwm2_c_8),
+       INGENIC_PIN_GROUP("pwm2-c-13", x1830_pwm_pwm2_c_13),
+       INGENIC_PIN_GROUP("pwm3-c-9", x1830_pwm_pwm3_c_9),
+       INGENIC_PIN_GROUP("pwm3-c-14", x1830_pwm_pwm3_c_14),
+       INGENIC_PIN_GROUP("pwm4-c-15", x1830_pwm_pwm4_c_15),
+       INGENIC_PIN_GROUP("pwm4-c-25", x1830_pwm_pwm4_c_25),
+       INGENIC_PIN_GROUP("pwm5-c-16", x1830_pwm_pwm5_c_16),
+       INGENIC_PIN_GROUP("pwm5-c-26", x1830_pwm_pwm5_c_26),
+       INGENIC_PIN_GROUP("pwm6-c-17", x1830_pwm_pwm6_c_17),
+       INGENIC_PIN_GROUP("pwm6-c-27", x1830_pwm_pwm6_c_27),
+       INGENIC_PIN_GROUP("pwm7-c-18", x1830_pwm_pwm7_c_18),
+       INGENIC_PIN_GROUP("pwm7-c-28", x1830_pwm_pwm7_c_28),
+       INGENIC_PIN_GROUP("mac", x1830_mac),
+};
+
+static const char *x1830_uart0_groups[] = { "uart0-data", "uart0-hwflow", };
+static const char *x1830_uart1_groups[] = { "uart1-data", };
+static const char *x1830_sfc_groups[] = { "sfc", };
+static const char *x1830_ssi0_groups[] = {
+       "ssi0-dt", "ssi0-dr", "ssi0-clk", "ssi0-gpc", "ssi0-ce0", "ssi0-ce1",
+};
+static const char *x1830_ssi1_groups[] = {
+       "ssi1-dt-c", "ssi1-dt-d",
+       "ssi1-dr-c", "ssi1-dr-d",
+       "ssi1-clk-c", "ssi1-clk-d",
+       "ssi1-gpc-c", "ssi1-gpc-d",
+       "ssi1-ce0-c", "ssi1-ce0-d",
+       "ssi1-ce1-c", "ssi1-ce1-d",
+};
+static const char *x1830_mmc0_groups[] = { "mmc0-1bit", "mmc0-4bit", };
+static const char *x1830_mmc1_groups[] = { "mmc1-1bit", "mmc1-4bit", };
+static const char *x1830_i2c0_groups[] = { "i2c0-data", };
+static const char *x1830_i2c1_groups[] = { "i2c1-data", };
+static const char *x1830_i2c2_groups[] = { "i2c2-data", };
+static const char *x1830_pwm0_groups[] = { "pwm0-b", "pwm0-c", };
+static const char *x1830_pwm1_groups[] = { "pwm1-b", "pwm1-c", };
+static const char *x1830_pwm2_groups[] = { "pwm2-c-8", "pwm2-c-13", };
+static const char *x1830_pwm3_groups[] = { "pwm3-c-9", "pwm3-c-14", };
+static const char *x1830_pwm4_groups[] = { "pwm4-c-15", "pwm4-c-25", };
+static const char *x1830_pwm5_groups[] = { "pwm5-c-16", "pwm5-c-26", };
+static const char *x1830_pwm6_groups[] = { "pwm6-c-17", "pwm6-c-27", };
+static const char *x1830_pwm7_groups[] = { "pwm7-c-18", "pwm7-c-28", };
+static const char *x1830_mac_groups[] = { "mac", };
+
+static const struct function_desc x1830_functions[] = {
+       { "uart0", x1830_uart0_groups, ARRAY_SIZE(x1830_uart0_groups), },
+       { "uart1", x1830_uart1_groups, ARRAY_SIZE(x1830_uart1_groups), },
+       { "sfc", x1830_sfc_groups, ARRAY_SIZE(x1830_sfc_groups), },
+       { "ssi0", x1830_ssi0_groups, ARRAY_SIZE(x1830_ssi0_groups), },
+       { "ssi1", x1830_ssi1_groups, ARRAY_SIZE(x1830_ssi1_groups), },
+       { "mmc0", x1830_mmc0_groups, ARRAY_SIZE(x1830_mmc0_groups), },
+       { "mmc1", x1830_mmc1_groups, ARRAY_SIZE(x1830_mmc1_groups), },
+       { "i2c0", x1830_i2c0_groups, ARRAY_SIZE(x1830_i2c0_groups), },
+       { "i2c1", x1830_i2c1_groups, ARRAY_SIZE(x1830_i2c1_groups), },
+       { "i2c2", x1830_i2c2_groups, ARRAY_SIZE(x1830_i2c2_groups), },
+       { "pwm0", x1830_pwm0_groups, ARRAY_SIZE(x1830_pwm0_groups), },
+       { "pwm1", x1830_pwm1_groups, ARRAY_SIZE(x1830_pwm1_groups), },
+       { "pwm2", x1830_pwm2_groups, ARRAY_SIZE(x1830_pwm2_groups), },
+       { "pwm3", x1830_pwm3_groups, ARRAY_SIZE(x1830_pwm3_groups), },
+       { "pwm4", x1830_pwm4_groups, ARRAY_SIZE(x1830_pwm4_groups), },
+       { "pwm5", x1830_pwm5_groups, ARRAY_SIZE(x1830_pwm4_groups), },
+       { "pwm6", x1830_pwm6_groups, ARRAY_SIZE(x1830_pwm4_groups), },
+       { "pwm7", x1830_pwm7_groups, ARRAY_SIZE(x1830_pwm4_groups), },
+       { "mac", x1830_mac_groups, ARRAY_SIZE(x1830_mac_groups), },
+};
+
+static const struct ingenic_chip_info x1830_chip_info = {
+       .num_chips = 4,
+       .reg_offset = 0x1000,
+       .version = ID_X1830,
+       .groups = x1830_groups,
+       .num_groups = ARRAY_SIZE(x1830_groups),
+       .functions = x1830_functions,
+       .num_functions = ARRAY_SIZE(x1830_functions),
+       .pull_ups = x1830_pull_ups,
+       .pull_downs = x1830_pull_downs,
+};
+
 static u32 ingenic_gpio_read_reg(struct ingenic_gpio_chip *jzgc, u8 reg)
 {
        unsigned int val;
@@ -1363,12 +1644,14 @@ static void ingenic_gpio_shadow_set_bit(struct ingenic_gpio_chip *jzgc,
        else
                reg = REG_CLEAR(reg);
 
-       regmap_write(jzgc->jzpc->map, X1000_GPIO_PZ_BASE + reg, BIT(offset));
+       regmap_write(jzgc->jzpc->map, REG_PZ_BASE(
+                       jzgc->jzpc->info->reg_offset) + reg, BIT(offset));
 }
 
 static void ingenic_gpio_shadow_set_bit_load(struct ingenic_gpio_chip *jzgc)
 {
-       regmap_write(jzgc->jzpc->map, X1000_GPIO_PZ_GID2LD,
+       regmap_write(jzgc->jzpc->map, REG_PZ_GID2LD(
+                       jzgc->jzpc->info->reg_offset),
                        jzgc->gc.base / PINS_PER_GPIO_CHIP);
 }
 
@@ -1383,7 +1666,7 @@ static inline bool ingenic_gpio_get_value(struct ingenic_gpio_chip *jzgc,
 static void ingenic_gpio_set_value(struct ingenic_gpio_chip *jzgc,
                                   u8 offset, int value)
 {
-       if (jzgc->jzpc->version >= ID_JZ4760)
+       if (jzgc->jzpc->info->version >= ID_JZ4760)
                ingenic_gpio_set_bit(jzgc, JZ4760_GPIO_PAT0, offset, !!value);
        else
                ingenic_gpio_set_bit(jzgc, JZ4740_GPIO_DATA, offset, !!value);
@@ -1393,58 +1676,42 @@ static void irq_set_type(struct ingenic_gpio_chip *jzgc,
                u8 offset, unsigned int type)
 {
        u8 reg1, reg2;
-
-       if (jzgc->jzpc->version >= ID_JZ4760) {
-               reg1 = JZ4760_GPIO_PAT1;
-               reg2 = JZ4760_GPIO_PAT0;
-       } else {
-               reg1 = JZ4740_GPIO_TRIG;
-               reg2 = JZ4740_GPIO_DIR;
-       }
+       bool val1, val2;
 
        switch (type) {
        case IRQ_TYPE_EDGE_RISING:
-               if (jzgc->jzpc->version >= ID_X1000) {
-                       ingenic_gpio_shadow_set_bit(jzgc, reg2, offset, true);
-                       ingenic_gpio_shadow_set_bit(jzgc, reg1, offset, true);
-                       ingenic_gpio_shadow_set_bit_load(jzgc);
-               } else {
-                       ingenic_gpio_set_bit(jzgc, reg2, offset, true);
-                       ingenic_gpio_set_bit(jzgc, reg1, offset, true);
-               }
+               val1 = val2 = true;
                break;
        case IRQ_TYPE_EDGE_FALLING:
-               if (jzgc->jzpc->version >= ID_X1000) {
-                       ingenic_gpio_shadow_set_bit(jzgc, reg2, offset, false);
-                       ingenic_gpio_shadow_set_bit(jzgc, reg1, offset, true);
-                       ingenic_gpio_shadow_set_bit_load(jzgc);
-               } else {
-                       ingenic_gpio_set_bit(jzgc, reg2, offset, false);
-                       ingenic_gpio_set_bit(jzgc, reg1, offset, true);
-               }
+               val1 = false;
+               val2 = true;
                break;
        case IRQ_TYPE_LEVEL_HIGH:
-               if (jzgc->jzpc->version >= ID_X1000) {
-                       ingenic_gpio_shadow_set_bit(jzgc, reg2, offset, true);
-                       ingenic_gpio_shadow_set_bit(jzgc, reg1, offset, false);
-                       ingenic_gpio_shadow_set_bit_load(jzgc);
-               } else {
-                       ingenic_gpio_set_bit(jzgc, reg2, offset, true);
-                       ingenic_gpio_set_bit(jzgc, reg1, offset, false);
-               }
+               val1 = true;
+               val2 = false;
                break;
        case IRQ_TYPE_LEVEL_LOW:
        default:
-               if (jzgc->jzpc->version >= ID_X1000) {
-                       ingenic_gpio_shadow_set_bit(jzgc, reg2, offset, false);
-                       ingenic_gpio_shadow_set_bit(jzgc, reg1, offset, false);
-                       ingenic_gpio_shadow_set_bit_load(jzgc);
-               } else {
-                       ingenic_gpio_set_bit(jzgc, reg2, offset, false);
-                       ingenic_gpio_set_bit(jzgc, reg1, offset, false);
-               }
+               val1 = val2 = false;
                break;
        }
+
+       if (jzgc->jzpc->info->version >= ID_JZ4760) {
+               reg1 = JZ4760_GPIO_PAT1;
+               reg2 = JZ4760_GPIO_PAT0;
+       } else {
+               reg1 = JZ4740_GPIO_TRIG;
+               reg2 = JZ4740_GPIO_DIR;
+       }
+
+       if (jzgc->jzpc->info->version >= ID_X1000) {
+               ingenic_gpio_shadow_set_bit(jzgc, reg2, offset, val1);
+               ingenic_gpio_shadow_set_bit(jzgc, reg1, offset, val2);
+               ingenic_gpio_shadow_set_bit_load(jzgc);
+       } else {
+               ingenic_gpio_set_bit(jzgc, reg2, offset, val1);
+               ingenic_gpio_set_bit(jzgc, reg1, offset, val2);
+       }
 }
 
 static void ingenic_gpio_irq_mask(struct irq_data *irqd)
@@ -1469,7 +1736,7 @@ static void ingenic_gpio_irq_enable(struct irq_data *irqd)
        struct ingenic_gpio_chip *jzgc = gpiochip_get_data(gc);
        int irq = irqd->hwirq;
 
-       if (jzgc->jzpc->version >= ID_JZ4760)
+       if (jzgc->jzpc->info->version >= ID_JZ4760)
                ingenic_gpio_set_bit(jzgc, JZ4760_GPIO_INT, irq, true);
        else
                ingenic_gpio_set_bit(jzgc, JZ4740_GPIO_SELECT, irq, true);
@@ -1485,7 +1752,7 @@ static void ingenic_gpio_irq_disable(struct irq_data *irqd)
 
        ingenic_gpio_irq_mask(irqd);
 
-       if (jzgc->jzpc->version >= ID_JZ4760)
+       if (jzgc->jzpc->info->version >= ID_JZ4760)
                ingenic_gpio_set_bit(jzgc, JZ4760_GPIO_INT, irq, false);
        else
                ingenic_gpio_set_bit(jzgc, JZ4740_GPIO_SELECT, irq, false);
@@ -1510,7 +1777,7 @@ static void ingenic_gpio_irq_ack(struct irq_data *irqd)
                        irq_set_type(jzgc, irq, IRQ_TYPE_EDGE_RISING);
        }
 
-       if (jzgc->jzpc->version >= ID_JZ4760)
+       if (jzgc->jzpc->info->version >= ID_JZ4760)
                ingenic_gpio_set_bit(jzgc, JZ4760_GPIO_FLAG, irq, false);
        else
                ingenic_gpio_set_bit(jzgc, JZ4740_GPIO_DATA, irq, true);
@@ -1567,7 +1834,7 @@ static void ingenic_gpio_irq_handler(struct irq_desc *desc)
 
        chained_irq_enter(irq_chip, desc);
 
-       if (jzgc->jzpc->version >= ID_JZ4760)
+       if (jzgc->jzpc->info->version >= ID_JZ4760)
                flag = ingenic_gpio_read_reg(jzgc, JZ4760_GPIO_FLAG);
        else
                flag = ingenic_gpio_read_reg(jzgc, JZ4740_GPIO_FLAG);
@@ -1611,7 +1878,7 @@ static inline void ingenic_config_pin(struct ingenic_pinctrl *jzpc,
        unsigned int idx = pin % PINS_PER_GPIO_CHIP;
        unsigned int offt = pin / PINS_PER_GPIO_CHIP;
 
-       regmap_write(jzpc->map, offt * 0x100 +
+       regmap_write(jzpc->map, offt * jzpc->info->reg_offset +
                        (set ? REG_SET(reg) : REG_CLEAR(reg)), BIT(idx));
 }
 
@@ -1620,14 +1887,15 @@ static inline void ingenic_shadow_config_pin(struct ingenic_pinctrl *jzpc,
 {
        unsigned int idx = pin % PINS_PER_GPIO_CHIP;
 
-       regmap_write(jzpc->map, X1000_GPIO_PZ_BASE +
+       regmap_write(jzpc->map, REG_PZ_BASE(jzpc->info->reg_offset) +
                        (set ? REG_SET(reg) : REG_CLEAR(reg)), BIT(idx));
 }
 
 static inline void ingenic_shadow_config_pin_load(struct ingenic_pinctrl *jzpc,
                unsigned int pin)
 {
-       regmap_write(jzpc->map, X1000_GPIO_PZ_GID2LD, pin / PINS_PER_GPIO_CHIP);
+       regmap_write(jzpc->map, REG_PZ_GID2LD(jzpc->info->reg_offset),
+                       pin / PINS_PER_GPIO_CHIP);
 }
 
 static inline bool ingenic_get_pin_config(struct ingenic_pinctrl *jzpc,
@@ -1637,7 +1905,7 @@ static inline bool ingenic_get_pin_config(struct ingenic_pinctrl *jzpc,
        unsigned int offt = pin / PINS_PER_GPIO_CHIP;
        unsigned int val;
 
-       regmap_read(jzpc->map, offt * 0x100 + reg, &val);
+       regmap_read(jzpc->map, offt * jzpc->info->reg_offset + reg, &val);
 
        return val & BIT(idx);
 }
@@ -1648,7 +1916,7 @@ static int ingenic_gpio_get_direction(struct gpio_chip *gc, unsigned int offset)
        struct ingenic_pinctrl *jzpc = jzgc->jzpc;
        unsigned int pin = gc->base + offset;
 
-       if (jzpc->version >= ID_JZ4760)
+       if (jzpc->info->version >= ID_JZ4760)
                return ingenic_get_pin_config(jzpc, pin, JZ4760_GPIO_PAT1);
 
        if (ingenic_get_pin_config(jzpc, pin, JZ4740_GPIO_SELECT))
@@ -1674,13 +1942,13 @@ static int ingenic_pinmux_set_pin_fn(struct ingenic_pinctrl *jzpc,
        dev_dbg(jzpc->dev, "set pin P%c%u to function %u\n",
                        'A' + offt, idx, func);
 
-       if (jzpc->version >= ID_X1000) {
+       if (jzpc->info->version >= ID_X1000) {
                ingenic_shadow_config_pin(jzpc, pin, JZ4760_GPIO_INT, false);
                ingenic_shadow_config_pin(jzpc, pin, GPIO_MSK, false);
                ingenic_shadow_config_pin(jzpc, pin, JZ4760_GPIO_PAT1, func & 0x2);
                ingenic_shadow_config_pin(jzpc, pin, JZ4760_GPIO_PAT0, func & 0x1);
                ingenic_shadow_config_pin_load(jzpc, pin);
-       } else if (jzpc->version >= ID_JZ4760) {
+       } else if (jzpc->info->version >= ID_JZ4760) {
                ingenic_config_pin(jzpc, pin, JZ4760_GPIO_INT, false);
                ingenic_config_pin(jzpc, pin, GPIO_MSK, false);
                ingenic_config_pin(jzpc, pin, JZ4760_GPIO_PAT1, func & 0x2);
@@ -1733,12 +2001,12 @@ static int ingenic_pinmux_gpio_set_direction(struct pinctrl_dev *pctldev,
        dev_dbg(pctldev->dev, "set pin P%c%u to %sput\n",
                        'A' + offt, idx, input ? "in" : "out");
 
-       if (jzpc->version >= ID_X1000) {
+       if (jzpc->info->version >= ID_X1000) {
                ingenic_shadow_config_pin(jzpc, pin, JZ4760_GPIO_INT, false);
                ingenic_shadow_config_pin(jzpc, pin, GPIO_MSK, true);
                ingenic_shadow_config_pin(jzpc, pin, JZ4760_GPIO_PAT1, input);
                ingenic_shadow_config_pin_load(jzpc, pin);
-       } else if (jzpc->version >= ID_JZ4760) {
+       } else if (jzpc->info->version >= ID_JZ4760) {
                ingenic_config_pin(jzpc, pin, JZ4760_GPIO_INT, false);
                ingenic_config_pin(jzpc, pin, GPIO_MSK, true);
                ingenic_config_pin(jzpc, pin, JZ4760_GPIO_PAT1, input);
@@ -1768,7 +2036,7 @@ static int ingenic_pinconf_get(struct pinctrl_dev *pctldev,
        unsigned int offt = pin / PINS_PER_GPIO_CHIP;
        bool pull;
 
-       if (jzpc->version >= ID_JZ4760)
+       if (jzpc->info->version >= ID_JZ4760)
                pull = !ingenic_get_pin_config(jzpc, pin, JZ4760_GPIO_PEN);
        else
                pull = !ingenic_get_pin_config(jzpc, pin, JZ4740_GPIO_PULL_DIS);
@@ -1798,18 +2066,37 @@ static int ingenic_pinconf_get(struct pinctrl_dev *pctldev,
 }
 
 static void ingenic_set_bias(struct ingenic_pinctrl *jzpc,
-               unsigned int pin, bool enabled)
+               unsigned int pin, unsigned int bias)
 {
-       if (jzpc->version >= ID_JZ4760)
-               ingenic_config_pin(jzpc, pin, JZ4760_GPIO_PEN, !enabled);
-       else
-               ingenic_config_pin(jzpc, pin, JZ4740_GPIO_PULL_DIS, !enabled);
+       if (jzpc->info->version >= ID_X1830) {
+               unsigned int idx = pin % PINS_PER_GPIO_CHIP;
+               unsigned int half = PINS_PER_GPIO_CHIP / 2;
+               unsigned int idxh = pin % half * 2;
+               unsigned int offt = pin / PINS_PER_GPIO_CHIP;
+
+               if (idx < half) {
+                       regmap_write(jzpc->map, offt * jzpc->info->reg_offset +
+                                       REG_CLEAR(X1830_GPIO_PEL), 3 << idxh);
+                       regmap_write(jzpc->map, offt * jzpc->info->reg_offset +
+                                       REG_SET(X1830_GPIO_PEL), bias << idxh);
+               } else {
+                       regmap_write(jzpc->map, offt * jzpc->info->reg_offset +
+                                       REG_CLEAR(X1830_GPIO_PEH), 3 << idxh);
+                       regmap_write(jzpc->map, offt * jzpc->info->reg_offset +
+                                       REG_SET(X1830_GPIO_PEH), bias << idxh);
+               }
+
+       } else if (jzpc->info->version >= ID_JZ4760) {
+               ingenic_config_pin(jzpc, pin, JZ4760_GPIO_PEN, !bias);
+       } else {
+               ingenic_config_pin(jzpc, pin, JZ4740_GPIO_PULL_DIS, !bias);
+       }
 }
 
 static void ingenic_set_output_level(struct ingenic_pinctrl *jzpc,
                                     unsigned int pin, bool high)
 {
-       if (jzpc->version >= ID_JZ4760)
+       if (jzpc->info->version >= ID_JZ4760)
                ingenic_config_pin(jzpc, pin, JZ4760_GPIO_PAT0, high);
        else
                ingenic_config_pin(jzpc, pin, JZ4740_GPIO_DATA, high);
@@ -1843,7 +2130,7 @@ static int ingenic_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                case PIN_CONFIG_BIAS_DISABLE:
                        dev_dbg(jzpc->dev, "disable pull-over for pin P%c%u\n",
                                        'A' + offt, idx);
-                       ingenic_set_bias(jzpc, pin, false);
+                       ingenic_set_bias(jzpc, pin, GPIO_PULL_DIS);
                        break;
 
                case PIN_CONFIG_BIAS_PULL_UP:
@@ -1851,7 +2138,7 @@ static int ingenic_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                                return -EINVAL;
                        dev_dbg(jzpc->dev, "set pull-up for pin P%c%u\n",
                                        'A' + offt, idx);
-                       ingenic_set_bias(jzpc, pin, true);
+                       ingenic_set_bias(jzpc, pin, GPIO_PULL_UP);
                        break;
 
                case PIN_CONFIG_BIAS_PULL_DOWN:
@@ -1859,7 +2146,7 @@ static int ingenic_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                                return -EINVAL;
                        dev_dbg(jzpc->dev, "set pull-down for pin P%c%u\n",
                                        'A' + offt, idx);
-                       ingenic_set_bias(jzpc, pin, true);
+                       ingenic_set_bias(jzpc, pin, GPIO_PULL_DOWN);
                        break;
 
                case PIN_CONFIG_OUTPUT:
@@ -1939,25 +2226,13 @@ static const struct regmap_config ingenic_pinctrl_regmap_config = {
        .reg_stride = 4,
 };
 
-static const struct of_device_id ingenic_pinctrl_of_match[] = {
-       { .compatible = "ingenic,jz4740-pinctrl", .data = (void *) ID_JZ4740 },
-       { .compatible = "ingenic,jz4725b-pinctrl", .data = (void *)ID_JZ4725B },
-       { .compatible = "ingenic,jz4760-pinctrl", .data = (void *) ID_JZ4760 },
-       { .compatible = "ingenic,jz4760b-pinctrl", .data = (void *) ID_JZ4760B },
-       { .compatible = "ingenic,jz4770-pinctrl", .data = (void *) ID_JZ4770 },
-       { .compatible = "ingenic,jz4780-pinctrl", .data = (void *) ID_JZ4780 },
-       { .compatible = "ingenic,x1000-pinctrl", .data = (void *) ID_X1000 },
-       { .compatible = "ingenic,x1000e-pinctrl", .data = (void *) ID_X1000E },
-       { .compatible = "ingenic,x1500-pinctrl", .data = (void *) ID_X1500 },
-       {},
-};
-
 static const struct of_device_id ingenic_gpio_of_match[] __initconst = {
        { .compatible = "ingenic,jz4740-gpio", },
        { .compatible = "ingenic,jz4760-gpio", },
        { .compatible = "ingenic,jz4770-gpio", },
        { .compatible = "ingenic,jz4780-gpio", },
        { .compatible = "ingenic,x1000-gpio", },
+       { .compatible = "ingenic,x1830-gpio", },
        {},
 };
 
@@ -1981,7 +2256,7 @@ static int __init ingenic_gpio_probe(struct ingenic_pinctrl *jzpc,
                return -ENOMEM;
 
        jzgc->jzpc = jzpc;
-       jzgc->reg_base = bank * 0x100;
+       jzgc->reg_base = bank * jzpc->info->reg_offset;
 
        jzgc->gc.label = devm_kasprintf(dev, GFP_KERNEL, "GPIO%c", 'A' + bank);
        if (!jzgc->gc.label)
@@ -2048,9 +2323,6 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
        struct ingenic_pinctrl *jzpc;
        struct pinctrl_desc *pctl_desc;
        void __iomem *base;
-       const struct platform_device_id *id = platform_get_device_id(pdev);
-       const struct of_device_id *of_id = of_match_device(
-                       ingenic_pinctrl_of_match, dev);
        const struct ingenic_chip_info *chip_info;
        struct device_node *node;
        unsigned int i;
@@ -2060,8 +2332,7 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
        if (!jzpc)
                return -ENOMEM;
 
-       base = devm_ioremap_resource(dev,
-                       platform_get_resource(pdev, IORESOURCE_MEM, 0));
+       base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(base))
                return PTR_ERR(base);
 
@@ -2073,31 +2344,7 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
        }
 
        jzpc->dev = dev;
-
-       if (of_id)
-               jzpc->version = (enum jz_version)of_id->data;
-       else
-               jzpc->version = (enum jz_version)id->driver_data;
-
-       if (jzpc->version >= ID_X1500)
-               chip_info = &x1500_chip_info;
-       else if (jzpc->version >= ID_X1000E)
-               chip_info = &x1000e_chip_info;
-       else if (jzpc->version >= ID_X1000)
-               chip_info = &x1000_chip_info;
-       else if (jzpc->version >= ID_JZ4780)
-               chip_info = &jz4780_chip_info;
-       else if (jzpc->version >= ID_JZ4770)
-               chip_info = &jz4770_chip_info;
-       else if (jzpc->version >= ID_JZ4760B)
-               chip_info = &jz4760b_chip_info;
-       else if (jzpc->version >= ID_JZ4760)
-               chip_info = &jz4760_chip_info;
-       else if (jzpc->version >= ID_JZ4725B)
-               chip_info = &jz4725b_chip_info;
-       else
-               chip_info = &jz4740_chip_info;
-       jzpc->info = chip_info;
+       jzpc->info = chip_info = of_device_get_match_data(dev);
 
        pctl_desc = devm_kzalloc(&pdev->dev, sizeof(*pctl_desc), GFP_KERNEL);
        if (!pctl_desc)
@@ -2166,25 +2413,25 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev)
        return 0;
 }
 
-static const struct platform_device_id ingenic_pinctrl_ids[] = {
-       { "jz4740-pinctrl", ID_JZ4740 },
-       { "jz4725b-pinctrl", ID_JZ4725B },
-       { "jz4760-pinctrl", ID_JZ4760 },
-       { "jz4760b-pinctrl", ID_JZ4760B },
-       { "jz4770-pinctrl", ID_JZ4770 },
-       { "jz4780-pinctrl", ID_JZ4780 },
-       { "x1000-pinctrl", ID_X1000 },
-       { "x1000e-pinctrl", ID_X1000E },
-       { "x1500-pinctrl", ID_X1500 },
+static const struct of_device_id ingenic_pinctrl_of_match[] = {
+       { .compatible = "ingenic,jz4740-pinctrl", .data = &jz4740_chip_info },
+       { .compatible = "ingenic,jz4725b-pinctrl", .data = &jz4725b_chip_info },
+       { .compatible = "ingenic,jz4760-pinctrl", .data = &jz4760_chip_info },
+       { .compatible = "ingenic,jz4760b-pinctrl", .data = &jz4760_chip_info },
+       { .compatible = "ingenic,jz4770-pinctrl", .data = &jz4770_chip_info },
+       { .compatible = "ingenic,jz4780-pinctrl", .data = &jz4780_chip_info },
+       { .compatible = "ingenic,x1000-pinctrl", .data = &x1000_chip_info },
+       { .compatible = "ingenic,x1000e-pinctrl", .data = &x1000_chip_info },
+       { .compatible = "ingenic,x1500-pinctrl", .data = &x1500_chip_info },
+       { .compatible = "ingenic,x1830-pinctrl", .data = &x1830_chip_info },
        {},
 };
 
 static struct platform_driver ingenic_pinctrl_driver = {
        .driver = {
                .name = "pinctrl-ingenic",
-               .of_match_table = of_match_ptr(ingenic_pinctrl_of_match),
+               .of_match_table = ingenic_pinctrl_of_match,
        },
-       .id_table = ingenic_pinctrl_ids,
 };
 
 static int __init ingenic_pinctrl_drv_register(void)