]> asedeno.scripts.mit.edu Git - git.git/blobdiff - git-gui.sh
git-gui: Refactor console success/failure handling.
[git.git] / git-gui.sh
index faae6ce7c5007b037088849bb096b912c6b6fb46..d2645580769c02d285314551842e0aed6fd4f824 100755 (executable)
@@ -568,7 +568,7 @@ proc reshow_diff {} {
        if {$p eq {}
                || $current_diff_side eq {}
                || [catch {set s $file_states($p)}]
-               || [lsearch -sorted $file_lists($current_diff_side) $p] == -1} {
+               || [lsearch -sorted -exact $file_lists($current_diff_side) $p] == -1} {
                clear_diff
        } else {
                show_diff $p $current_diff_side
@@ -607,16 +607,13 @@ proc show_diff {path w {lno {}}} {
        if {$diff_active || ![lock_index read]} return
 
        clear_diff
-       if {$w eq {} || $lno == {}} {
-               foreach w [array names file_lists] {
-                       set lno [lsearch -sorted $file_lists($w) $path]
-                       if {$lno >= 0} {
-                               incr lno
-                               break
-                       }
+       if {$lno == {}} {
+               set lno [lsearch -sorted -exact $file_lists($w) $path]
+               if {$lno >= 0} {
+                       incr lno
                }
        }
-       if {$w ne {} && $lno >= 1} {
+       if {$lno >= 1} {
                $w tag add in_diff $lno.0 [expr {$lno + 1}].0
        }
 
@@ -1272,87 +1269,25 @@ proc commit_committree {fd_wt curHEAD msg} {
 
 ######################################################################
 ##
-## fetch pull push
+## fetch push
 
 proc fetch_from {remote} {
-       set w [new_console "fetch $remote" \
+       set w [new_console \
+               "fetch $remote" \
                "Fetching new changes from $remote"]
        set cmd [list git fetch]
        lappend cmd $remote
-       console_exec $w $cmd
-}
-
-proc pull_remote {remote branch} {
-       global HEAD commit_type file_states repo_config
-
-       if {![lock_index update]} return
-
-       # -- Our in memory state should match the repository.
-       #
-       repository_state curType curHEAD curMERGE_HEAD
-       if {$commit_type ne $curType || $HEAD ne $curHEAD} {
-               info_popup {Last scanned state does not match repository state.
-
-Another Git program has modified this repository
-since the last scan.  A rescan must be performed
-before a pull operation can be started.
-
-The rescan will be automatically started now.
-}
-               unlock_index
-               rescan {set ui_status_value {Ready.}}
-               return
-       }
-
-       # -- No differences should exist before a pull.
-       #
-       if {[array size file_states] != 0} {
-               error_popup {Uncommitted but modified files are present.
-
-You should not perform a pull with unmodified
-files in your working directory as Git will be
-unable to recover from an incorrect merge.
-
-You should commit or revert all changes before
-starting a pull operation.
-}
-               unlock_index
-               return
-       }
-
-       set w [new_console "pull $remote $branch" \
-               "Pulling new changes from branch $branch in $remote"]
-       set cmd [list git pull]
-       if {$repo_config(gui.pullsummary) eq {false}} {
-               lappend cmd --no-summary
-       }
-       lappend cmd $remote
-       lappend cmd $branch
-       console_exec $w $cmd [list post_pull_remote $remote $branch]
-}
-
-proc post_pull_remote {remote branch success} {
-       global HEAD PARENT MERGE_HEAD commit_type selected_commit_type
-       global ui_status_value
-
-       unlock_index
-       if {$success} {
-               repository_state commit_type HEAD MERGE_HEAD
-               set PARENT $HEAD
-               set selected_commit_type new
-               set ui_status_value "Pulling $branch from $remote complete."
-       } else {
-               rescan [list set ui_status_value \
-                       "Conflicts detected while pulling $branch from $remote."]
-       }
+       console_exec $w $cmd console_done
 }
 
 proc push_to {remote} {
-       set w [new_console "push $remote" \
+       set w [new_console \
+               "push $remote" \
                "Pushing changes to $remote"]
        set cmd [list git push]
+       lappend cmd -v
        lappend cmd $remote
-       console_exec $w $cmd
+       console_exec $w $cmd console_done
 }
 
 ######################################################################
@@ -1430,7 +1365,7 @@ proc display_file_helper {w path icon_name old_m new_m} {
        global file_lists
 
        if {$new_m eq {_}} {
-               set lno [lsearch -sorted $file_lists($w) $path]
+               set lno [lsearch -sorted -exact $file_lists($w) $path]
                if {$lno >= 0} {
                        set file_lists($w) [lreplace $file_lists($w) $lno $lno]
                        incr lno
@@ -1441,7 +1376,7 @@ proc display_file_helper {w path icon_name old_m new_m} {
        } elseif {$old_m eq {_} && $new_m ne {_}} {
                lappend file_lists($w) $path
                set file_lists($w) [lsort -unique $file_lists($w)]
-               set lno [lsearch -sorted $file_lists($w) $path]
+               set lno [lsearch -sorted -exact $file_lists($w) $path]
                incr lno
                $w conf -state normal
                $w image create $lno.0 \
@@ -2145,7 +2080,7 @@ Delete the selected branches?}
                if {[catch {exec git update-ref -d "refs/heads/$b" $o} err]} {
                        append failed " - $b: $err\n"
                } else {
-                       set x [lsearch -sorted $all_heads $b]
+                       set x [lsearch -sorted -exact $all_heads $b]
                        if {$x >= 0} {
                                set all_heads [lreplace $all_heads $x $x]
                        }
@@ -2474,6 +2409,7 @@ proc populate_push_menu {} {
        global all_remotes repo_config
 
        set m .mbar.push
+       set fast_count 0
        foreach r $all_remotes {
                set enable 0
                if {![catch {set a $repo_config(remote.$r.url)}]} {
@@ -2494,14 +2430,167 @@ proc populate_push_menu {} {
                }
 
                if {$enable} {
+                       if {!$fast_count} {
+                               $m add separator
+                       }
                        $m add command \
                                -label "Push to $r..." \
                                -command [list push_to $r] \
                                -font font_ui
+                       incr fast_count
                }
        }
 }
 
+proc start_push_anywhere_action {w} {
+       global push_urltype push_remote push_url push_thin push_tags
+
+       set r_url {}
+       switch -- $push_urltype {
+       remote {set r_url $push_remote}
+       url {set r_url $push_url}
+       }
+       if {$r_url eq {}} return
+
+       set cmd [list git push]
+       lappend cmd -v
+       if {$push_thin} {
+               lappend cmd --thin
+       }
+       if {$push_tags} {
+               lappend cmd --tags
+       }
+       lappend cmd $r_url
+       set cnt 0
+       foreach i [$w.source.l curselection] {
+               set b [$w.source.l get $i]
+               lappend cmd "refs/heads/$b:refs/heads/$b"
+               incr cnt
+       }
+       if {$cnt == 0} {
+               return
+       } elseif {$cnt == 1} {
+               set unit branch
+       } else {
+               set unit branches
+       }
+
+       set cons [new_console "push $r_url" "Pushing $cnt $unit to $r_url"]
+       console_exec $cons $cmd console_done
+       destroy $w
+}
+
+trace add variable push_remote write \
+       [list radio_selector push_urltype remote]
+
+proc do_push_anywhere {} {
+       global all_heads all_remotes current_branch
+       global push_urltype push_remote push_url push_thin push_tags
+
+       set w .push_setup
+       toplevel $w
+       wm geometry $w "+[winfo rootx .]+[winfo rooty .]"
+
+       label $w.header -text {Push Branches} -font font_uibold
+       pack $w.header -side top -fill x
+
+       frame $w.buttons
+       button $w.buttons.create -text Push \
+               -font font_ui \
+               -command [list start_push_anywhere_action $w]
+       pack $w.buttons.create -side right
+       button $w.buttons.cancel -text {Cancel} \
+               -font font_ui \
+               -command [list destroy $w]
+       pack $w.buttons.cancel -side right -padx 5
+       pack $w.buttons -side bottom -fill x -pady 10 -padx 10
+
+       labelframe $w.source \
+               -text {Source Branches} \
+               -font font_ui
+       listbox $w.source.l \
+               -height 10 \
+               -width 50 \
+               -selectmode extended \
+               -font font_ui
+       foreach h $all_heads {
+               $w.source.l insert end $h
+               if {$h eq $current_branch} {
+                       $w.source.l select set end
+               }
+       }
+       pack $w.source.l -fill both -pady 5 -padx 5
+       pack $w.source -fill both -pady 5 -padx 5
+
+       labelframe $w.dest \
+               -text {Destination Repository} \
+               -font font_ui
+       if {$all_remotes ne {}} {
+               radiobutton $w.dest.remote_r \
+                       -text {Remote:} \
+                       -value remote \
+                       -variable push_urltype \
+                       -font font_ui
+               eval tk_optionMenu $w.dest.remote_m push_remote $all_remotes
+               grid $w.dest.remote_r $w.dest.remote_m -sticky w
+               if {[lsearch -sorted -exact $all_remotes origin] != -1} {
+                       set push_remote origin
+               } else {
+                       set push_remote [lindex $all_remotes 0]
+               }
+               set push_urltype remote
+       } else {
+               set push_urltype url
+       }
+       radiobutton $w.dest.url_r \
+               -text {Arbitrary URL:} \
+               -value url \
+               -variable push_urltype \
+               -font font_ui
+       entry $w.dest.url_t \
+               -borderwidth 1 \
+               -relief sunken \
+               -width 50 \
+               -textvariable push_url \
+               -font font_ui \
+               -validate key \
+               -validatecommand {
+                       if {%d == 1 && [regexp {\s} %S]} {return 0}
+                       if {%d == 1 && [string length %S] > 0} {
+                               set push_urltype url
+                       }
+                       return 1
+               }
+       grid $w.dest.url_r $w.dest.url_t -sticky we -padx {0 5}
+       grid columnconfigure $w.dest 1 -weight 1
+       pack $w.dest -anchor nw -fill x -pady 5 -padx 5
+
+       labelframe $w.options \
+               -text {Transfer Options} \
+               -font font_ui
+       checkbutton $w.options.thin \
+               -text {Use thin pack (for slow network connections)} \
+               -variable push_thin \
+               -font font_ui
+       grid $w.options.thin -columnspan 2 -sticky w
+       checkbutton $w.options.tags \
+               -text {Include tags} \
+               -variable push_tags \
+               -font font_ui
+       grid $w.options.tags -columnspan 2 -sticky w
+       grid columnconfigure $w.options 1 -weight 1
+       pack $w.options -anchor nw -fill x -pady 5 -padx 5
+
+       set push_url {}
+       set push_thin 0
+       set push_tags 0
+
+       bind $w <Visibility> "grab $w"
+       bind $w <Key-Escape> "destroy $w"
+       wm title $w "[appname] ([reponame]): Push"
+       tkwait window $w
+}
+
 ######################################################################
 ##
 ## icons
@@ -2765,7 +2854,7 @@ proc console_init {w} {
        return $w
 }
 
-proc console_exec {w cmd {after {}}} {
+proc console_exec {w cmd after} {
        # -- Windows tosses the enviroment when we exec our child.
        #    But most users need that so we have to relogin. :-(
        #
@@ -2784,7 +2873,7 @@ proc console_exec {w cmd {after {}}} {
 }
 
 proc console_read {w fd after} {
-       global console_cr console_data
+       global console_cr
 
        set buf [read $fd]
        if {$buf ne {}} {
@@ -2818,25 +2907,36 @@ proc console_read {w fd after} {
        fconfigure $fd -blocking 1
        if {[eof $fd]} {
                if {[catch {close $fd}]} {
-                       if {![winfo exists $w]} {console_init $w}
-                       $w.m.s conf -background red -text {Error: Command Failed}
-                       $w.ok conf -state normal
                        set ok 0
-               } elseif {[winfo exists $w]} {
-                       $w.m.s conf -background green -text {Success}
-                       $w.ok conf -state normal
+               } else {
                        set ok 1
                }
-               array unset console_cr $w
-               array unset console_data $w
-               if {$after ne {}} {
-                       uplevel #0 $after $ok
-               }
+               uplevel #0 $after $w $ok
                return
        }
        fconfigure $fd -blocking 0
 }
 
+proc console_done {w ok} {
+       global console_cr console_data
+
+       if {$ok} {
+               if {[winfo exists $w]} {
+                       $w.m.s conf -background green -text {Success}
+                       $w.ok conf -state normal
+               }
+       } else {
+               if {![winfo exists $w]} {
+                       console_init $w
+               }
+               $w.m.s conf -background red -text {Error: Command Failed}
+               $w.ok conf -state normal
+       }
+
+       array unset console_cr $w
+       array unset console_data $w
+}
+
 ######################################################################
 ##
 ## ui commands
@@ -2938,7 +3038,7 @@ proc do_stats {} {
 
 proc do_gc {} {
        set w [new_console {gc} {Compressing the object database}]
-       console_exec $w {git gc}
+       console_exec $w {git gc} console_done
 }
 
 proc do_fsck_objects {} {
@@ -2948,7 +3048,7 @@ proc do_fsck_objects {} {
        lappend cmd --full
        lappend cmd --cache
        lappend cmd --strict
-       console_exec $w $cmd
+       console_exec $w $cmd console_done
 }
 
 set is_quitting 0
@@ -3903,6 +4003,10 @@ lappend disable_on_lock \
 if {!$single_commit} {
        menu .mbar.fetch
        menu .mbar.push
+
+       .mbar.push add command -label {Push...} \
+               -command do_push_anywhere \
+               -font font_ui
 }
 
 if {[is_MacOSX]} {