X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=blobdiff_plain;f=sshsha.c;h=48cabb5c5c38c2f9383b016502b8579272eacb79;hb=9b15a8010102fc83dcd7eef78014a65f11619d63;hp=7c10a9a751aa0d3eb8f8a5cb066b8cdacde1ce01;hpb=0f1e4491897cc33909db68e2c4d8bd702e663c07;p=PuTTY.git

diff --git a/sshsha.c b/sshsha.c
index 7c10a9a7..48cabb5c 100644
--- a/sshsha.c
+++ b/sshsha.c
@@ -1,7 +1,3 @@
-#include <stdarg.h> /* FIXME */
-#include <windows.h> /* FIXME */
-#include "putty.h" /* FIXME */
-
 /*
  * SHA1 hash algorithm. Used in SSH2 as a MAC, and the transform is
  * also used as a `stirring' function for the PuTTY random number
@@ -11,8 +7,6 @@
 
 #include "ssh.h"
 
-typedef unsigned int uint32;
-
 /* ----------------------------------------------------------------------
  * Core SHA algorithm: processes 16-word blocks into a message digest.
  */
@@ -181,11 +175,6 @@ static void sha1_key(SHA_State *s1, SHA_State *s2,
                      unsigned char *key, int len) {
     unsigned char foo[64];
     int i;
-    {int j;
-        debug(("Key supplied is:\r\n"));
-        for (j=0; j<len; j++) debug(("  %02X", key[j]));
-        debug(("\r\n"));
-    }
 
     memset(foo, 0x36, 64);
     for (i = 0; i < len && i < 64; i++)
@@ -210,6 +199,14 @@ static void sha1_sckey(unsigned char *key) {
     sha1_key(&sha1_sc_mac_s1, &sha1_sc_mac_s2, key, 20);
 }
 
+static void sha1_cskey_buggy(unsigned char *key) {
+    sha1_key(&sha1_cs_mac_s1, &sha1_cs_mac_s2, key, 16);
+}
+
+static void sha1_sckey_buggy(unsigned char *key) {
+    sha1_key(&sha1_sc_mac_s1, &sha1_sc_mac_s2, key, 16);
+}
+
 static void sha1_do_hmac(SHA_State *s1, SHA_State *s2,
                          unsigned char *blk, int len, unsigned long seq,
                          unsigned char *hmac) {
@@ -231,32 +228,12 @@ static void sha1_do_hmac(SHA_State *s1, SHA_State *s2,
 }
 
 static void sha1_generate(unsigned char *blk, int len, unsigned long seq) {
-    {int i;
-        debug(("Gen HMAC on block len=%d seq=%d:\r\n", len, seq));
-        for (i=0; i<len; i++) debug(("  %02X", blk[i]));
-        debug(("\r\n"));
-    }
     sha1_do_hmac(&sha1_cs_mac_s1, &sha1_cs_mac_s2, blk, len, seq, blk+len);
-    {int i;
-        debug(("We compute HMAC as:\r\n"));
-        for (i=0; i<20; i++) debug(("  %02X", blk[len+i]));
-        debug(("\r\n"));
-    }
 }
 
 static int sha1_verify(unsigned char *blk, int len, unsigned long seq) {
     unsigned char correct[20];
-    {int i;
-        debug(("HMAC on block len=%d seq=%d:\r\n", len, seq));
-        for (i=0; i<len; i++) debug(("  %02X", blk[i]));
-        debug(("\r\n"));
-    }
     sha1_do_hmac(&sha1_sc_mac_s1, &sha1_sc_mac_s2, blk, len, seq, correct);
-    {int i;
-        debug(("We compute HMAC as:\r\n"));
-        for (i=0; i<20; i++) debug(("  %02X", correct[i]));
-        debug(("\r\n"));
-    }
     return !memcmp(correct, blk+len, 20);
 }
 
@@ -267,3 +244,11 @@ struct ssh_mac ssh_sha1 = {
     "hmac-sha1",
     20
 };
+
+struct ssh_mac ssh_sha1_buggy = {
+    sha1_cskey_buggy, sha1_sckey_buggy,
+    sha1_generate,
+    sha1_verify,
+    "hmac-sha1",
+    20
+};