X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=blobdiff_plain;f=unix%2Fgtkcols.c;h=e8223a726e3bab89fb6357419ccf4807632dddb1;hb=095072fa46b2d7b8beafaddb2f873d2f500a1e10;hp=8b906215f758ee2d20d6b3ac2585b2f6cb9c014c;hpb=d507e99d2046e1af5e1c98f9b63638ba0e946098;p=PuTTY.git

diff --git a/unix/gtkcols.c b/unix/gtkcols.c
index 8b906215..e8223a72 100644
--- a/unix/gtkcols.c
+++ b/unix/gtkcols.c
@@ -588,6 +588,10 @@ static gint columns_compute_width(Columns *cols, widget_dim_fn_t get_width)
     const gint *percentages;
     static const gint onecol[] = { 100 };
 
+#ifdef COLUMNS_WIDTH_DIAGNOSTICS
+    printf("compute_width(%p): start\n", cols);
+#endif
+
     retwidth = 0;
 
     ncols = 1;
@@ -611,6 +615,23 @@ static gint columns_compute_width(Columns *cols, widget_dim_fn_t get_width)
         childwidth = get_width(child);
 	colspan = child->colspan ? child->colspan : ncols-child->colstart;
 
+#ifdef COLUMNS_WIDTH_DIAGNOSTICS
+        printf("compute_width(%p): ", cols);
+        if (GTK_IS_LABEL(child->widget))
+            printf("label %p '%s' wrap=%s: ", child->widget,
+                   gtk_label_get_text(GTK_LABEL(child->widget)),
+                   (gtk_label_get_line_wrap(GTK_LABEL(child->widget))
+                    ? "TRUE" : "FALSE"));
+        else
+            printf("widget %p: ", child->widget);
+        {
+            gint min, nat;
+            gtk_widget_get_preferred_width(child->widget, &min, &nat);
+            printf("minwidth=%d natwidth=%d ", min, nat);
+        }
+        printf("thiswidth=%d span=%d\n", childwidth, colspan);
+#endif
+
         /*
          * To compute width: we know that childwidth + cols->spacing
          * needs to equal a certain percentage of the full width of
@@ -635,6 +656,10 @@ static gint columns_compute_width(Columns *cols, widget_dim_fn_t get_width)
              * before dividing by percent.
              */
             fullwid = (thiswid * 100 + percent - 1) / percent;
+#ifdef COLUMNS_WIDTH_DIAGNOSTICS
+            printf("compute_width(%p): after %p, thiswid=%d fullwid=%d\n",
+                   cols, child->widget, thiswid, fullwid);
+#endif
 
             /*
              * The above calculation assumes every widget gets
@@ -649,6 +674,10 @@ static gint columns_compute_width(Columns *cols, widget_dim_fn_t get_width)
 
     retwidth += 2*gtk_container_get_border_width(GTK_CONTAINER(cols));
 
+#ifdef COLUMNS_WIDTH_DIAGNOSTICS
+    printf("compute_width(%p): done, returning %d\n", cols, retwidth);
+#endif
+
     return retwidth;
 }
 
@@ -951,14 +980,19 @@ static gint columns_gtk3_get_nat_width(ColumnsChild *child)
 {
     gint ret;
 
-    if (GTK_IS_LABEL(child->widget) &&
-        gtk_label_get_line_wrap(GTK_LABEL(child->widget))) {
+    if ((GTK_IS_LABEL(child->widget) &&
+         gtk_label_get_line_wrap(GTK_LABEL(child->widget))) ||
+        GTK_IS_ENTRY(child->widget)) {
         /*
          * We treat wrapping GtkLabels as a special case in this
          * layout class, because the whole point of those is that I
          * _don't_ want them to take up extra horizontal space for
          * long text, but instead to wrap it to whatever size is used
          * by the rest of the layout.
+         *
+         * GtkEntry gets similar treatment, because in OS X GTK I've
+         * found that it requests a natural width regardless of the
+         * output of gtk_entry_set_width_chars.
          */
         gtk_widget_get_preferred_width(child->widget, &ret, NULL);
     } else {