X-Git-Url: https://asedeno.scripts.mit.edu/gitweb/?a=blobdiff_plain;f=windows%2Fwinshare.c;h=5f1c7244010ff401a4da4889c674b349884654b0;hb=21101c7397e460933635a7bfed813864fc4f88fe;hp=17bad46d913e548c4355894509b5af271ead0b07;hpb=163b899df22d530e8fae7ee3344263a47f19ff43;p=PuTTY.git diff --git a/windows/winshare.c b/windows/winshare.c index 17bad46d..5f1c7244 100644 --- a/windows/winshare.c +++ b/windows/winshare.c @@ -5,6 +5,8 @@ #include #include +#if !defined NO_SECURITY + #define DEFINE_PLUG_METHOD_MACROS #include "tree234.h" #include "putty.h" @@ -12,9 +14,23 @@ #include "proxy.h" #include "ssh.h" -#if !defined NO_SECURITY +#include "wincapi.h" -#include "winsecur.h" +#ifdef COVERITY +/* + * The hack I use to build for Coverity scanning, using winegcc and + * Makefile.cyg, didn't provide some defines in wincrypt.h last time I + * looked. Therefore, define them myself here, but enclosed in #ifdef + * COVERITY to ensure I don't make up random nonsense values for any + * real build. + */ +#ifndef CRYPTPROTECTMEMORY_BLOCK_SIZE +#define CRYPTPROTECTMEMORY_BLOCK_SIZE 16 +#endif +#ifndef CRYPTPROTECTMEMORY_CROSS_PROCESS +#define CRYPTPROTECTMEMORY_CROSS_PROCESS 1 +#endif +#endif #define CONNSHARE_PIPE_PREFIX "\\\\.\\pipe\\putty-connshare" #define CONNSHARE_MUTEX_PREFIX "Local\\putty-connshare-mutex" @@ -141,6 +157,7 @@ int platform_ssh_share(const char *pi_name, Conf *conf, if (!make_private_security_descriptor(MUTEX_ALL_ACCESS, &psd, &acl, logtext)) { sfree(mutexname); + sfree(name); return SHARE_NONE; } @@ -155,6 +172,7 @@ int platform_ssh_share(const char *pi_name, Conf *conf, *logtext = dupprintf("CreateMutex(\"%s\") failed: %s", mutexname, win_strerror(GetLastError())); sfree(mutexname); + sfree(name); LocalFree(psd); LocalFree(acl); return SHARE_NONE;