]> asedeno.scripts.mit.edu Git - linux.git/commit
net: phy: core: use genphy version of callbacks read_status and config_aneg per default
authorHeiner Kallweit <hkallweit1@gmail.com>
Thu, 30 Nov 2017 22:46:19 +0000 (23:46 +0100)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Dec 2017 20:42:21 +0000 (15:42 -0500)
commit00fde79532d66d18cd0b21fdbd515f4b14078ccf
treeba2f3b655ba0124d0a873881b9f7e918b6280056
parentefbae71643fee3a3edebf9de9934f923b2e60a36
net: phy: core: use genphy version of callbacks read_status and config_aneg per default

read_status and config_aneg are the only mandatory callbacks and most
of the time the generic implementation is used by drivers.
So make the core fall back to the generic version if a driver doesn't
implement the respective callback.

Also currently the core doesn't seem to verify that drivers implement
the mandatory calls. If a driver doesn't do so we'd just get a NPE.
With this patch this potential issue doesn't exit any longer.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/phy.c
include/linux/phy.h