]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/amdgpu/df: fix potential array out-of-bounds read
authorColin Ian King <colin.king@canonical.com>
Wed, 30 May 2018 16:41:44 +0000 (17:41 +0100)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 1 Jun 2018 14:45:05 +0000 (09:45 -0500)
commit036286e28e8ece7637cc62934f7dbc89e6656940
tree28d73323c6b2e426253b7b26a5d6702e669ddc8e
parent7ba01f9e12bb3f088f617cf69b589ea37bd5d6ed
drm/amdgpu/df: fix potential array out-of-bounds read

The comparison with the number of elements in array df_v3_7_channel_number
is off-by-one and can produce an array out-of-bounds read if
fb_channel_number is equal to the number of elements of the array. Fix
this by changing the comparison to >= instead of >.

Detected by CoverityScan, CID#1469489 ("Out-of-bounds read")

Fixes: 13b581502d51 ("drm/amdgpu/df: implement df v3_6 callback functions (v2)")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/df_v3_6.c