]> asedeno.scripts.mit.edu Git - linux.git/commit
USB: serial: digi_acceleport: use irqsave() in USB's complete callback
authorJohn Ogness <john.ogness@linutronix.de>
Sat, 23 Jun 2018 22:32:05 +0000 (00:32 +0200)
committerJohan Hovold <johan@kernel.org>
Tue, 26 Jun 2018 12:14:50 +0000 (14:14 +0200)
commit041b7db9668a60dc7f03c53fe4fe1c8e137e935b
tree13d61d51be523ed78577e73986ee06df71ad14c5
parentc75d18cc5a97e9d01d04ee7af457fddea38ca539
USB: serial: digi_acceleport: use irqsave() in USB's complete callback

The USB completion callback does not disable interrupts while acquiring
the lock. We want to remove the local_irq_disable() invocation from
__usb_hcd_giveback_urb() and therefore it is required for the callback
handler to disable the interrupts while acquiring the lock.
The callback may be invoked either in IRQ or BH context depending on the
USB host controller.
Use the _irqsave() variant of the locking primitives.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Johan Hovold <johan@kernel.org>
drivers/usb/serial/digi_acceleport.c