]> asedeno.scripts.mit.edu Git - linux.git/commit
block: silently forbid sending any ioctl to a partition
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 10 Jan 2018 15:54:52 +0000 (16:54 +0100)
committerJens Axboe <axboe@kernel.dk>
Wed, 10 Jan 2018 19:30:37 +0000 (12:30 -0700)
commit0478fe68685a428c71decc19abecd265a6d658dd
tree6657bf4a8000bdaa4deea628627dcca99a007821
parent7c3fb70f0341f9d924818e648906774921f4bcb3
block: silently forbid sending any ioctl to a partition

After the first few months, the message has not led to many bug reports.
It's been almost five years now, and in practice the main source of
it seems to be MTIOCGET that someone is using to detect tape devices.
While we could whitelist it just like CDROM_GET_CAPABILITY, this patch
just removes the message altogether.

The patch also removes the "safe but not very useful" ioctl whitelist,
as suggested by Christoph.  I doubt anything is using most of those
ioctls _in general_, let alone on a partition.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/scsi_ioctl.c