]> asedeno.scripts.mit.edu Git - linux.git/commit
usb: dwc3: gadget: Fix list_del corruption in dwc3_ep_dequeue
authorMayank Rana <mrana@codeaurora.org>
Fri, 23 Mar 2018 17:05:33 +0000 (10:05 -0700)
committerFelipe Balbi <felipe.balbi@linux.intel.com>
Mon, 21 May 2018 07:36:14 +0000 (10:36 +0300)
commit05645366f3893c160bd39ca49f3fe2f2f026f58b
treef9d2df80df94439a418cfb53eb42681e66b4cd73
parent691025107eb7544fdd25f836c8c6e857a344828b
usb: dwc3: gadget: Fix list_del corruption in dwc3_ep_dequeue

dwc3_ep_dequeue() waits for completion of End Transfer command using
wait_event_lock_irq(), which will release the dwc3->lock while waiting
and reacquire after completion. This allows a potential race condition
with ep_disable() which also removes all requests from started_list
and pending_list.

The check for NULL r->trb should catch this but currently it exits to
the wrong 'out1' label which calls dwc3_gadget_giveback(). Since its
list entry was already removed, if CONFIG_DEBUG_LIST is enabled a
'list_del corruption' bug is thrown since its next/prev pointers are
already LIST_POISON1/2. If r->trb is NULL it should simply exit to
'out0'.

Fixes: cf3113d893d4 ("usb: dwc3: gadget: properly increment dequeue pointer on ep_dequeue")
Cc: stable@vger.kernel.org # v4.12+
Signed-off-by: Mayank Rana <mrana@codeaurora.org>
Signed-off-by: Jack Pham <jackp@codeaurora.org>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
drivers/usb/dwc3/gadget.c