]> asedeno.scripts.mit.edu Git - linux.git/commit
[media] atmel-isi: Fix bad usage of IS_ERR_VALUE
authorGuenter Roeck <linux@roeck-us.net>
Tue, 9 Feb 2016 14:43:42 +0000 (12:43 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Thu, 3 Mar 2016 10:30:11 +0000 (07:30 -0300)
commit0724745fae8e2ad1da111f38741ed39828a575b6
tree95abf76cfc6fe847490454de230bd67c52f5ec25
parent1e77d55ac9c089ea8c9e5f2375d1cac3f29a99af
[media] atmel-isi: Fix bad usage of IS_ERR_VALUE

IS_ERR_VALUE() assumes that its parameter is an unsigned long.
It can not be used to check if an unsigned int reflects an error.
Doing so can result in the following build warning.

drivers/media/platform/soc_camera/atmel-isi.c:
In function "atmel_isi_probe":
include/linux/err.h:21:38: warning:
comparison is always false due to limited range of data type
drivers/media/platform/soc_camera/atmel-isi.c:1089:6: note:
in expansion of macro "IS_ERR_VALUE"

If that warning is seen, the return value from platform_get_irq() is not
checked for errors.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/platform/soc_camera/atmel-isi.c