]> asedeno.scripts.mit.edu Git - linux.git/commit
samples: bpf: print a warning about headers_install
authorJakub Kicinski <jakub.kicinski@netronome.com>
Wed, 5 Jun 2019 23:47:22 +0000 (16:47 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Thu, 6 Jun 2019 00:15:14 +0000 (02:15 +0200)
commit07c3bbdb1a9b2046631a2a2950a0c16e10cfcab3
treed00d4c0e183e8d2bec44f7c88e745349f394fc97
parent6685699e4ef5e9903d5c8bc6c2e6e13b931c98e1
samples: bpf: print a warning about headers_install

It seems like periodically someone posts patches to "fix"
header includes.  The issue is that samples expect the
include path to have the uAPI headers (from usr/) first,
and then tools/ headers, so that locally installed uAPI
headers take precedence.  This means that if users didn't
run headers_install they will see all sort of strange
compilation errors, e.g.:

  HOSTCC  samples/bpf/test_lru_dist
  samples/bpf/test_lru_dist.c:39:8: error: redefinition of ‘struct list_head’
   struct list_head {
          ^~~~~~~~~
   In file included from samples/bpf/test_lru_dist.c:9:0:
   ../tools/include/linux/types.h:69:8: note: originally defined here
    struct list_head {
           ^~~~~~~~~

Try to detect this situation, and print a helpful warning.

v2: just use HOSTCC (Jiong).

Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@netronome.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
samples/bpf/Makefile