]> asedeno.scripts.mit.edu Git - linux.git/commit
clk: divider: do not propagate rate change request when unnecessary
authorShawn Guo <shawn.guo@linaro.org>
Sun, 2 Jun 2013 14:20:55 +0000 (22:20 +0800)
committerMike Turquette <mturquette@linaro.org>
Mon, 10 Jun 2013 22:20:48 +0000 (15:20 -0700)
commit081c9025f49da427faf50b5c14143f98a21c5e85
tree331b2c1131840d40bae7c4234a9585df95b81aa0
parenta6a3ec7b512b975a9bb68ed9c4d55519d175acd9
clk: divider: do not propagate rate change request when unnecessary

If the current rate of parent clock is sufficient to provide child a
requested rate with a proper divider setting, the rate change request
should not be propagated.  Instead, changing the divider setting is good
enough to get child clock run at the requested rate.

On an imx6q clock configuration illustrated below,

  ahb --> ipg --> ipg_per
  132M    66M     66M

calling clk_set_rate(ipg_per, 22M) with the current
clk_divider_bestdiv() implementation will result in the rate change up
to ahb level like the following, because of the unnecessary/incorrect
rate change propagation.

  ahb --> ipg --> ipg_per
  66M     22M     22M

Fix the problem by trying to see if the requested rate can be achieved
by simply changing the divider value, and in that case return the
divider immediately from function clk_divider_bestdiv() as the best
one, so that all those unnecessary rate change propagation can be saved.

Reported-by: Anson Huang <b20788@freescale.com>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Mike Turquette <mturquette@linaro.org>
drivers/clk/clk-divider.c