]> asedeno.scripts.mit.edu Git - linux.git/commit
scsi: NCR5380: Don't call dsprintk() following reselection interrupt
authorFinn Thain <fthain@telegraphics.com.au>
Thu, 27 Sep 2018 01:17:11 +0000 (11:17 +1000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 28 Sep 2018 06:21:23 +0000 (02:21 -0400)
commit08267216b3f8aa5adc204bdccf8deb72c1cd7665
tree056e27ec0a39e0e8cf78a11595399789bde47bc9
parent45ddc1b24806cc8f1a09f23dd4e7b6e4a8ae36e1
scsi: NCR5380: Don't call dsprintk() following reselection interrupt

The X3T9.2 specification (draft) says, under "6.1.4.1 RESELECTION",

    ... The reselected initiator shall then assert the BSY signal
    within a selection abort time of its most recent detection of being
    reselected; this is required for correct operation of the time-out
    procedure.

The selection abort time is only 200 us which may be insufficient time for a
printk() call. Move the diagnostics to the error paths.

Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/NCR5380.c