]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/i915: Enable pipe HDR mode on ICL if only HDR planes are used
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 12 Apr 2019 18:30:09 +0000 (21:30 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 30 Apr 2019 19:14:43 +0000 (22:14 +0300)
commit09b25812db10fcbd7937c1b7ca279c5c0d77ba9d
tree98ec25ffe9c765c844753a9dec4956a9d1604f56
parent9b11215e40c5a0aefba9b026543fb0799f61bf6f
drm/i915: Enable pipe HDR mode on ICL if only HDR planes are used

The pipe has a special HDR mode with higher precision when only
HDR planes are active. Let's use it.

Curiously this fixes the kms_color gamma/degamma tests when
using a HDR plane, which is always the case unless one hacks
the test to use an SDR plane. If one does hack the test to use
an SDR plane it does pass already.

I have no actual explanation how the output after the gamma
LUT can be different between the two modes. The way the tests
are written should mean that the output should be identical
between the solid color vs. the gradient. But clearly that
somehow doesn't hold true for the HDR planes in non-HDR pipe
mode. Anyways, as long as we stick to one type of plane the
test should produce sensible results now.

v2: s/HDR_MODE/HDR_MODE_PRECISION/ (Shashank)

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190412183009.8237-2-ville.syrjala@linux.intel.com
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Tested-by: Uma Shankar <uma.shankar@intel.com>
Reviewed-by: Shashank Sharma <shashank.sharma@intel.com>
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/intel_display.c
drivers/gpu/drm/i915/intel_sprite.h