]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/pl111: Fix module probe bug
authorLinus Walleij <linus.walleij@linaro.org>
Thu, 3 May 2018 14:04:31 +0000 (16:04 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Thu, 3 May 2018 22:13:41 +0000 (00:13 +0200)
commit0a4587a034a43e5076770df10446214cfb3de8f8
tree1625bce6b1b8d4de87041035f86bc593355e28df
parent0d49f303e8a7006e0af3b58ed3809e1cad0900fb
drm/pl111: Fix module probe bug

Commit a30933c27602 ("drm/pl111: Support the Versatile Express")
Added a second module using the builtin_platform_driver() call,
which works fine as long as you do not try to build the PL111
driver as a module, because a module can only have one initcall
and cause the following build bug:

(...) multiple definition of `init_module' (...)

Reported-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Pawel Moll <pawel.moll@arm.com>
Cc: Eric Anholt <eric@anholt.net>
Cc: Robin Murphy <robin.murphy@arm.com>
Reviewed-by: Sean Paul <seanpaul@chromium.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Fixes: a30933c27602 ("drm/pl111: Support the Versatile Express")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20180503140431.5798-1-linus.walleij@linaro.org
drivers/gpu/drm/pl111/pl111_versatile.c
drivers/gpu/drm/pl111/pl111_vexpress.c
drivers/gpu/drm/pl111/pl111_vexpress.h