]> asedeno.scripts.mit.edu Git - linux.git/commit
serial: imx: fix cached UCR2 read on software reset
authorStefan Agner <stefan@agner.ch>
Fri, 20 Apr 2018 12:44:07 +0000 (14:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Apr 2018 07:53:36 +0000 (09:53 +0200)
commit0aa821d846c0590ad64a00af95a3dcc29263d70f
tree44c8369b1c4a8946bb0511613477681665658b26
parent6d215f83e5fccb3dd023e97fef1bd0029bfedde9
serial: imx: fix cached UCR2 read on software reset

To reset the UART the SRST needs be cleared (low active). According
to the documentation the bit will remain active for 4 module clocks
until it is cleared (set to 1).

Hence the real register need to be read in case the cached register
indicates that the SRST bit is zero.

This bug lead to wrong baudrate because the baud rate register got
restored before reset completed in imx_flush_buffer.

Fixes: 3a0ab62f43de ("serial: imx: implement shadow registers for UCRx and UFCR")
Signed-off-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/imx.c