]> asedeno.scripts.mit.edu Git - linux.git/commit
arm64: SW PAN: Point saved ttbr0 at the zero page when switching to init_mm
authorWill Deacon <will.deacon@arm.com>
Wed, 6 Dec 2017 10:42:10 +0000 (10:42 +0000)
committerWill Deacon <will.deacon@arm.com>
Wed, 6 Dec 2017 18:28:10 +0000 (18:28 +0000)
commit0adbdfde8cfc9415aeed2a4955d2d17b3bd9bf13
tree0e2beede647492b17790659ffaeeeccb09fc306f
parent8884b7bd7e52de20a801c5f457954ed212c0f625
arm64: SW PAN: Point saved ttbr0 at the zero page when switching to init_mm

update_saved_ttbr0 mandates that mm->pgd is not swapper, since swapper
contains kernel mappings and should never be installed into ttbr0. However,
this means that callers must avoid passing the init_mm to update_saved_ttbr0
which in turn can cause the saved ttbr0 value to be out-of-date in the context
of the idle thread. For example, EFI runtime services may leave the saved ttbr0
pointing at the EFI page table, and kernel threads may end up with stale
references to freed page tables.

This patch changes update_saved_ttbr0 so that the init_mm points the saved
ttbr0 value to the empty zero page, which always exists and never contains
valid translations. EFI and switch can then call into update_saved_ttbr0
unconditionally.

Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Vinayak Menon <vinmenon@codeaurora.org>
Cc: <stable@vger.kernel.org>
Fixes: 39bc88e5e38e9b21 ("arm64: Disable TTBR0_EL1 during normal kernel execution")
Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Reported-by: Vinayak Menon <vinmenon@codeaurora.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
arch/arm64/include/asm/efi.h
arch/arm64/include/asm/mmu_context.h