]> asedeno.scripts.mit.edu Git - linux.git/commit
ARM: imx51: fix a leaked reference by adding missing of_node_put
authorWen Yang <wen.yang99@zte.com.cn>
Fri, 1 Mar 2019 08:56:46 +0000 (16:56 +0800)
committerShawn Guo <shawnguo@kernel.org>
Tue, 19 Mar 2019 08:48:00 +0000 (16:48 +0800)
commit0c17e83fe423467e3ccf0a02f99bd050a73bbeb4
tree43d7aa5d83486fe0237dd35aa1e4ca5f55476477
parent1a7ee0efb26d6e25433c6d4428028ac614f55ff1
ARM: imx51: fix a leaked reference by adding missing of_node_put

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-imx/mach-imx51.c:64:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 57, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: NXP Linux Team <linux-imx@nxp.com>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
arch/arm/mach-imx/mach-imx51.c