]> asedeno.scripts.mit.edu Git - linux.git/commit
[media] zd1301: fix building interface driver without demodulator
authorArnd Bergmann <arnd@arndb.de>
Tue, 7 Feb 2017 13:01:41 +0000 (11:01 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 8 Feb 2017 13:59:39 +0000 (11:59 -0200)
commit0d1270df836fe9f5cc7e8001b7372ca4fa3f00f6
tree3d79a2e640e89ab81e443256d2c407e78d5f5277
parent9165ba166cac5e8c9abda2012ea37cc3430c0b14
[media] zd1301: fix building interface driver without demodulator

If the USB driver is enabled but the demodulator is not, we get a link error:

ERROR: "zd1301_demod_get_dvb_frontend" [drivers/media/usb/dvb-usb-v2/zd1301.ko] undefined!
ERROR: "zd1301_demod_get_i2c_adapter" [drivers/media/usb/dvb-usb-v2/zd1301.ko] undefined!

Such a configuration obviously makes no sense, but we should not fail
the build.  This tries to mimic what we have for other drivers by turning
the build failure into a runtime failure.

Alternatively we could use an unconditional 'select' or 'depends on' to enforce
a sane configuration.

Fixes: 47d65372b3b6 ("[media] zd1301_demod: ZyDAS ZD1301 DVB-T demodulator driver")
Fixes: 992b39872b80 ("[media] zd1301: ZyDAS ZD1301 DVB USB interface driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/zd1301_demod.h
drivers/media/usb/dvb-usb-v2/zd1301.c