]> asedeno.scripts.mit.edu Git - linux.git/commit
Revert "tty: fix NULL pointer issue when tty_port ops is not set"
authorJohan Hovold <johan@kernel.org>
Wed, 3 Apr 2019 07:40:53 +0000 (09:40 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Apr 2019 13:21:34 +0000 (15:21 +0200)
commit0d3cb6f6c67aab6284921619c838382fb6e4f5db
tree50681369128946c6227090a8c4ce82bba5924e3a
parentba44dc04300441b47618f9933bf36e75a280e5fe
Revert "tty: fix NULL pointer issue when tty_port ops is not set"

This reverts commit f4e68d58cf2b20a581759bbc7228052534652673.

TTY drivers using the tty-port abstraction all provide a pointer to a
set of port operations, which specifically cannot be NULL (or we'd find
out at first attempt to open a port).

Revert the recent commit which added unnecessary NULL-checks and whose
commit message indicated that it was fixing a real problem, which it did
not.

Note that even the two tty drivers for virtual devices currently
providing an empty set of operations probably should be implementing at
least some of the callbacks.

Cc: Fabien Dessenne <fabien.dessenne@st.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/tty_port.c