]> asedeno.scripts.mit.edu Git - linux.git/commit
gre: refetch erspan header from skb->data after pskb_may_pull()
authorCong Wang <xiyou.wangcong@gmail.com>
Fri, 6 Dec 2019 03:39:02 +0000 (19:39 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 7 Dec 2019 19:53:27 +0000 (11:53 -0800)
commit0e4940928c26527ce8f97237fef4c8a91cd34207
tree7e7f865d29451d37511dd9171e61992fbad6f8d0
parent02a896ca84874bbfcedc006303f2951dda89b298
gre: refetch erspan header from skb->data after pskb_may_pull()

After pskb_may_pull() we should always refetch the header
pointers from the skb->data in case it got reallocated.

In gre_parse_header(), the erspan header is still fetched
from the 'options' pointer which is fetched before
pskb_may_pull().

Found this during code review of a KMSAN bug report.

Fixes: cb73ee40b1b3 ("net: ip_gre: use erspan key field for tunnel lookup")
Cc: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Acked-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: William Tu <u9012063@gmail.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/gre_demux.c