]> asedeno.scripts.mit.edu Git - linux.git/commit
platform/x86: dell-smbios: Fix memory leaks in build_tokens_sysfs()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 16 Mar 2018 12:10:15 +0000 (15:10 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 2 Apr 2018 15:28:45 +0000 (18:28 +0300)
commit0e5b09b165510e2ea5c526e962c4edadd849ef4c
tree6decdb3de5a88a3c5b8eed60b0b7a4d898e5f5e4
parent2b5de0cc1fe0e2308dc1d2494de7917c707bd8ca
platform/x86: dell-smbios: Fix memory leaks in build_tokens_sysfs()

We're freeing "value_name" which is NULL, so that's a no-op, but we
intended to free "location_name" instead.  And then we don't free the
names in token_location_attrs[0] and token_value_attrs[0].

Fixes: 33b9ca1e53b4 ("platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/dell-smbios-base.c