]> asedeno.scripts.mit.edu Git - linux.git/commit
printk: do not preliminary split up cont buffer
authorSergey Senozhatsky <sergey.senozhatsky@gmail.com>
Tue, 2 Oct 2018 02:38:36 +0000 (11:38 +0900)
committerPetr Mladek <pmladek@suse.com>
Fri, 12 Oct 2018 08:03:39 +0000 (10:03 +0200)
commit0e96a19c4450253c3ddcff69140b1096f2c2adaf
tree34c8f6ef6c27265137829d293e5f36e3480a2232
parent3ac37a93fa9217e576bebfd4ba3e80edaaeb2289
printk: do not preliminary split up cont buffer

We have a proper 'overflow' check which tells us that we need to
split up existing cont buffer in separate records:

if (cont.len + len > sizeof(cont.buf))
cont_flush();

At the same time we also have one extra flush: "if cont buffer is
80% full then split it up" in cont_add():

if (cont.len > (sizeof(cont.buf) * 80) / 100)
cont_flush();

This looks to be redundant, since the existing "overflow" check
should work just fine, so remove this 80% check and wait for either
a normal cont termination \n, for preliminary flush due to
possible buffer overflow or for preliminary flush due to cont race.

Link: http://lkml.kernel.org/r/20181002023836.4487-4-sergey.senozhatsky@gmail.com
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Dmitriy Vyukov <dvyukov@google.com>
Cc: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Tejun Heo <tj@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
kernel/printk/printk.c