]> asedeno.scripts.mit.edu Git - linux.git/commit
iwlwifi: mvm: fix TSO with highly fragmented SKBs
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Sun, 8 Apr 2018 09:33:31 +0000 (12:33 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Wed, 30 May 2018 06:33:36 +0000 (09:33 +0300)
commit0eac9abace1629c20420d9122d6edc80d292b0ec
treedeab89789db2dd9958a55fd2655f0882089c8732
parent15c4e33030d172ac0d2a03ebbae4c3687a80ac7d
iwlwifi: mvm: fix TSO with highly fragmented SKBs

Our hardware has a limited amount of buffer descriptors
for each Tx packet. Because of that, there is a short
piece of code that makes sure that that we don't push too
many subframes in an A-MSDU because of subframes needs 2
buffer descriptors. This code also takes into account the
number of fragment of the skb since we also need a buffer
descriptor for each fragment in the skb.

This piece of code though didn't check that the resulting
number of subframes wasn't 0.

A user reported that using NFS client, he could get skbs
that are so fragmented that the code mentioned above
returned 0 for the number of subframes making
skb_gso_segment fail and subconsequently iwlwifi would WARN.

Fix this by make sure that num_subframes is at least 1.

This fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=199209

Fixes: a6d5e32f247c ("iwlwifi: mvm: send large SKBs to the transport")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/tx.c