]> asedeno.scripts.mit.edu Git - linux.git/commit
perf report: Fix incorrectly added dimensions as switch perf data file
authorJin Yao <yao.jin@linux.intel.com>
Fri, 20 Dec 2019 01:37:19 +0000 (09:37 +0800)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 20 Dec 2019 21:49:27 +0000 (18:49 -0300)
commit0feba17bd7ee3b7e03d141f119049dcc23efa94e
tree5c63acd22c41f81939a169e15e0446fe434c9c6f
parentf84ae29a6169318f9c929720c49d96323d2bbab9
perf report: Fix incorrectly added dimensions as switch perf data file

We observed an issue that was some extra columns displayed after switching
perf data file in browser. The steps to reproduce:

1. perf record -a -e cycles,instructions -- sleep 3
2. perf report --group
3. In browser, we use hotkey 's' to switch to another perf.data
4. Now in browser, the extra columns 'Self' and 'Children' are displayed.

The issue is setup_sorting() executed again after repeat path, so dimensions
are added again.

This patch checks the last key returned from __cmd_report(). If it's
K_SWITCH_INPUT_DATA, skips the setup_sorting().

Fixes: ad0de0971b7f ("perf report: Enable the runtime switching of perf data file")
Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Feng Tang <feng.tang@intel.com>
Cc: Jin Yao <yao.jin@intel.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20191220013722.20592-1-yao.jin@linux.intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/builtin-report.c