]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/hisilicon: hibmc: Don't overwrite fb helper surface depth
authorJohn Garry <john.garry@huawei.com>
Fri, 21 Sep 2018 17:25:26 +0000 (01:25 +0800)
committerXinliang Liu <xinliang.liu@linaro.org>
Wed, 26 Sep 2018 03:40:06 +0000 (11:40 +0800)
commit0ff9f49646353ce31312411e7e7bd2281492a40e
tree37cefd6451c8b79868e37f9284742e5a213547f5
parent331d880b35a76b5de0eec8cbcecbf615d758a5f9
drm/hisilicon: hibmc: Don't overwrite fb helper surface depth

Currently the driver overwrites the surface depth provided by the fb
helper to give an invalid bpp/surface depth combination.

This has been exposed by commit 70109354fed2 ("drm: Reject unknown legacy
bpp and depth for drm_mode_addfb ioctl"), which now causes the driver to
fail to probe.

Fix by not overwriting the surface depth.

Fixes: d1667b86795a ("drm/hisilicon/hibmc: Add support for frame buffer")
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Xinliang Liu <z.liuxinliang@hisilicon.com>
Signed-off-by: Xinliang Liu <z.liuxinliang@hisilicon.com>
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c