]> asedeno.scripts.mit.edu Git - linux.git/commit
cls_bpf: fix offload assumptions after callback conversion
authorJakub Kicinski <jakub.kicinski@netronome.com>
Tue, 19 Dec 2017 21:32:13 +0000 (13:32 -0800)
committerDavid S. Miller <davem@davemloft.net>
Wed, 20 Dec 2017 18:08:18 +0000 (13:08 -0500)
commit102740bd9436a3a6ba129af3a48271d794009fa5
treef597b469e6fcb2ed5f2c9614a48041ffd3909884
parent21b5944350052d2583e82dd59b19a9ba94a007f0
cls_bpf: fix offload assumptions after callback conversion

cls_bpf used to take care of tracking what offload state a filter
is in, i.e. it would track if offload request succeeded or not.
This information would then be used to issue correct requests to
the driver, e.g. requests for statistics only on offloaded filters,
removing only filters which were offloaded, using add instead of
replace if previous filter was not added etc.

This tracking of offload state no longer functions with the new
callback infrastructure.  There could be multiple entities trying
to offload the same filter.

Throw out all the tracking and corresponding commands and simply
pass to the drivers both old and new bpf program.  Drivers will
have to deal with offload state tracking by themselves.

Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/netronome/nfp/bpf/main.c
include/net/pkt_cls.h
net/sched/cls_bpf.c