]> asedeno.scripts.mit.edu Git - linux.git/commit
leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger
authorAkinobu Mita <akinobu.mita@gmail.com>
Sun, 29 Sep 2019 14:18:49 +0000 (23:18 +0900)
committerPavel <pavel@ucw.cz>
Sun, 3 Nov 2019 16:38:14 +0000 (17:38 +0100)
commit11f70002213774ed233950f71ea8803fa3700aa3
treeba8c781e79c59e15456b49b1a363a15be74955c7
parenta2cafdfd8cf5ad8adda6c0ce44a59f46431edf02
leds: remove PAGE_SIZE limit of /sys/class/leds/<led>/trigger

Reading /sys/class/leds/<led>/trigger returns all available LED triggers.
However, the size of this file is limited to PAGE_SIZE because of the
limitation for sysfs attribute.

Enabling LED CPU trigger on systems with thousands of CPUs easily hits
PAGE_SIZE limit, and makes it impossible to see all available LED triggers
and which trigger is currently activated.

We work around it here by converting /sys/class/leds/<led>/trigger to
binary attribute, which is not limited by length. This is _not_ good
design, do not copy it.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>A
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
drivers/leds/led-class.c
drivers/leds/led-triggers.c
drivers/leds/leds.h
include/linux/leds.h