]> asedeno.scripts.mit.edu Git - linux.git/commit
clk: divider: fix incorrect usage of container_of
authorJerome Brunet <jbrunet@baylibre.com>
Thu, 21 Dec 2017 16:30:54 +0000 (17:30 +0100)
committerStephen Boyd <sboyd@codeaurora.org>
Thu, 28 Dec 2017 23:16:04 +0000 (15:16 -0800)
commit12a26c298d2a8b1cab498533fa65198e49e3afd3
tree131818a7e5b13dbb5d8556017ff06354415d097e
parent4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323
clk: divider: fix incorrect usage of container_of

divider_recalc_rate() is an helper function used by clock divider of
different types, so the structure containing the 'hw' pointer is not
always a 'struct clk_divider'

At the following line:
> div = _get_div(table, val, flags, divider->width);

in several cases, the value of 'divider->width' is garbage as the actual
structure behind this memory is not a 'struct clk_divider'

Fortunately, this width value is used by _get_val() only when
CLK_DIVIDER_MAX_AT_ZERO flag is set. This has never been the case so
far when the structure is not a 'struct clk_divider'. This is probably
why we did not notice this bug before

Fixes: afe76c8fd030 ("clk: allow a clk divider with max divisor when zero")
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Sylvain Lemieux <slemieux.tyco@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
drivers/clk/clk-divider.c
drivers/clk/hisilicon/clkdivider-hi6220.c
drivers/clk/nxp/clk-lpc32xx.c
drivers/clk/qcom/clk-regmap-divider.c
drivers/clk/sunxi-ng/ccu_div.c
drivers/gpu/drm/msm/dsi/pll/dsi_pll_14nm.c
drivers/rtc/rtc-ac100.c
include/linux/clk-provider.h