]> asedeno.scripts.mit.edu Git - linux.git/commit
USB: yurex: Check for truncation in yurex_read()
authorBen Hutchings <ben.hutchings@codethink.co.uk>
Wed, 15 Aug 2018 20:45:37 +0000 (21:45 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Sep 2018 11:27:06 +0000 (13:27 +0200)
commit14427b86837a4baf1c121934c6599bdb67dfa9fc
tree024d505235dfa259b164e97c4a023d4b6325fb94
parent7e10f14ebface44a48275c8d6dc1caae3668d5a9
USB: yurex: Check for truncation in yurex_read()

snprintf() always returns the full length of the string it could have
printed, even if it was truncated because the buffer was too small.
So in case the counter value is truncated, we will over-read from
in_buffer and over-write to the caller's buffer.

I don't think it's actually possible for this to happen, but in case
truncation occurs, WARN and return -EIO.

Signed-off-by: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/yurex.c