]> asedeno.scripts.mit.edu Git - linux.git/commit
media: videobuf2-dma-sg: Prevent size from overflowing
authorSakari Ailus <sakari.ailus@linux.intel.com>
Wed, 12 Dec 2018 12:44:14 +0000 (07:44 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Thu, 23 May 2019 14:18:19 +0000 (10:18 -0400)
commit14f28f5cea9e3998442de87846d1907a531b6748
tree4bca9373f00bf4ce1db88f848de7e3ef23597808
parentdefcdc5d89ced780fb45196d539d6570ec5b1ba5
media: videobuf2-dma-sg: Prevent size from overflowing

buf->size is an unsigned long; casting that to int will lead to an
overflow if buf->size exceeds INT_MAX.

Fix this by changing the type to unsigned long instead. This is possible
as the buf->size is always aligned to PAGE_SIZE, and therefore the size
will never have values lesser than 0.

Note on backporting to stable: the file used to be under
drivers/media/v4l2-core, it was moved to the current location after 4.14.

Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/common/videobuf2/videobuf2-dma-sg.c