]> asedeno.scripts.mit.edu Git - linux.git/commit
power: supply: axp288_charger: Properly stop work on probe-error / remove
authorHans de Goede <hdegoede@redhat.com>
Tue, 26 Dec 2017 12:59:09 +0000 (13:59 +0100)
committerSebastian Reichel <sebastian.reichel@collabora.co.uk>
Mon, 8 Jan 2018 17:38:57 +0000 (18:38 +0100)
commit165c2357744e41391902a2a72dd170beb60c28d5
tree5ece2c7998f05ade10ec4629e2d46426eab21545
parent8c0a0a2959565d39b0f1b9685dc05f00caa04789
power: supply: axp288_charger: Properly stop work on probe-error / remove

Properly stop any work we may have queued on probe-errors / remove.

Rather then adding a remove driver callback for this, and goto style
error handling to probe, use a devm_action for this.

The devm_action gets registered before we register any of the extcon
notifiers which may queue the work, devm does cleanup in reverse order,
so this ensures that the notifiers are removed before we cancel the work.

Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
drivers/power/supply/axp288_charger.c