]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/sched: Set error to s_fence if HW job submission failed.
authorAndrey Grodzovsky <andrey.grodzovsky@amd.com>
Thu, 24 Oct 2019 19:39:06 +0000 (15:39 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 30 Oct 2019 15:56:15 +0000 (11:56 -0400)
commit167bf96014a095753053595f3224fcdeb49ac3c8
tree9bf1d783f3fb5bb24d0599a02685a1d46bcd3f38
parent47661f6dad42e1241cdef82c5e06cfb7027a3f59
drm/sched: Set error to s_fence if HW job submission failed.

Problem:
When run_job fails and HW fence returned is NULL we still signal
the s_fence to avoid hangs but the user has no way of knowing if
the actual HW job was ran and finished.

Fix:
Allow .run_job implementations to return ERR_PTR in the fence pointer
returned and then set this error for s_fence->finished fence so whoever
wait on this fence can inspect the signaled fence for an error.

Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/scheduler/sched_main.c