]> asedeno.scripts.mit.edu Git - linux.git/commit
sunrpc: silence build warning in gss_fill_context
authorJeff Layton <jlayton@redhat.com>
Thu, 7 Feb 2013 15:29:06 +0000 (10:29 -0500)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Sun, 17 Feb 2013 20:37:14 +0000 (15:37 -0500)
commit173db3093474e7691f2c2f3136313565bd366f6c
treefe5289c053f09dd4c1b1006942aa57869bbf448b
parent96aa1549afa6c79ae4a4f099de861efd218c38d8
sunrpc: silence build warning in gss_fill_context

Since commit 620038f6d23, gcc is throwing the following warning:

  CC [M]  net/sunrpc/auth_gss/auth_gss.o
In file included from include/linux/sunrpc/types.h:14:0,
                 from include/linux/sunrpc/sched.h:14,
                 from include/linux/sunrpc/clnt.h:18,
                 from net/sunrpc/auth_gss/auth_gss.c:45:
net/sunrpc/auth_gss/auth_gss.c: In function ‘gss_pipe_downcall’:
include/linux/sunrpc/debug.h:45:10: warning: ‘timeout’ may be used
uninitialized in this function [-Wmaybe-uninitialized]
    printk(KERN_DEFAULT args); \
          ^
net/sunrpc/auth_gss/auth_gss.c:194:15: note: ‘timeout’ was declared here
  unsigned int timeout;
               ^
If simple_get_bytes returns an error, then we'll end up calling printk
with an uninitialized timeout value. Reasonably harmless, but fairly
simple to fix by removing the printout of the uninitialised parameters.

Cc: Andy Adamson <andros@netapp.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
[Trond: just remove the parameters rather than initialising timeout]
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
net/sunrpc/auth_gss/auth_gss.c